cluster-update rollback=False is not respected

Bug #1664781 reported by Vijendar Komalla
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
Vijendar Komalla

Bug Description

explicitly setting the rollback=False in the following CURL request, but it cluster was rolledback.
curl -g -i -X PATCH http://xxxxx:9511/v1/clusters/k8s-cluster1/?rollback=False -H "OpenStack-API-Version: container-infra latest" -H "X-Auth-Token:-xxxxxx-xx" -H "Content-Type: application/json" -H "Accept: application/json" -H "User-Agent: None" -d '[{"path": "/node_count", "value": 2, "op": "replace"}]'

magnum cluster-list
| 5bcb7eeb-737c-46a9-9714-db6052633243 | k8s-cluster1 | testkey | 2 | 1 | UPDATE_IN_PROGRESS |

magnum cluster-list
| 5bcb7eeb-737c-46a9-9714-db6052633243 | k8s-cluster1 | testkey | 1 | 1 | ROLLBACK_IN_PROGRESS |

magnum cluster-list
| 5bcb7eeb-737c-46a9-9714-db6052633243 | k8s-cluster1 | testkey | 1 | 1 | ROLLBACK_COMPLETE |

Changed in magnum:
assignee: nobody → Vijendar Komalla (vijendar-komalla)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/434403

Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/434403
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=ee509ae323b2db469e663fcaef9647a3b111025d
Submitter: Jenkins
Branch: master

commit ee509ae323b2db469e663fcaef9647a3b111025d
Author: Vijendar Komalla <email address hidden>
Date: Wed Feb 15 11:06:27 2017 -0600

    Fix for cluster-update rollback issue

    Currently cluster-update is rolling back in case of update
    failure irrespective of whether the rollback flag set to
    True or False. This change fixes the issue by setting the
    right parameter type in cluster patch method.

    Change-Id: I6c28c583e7e3b98622634ac2381513b442eb57b6
    Closes-Bug: #1664781

Changed in magnum:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 4.1.0

This issue was fixed in the openstack/magnum 4.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.