libeditframe 'R' key not rotating pin while dragging it

Bug #1661866 reported by Dick Hollenbeck
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Undecided
Oliver

Bug Description

Today's HEAD:

While dragging a pin in the schematic part editor, the 'R' seems to be sending the editor into some unknown event loop. I could not even find out where in the debugger. While dragging, if instead you use the right click popup menu, you can successfully rotate a pin while dragging it.

Start by putting mouse over a pin, hit the 'M' key to begin drag, then press 'R'.
This does not work. However instead of 'R' the right click popup menu for rotate does work.

Found that if you press 'R' before 'M' the pin rotates as expected.
Found that older versions worked, M then R worked.

description: updated
Revision history for this message
Diogo (diogocondeco) wrote :

I can confirm this issue...
It was introduced by commit 9319ef034dbf0421ebbd2c78f7ee41f01bb56c0c which was the fix for this bug report https://bugs.launchpad.net/kicad/+bug/1660875.

Attached is a patch which hopefully fixes this second issue.

Revision history for this message
Dick Hollenbeck (dickelbeck) wrote :

Diogo

That seems to be a good fix for this bug, nice work.

Thank you,

Dick

Changed in kicad:
status: New → Fix Committed
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision a5dcc192dccd68da1c2826c61073d8281b258afa
https://git.launchpad.net/kicad/patch/?id=a5dcc192dccd68da1c2826c61073d8281b258afa

Changed in kicad:
assignee: nobody → Oliver (schrodingersgat)
Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

@Diogo, I used Oliver's patch because it also fixed a related issue with the horizontal and vertical mirror hotkeys. Thank you for providing a patch.

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.