[regression] Segfault on detect_fd_leaks during acceptance tests (in DisplayConfiguration/{DisplayFormatSetting,DisplaySubpixelSetting})
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Medium
|
Cemil Azizoglu | ||
| 0.26 |
Fix Released
|
Critical
|
Cemil Azizoglu | ||
| mir (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
I've seen this quite often in a silo... Not so often in CI.
8: [ RUN ] DisplayConfigur
8: [2017-02-03 01:05:22.479325] mirserver: Starting
8: [2017-02-03 01:05:22.479397] mirserver: Selected driver: mir:stub-graphics (version 0.26.1)
8: [2017-02-03 01:05:22.489793] mirserver: Using software cursor
8: [2017-02-03 01:05:22.492185] mirserver: Selected input driver: mir:stub-input (version: 0.26.1)
8: [2017-02-03 01:05:22.492233] mirserver: Mir version 0.26.1
8: [2017-02-03 01:05:22.492401] mirserver: Initial display configuration:
8: [2017-02-03 01:05:22.492420] mirserver: Output 1: VGA connected, used
8: [2017-02-03 01:05:22.492430] mirserver: Physical size 0.0" 0x0mm
8: [2017-02-03 01:05:22.492436] mirserver: Power is on
8: [2017-02-03 01:05:22.492444] mirserver: Current mode 4x3 10.00Hz
8: [2017-02-03 01:05:22.492451] mirserver: Preferred mode 4x3 10.00Hz
8: [2017-02-03 01:05:22.492457] mirserver: Orientation normal
8: [2017-02-03 01:05:22.492463] mirserver: Logical size 4x3
8: [2017-02-03 01:05:22.492468] mirserver: Logical position +0+0
8: [2017-02-03 01:05:22.492474] mirserver: Output 2: VGA disconnected
8: [2017-02-03 01:05:22.492480] mirserver: Output 3: VGA connected, unused
8: [2017-02-03 01:05:22.492486] mirserver: Physical size 0.0" 0x0mm
8: [2017-02-03 01:05:22.492491] mirserver: Power is off
8: [2017-02-03 01:05:22.511553] mirserver: New display configuration:
8: [2017-02-03 01:05:22.511586] mirserver: Output 1: VGA connected, used
8: [2017-02-03 01:05:22.511597] mirserver: Physical size 0.0" 0x0mm
8: [2017-02-03 01:05:22.511603] mirserver: Power is on
8: [2017-02-03 01:05:22.511611] mirserver: Current mode 4x3 10.00Hz
8: [2017-02-03 01:05:22.511618] mirserver: Preferred mode 4x3 10.00Hz
8: [2017-02-03 01:05:22.511624] mirserver: Orientation normal
8: [2017-02-03 01:05:22.511629] mirserver: Logical size 4x3
8: [2017-02-03 01:05:22.511635] mirserver: Logical position +0+0
8: [2017-02-03 01:05:22.511661] mirserver: New base display configuration:
8: [2017-02-03 01:05:22.526758] mirserver: Stopping
8: /<<BUILDDIR>
8: 27471 Done | detect_fd_leaks
8/20 Test #8: mir_acceptance_
Running main() from main.cpp
Note: Google Test filter = -:
[==========] Running 517 tests from 86 test cases.
Related branches
- Cemil Azizoglu (community): Disapprove
-
Diff: 1470 lines (+797/-80)31 files modifiedCMakeLists.txt (+1/-1)
debian/changelog (+27/-0)
include/client/mir_toolkit/client_types.h (+9/-0)
include/client/mir_toolkit/extensions/gbm_buffer.h (+90/-0)
include/client/mir_toolkit/mir_display_configuration.h (+2/-1)
include/client/mir_toolkit/rs/mir_render_surface.h (+22/-1)
src/client/display_configuration_api.cpp (+1/-1)
src/client/mir_presentation_chain_api.cpp (+22/-0)
src/client/mir_render_surface_api.cpp (+1/-0)
src/client/symbols.map (+2/-0)
src/platform/options/default_configuration.cpp (+1/-1)
src/platforms/mesa/client/client_buffer.cpp (+8/-4)
src/platforms/mesa/client/client_platform.cpp (+149/-5)
src/platforms/mesa/client/client_platform.h (+2/-1)
src/platforms/mesa/include/native_buffer.h (+3/-0)
src/platforms/mesa/server/kms/real_kms_display_configuration.cpp (+1/-0)
src/server/compositor/multi_monitor_arbiter.cpp (+2/-1)
src/server/frontend/session_mediator.cpp (+2/-1)
src/server/graphics/nested/nested_display_configuration.cpp (+8/-5)
src/server/graphics/nested/nested_display_configuration.h (+1/-1)
src/server/scene/application_session.cpp (+3/-0)
src/server/shell/surface_specification.cpp (+3/-1)
src/utils/out.c (+0/-3)
tests/acceptance-tests/test_custom_window_management.cpp (+47/-0)
tests/acceptance-tests/test_new_display_configuration.cpp (+8/-5)
tests/acceptance-tests/test_presentation_chain.cpp (+228/-43)
tests/unit-tests/compositor/test_multi_monitor_arbiter.cpp (+17/-0)
tests/unit-tests/frontend/test_session_mediator.cpp (+22/-0)
tests/unit-tests/platforms/mesa/client/test_client_platform.cpp (+97/-5)
tests/unit-tests/platforms/nested/mir_display_configuration_builder.cpp (+2/-0)
tests/unit-tests/platforms/nested/test_nested_display_configuration.cpp (+16/-0)
- Chris Halse Rogers: Approve
- Daniel van Vugt: Approve
- Mir CI Bot: Approve (continuous-integration)
-
Diff: 30 lines (+8/-5)1 file modifiedtests/acceptance-tests/test_new_display_configuration.cpp (+8/-5)
- Michał Sawicz: Disapprove
-
Diff: 13 lines (+6/-0)1 file modifieddebian/changelog (+6/-0)
| Changed in mir: | |
| importance: | Undecided → High |
| milestone: | none → 1.0.0 |
| Daniel van Vugt (vanvugt) wrote | #1 |
| Changed in mir: | |
| importance: | High → Medium |
| Cemil Azizoglu (cemil-azizoglu) wrote | #2 |
| tags: | added: silo |
| Changed in mir: | |
| importance: | Medium → High |
| tags: | added: testsfail |
| Cemil Azizoglu (cemil-azizoglu) wrote | #3 |
| Changed in mir: | |
| importance: | High → Critical |
| milestone: | 1.0.0 → 0.26.2 |
| Cemil Azizoglu (cemil-azizoglu) wrote | #4 |
| Daniel van Vugt (vanvugt) wrote | #5 |
| Changed in mir: | |
| milestone: | 0.26.2 → 1.0.0 |
| importance: | Critical → Undecided |
| Cemil Azizoglu (cemil-azizoglu) wrote | #6 |
| Daniel van Vugt (vanvugt) wrote | #7 |
| Changed in mir: | |
| assignee: | nobody → Cemil Azizoglu (cemil-azizoglu) |
| Changed in mir: | |
| status: | New → In Progress |
| Daniel van Vugt (vanvugt) wrote | #8 |
| summary: |
- seg fault on detect_fd_leaks + Segfault on detect_fd_leaks during acceptance tests: + DisplayConfiguration/{DisplayFormatSetting,DisplaySubpixelSetting} |
| Changed in mir: | |
| importance: | Undecided → High |
| Mir CI Bot (mir-ci-bot) wrote Re: Segfault on detect_fd_leaks during acceptance tests: DisplayConfiguration/{DisplayFormatSetting,DisplaySubpixelSetting} | #9 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Daniel van Vugt (vanvugt) wrote | #10 |
| Daniel van Vugt (vanvugt) wrote | #11 |
| tags: | added: regression |
| Changed in mir: | |
| importance: | High → Medium |
| summary: |
- Segfault on detect_fd_leaks during acceptance tests: + [regression] Segfault on detect_fd_leaks during acceptance tests: DisplayConfiguration/{DisplayFormatSetting,DisplaySubpixelSetting} |
| summary: |
- [regression] Segfault on detect_fd_leaks during acceptance tests: - DisplayConfiguration/{DisplayFormatSetting,DisplaySubpixelSetting} + [regression] Segfault on detect_fd_leaks during acceptance tests (in + DisplayConfiguration/{DisplayFormatSetting,DisplaySubpixelSetting}) |
| Changed in mir (Ubuntu): | |
| status: | New → Fix Released |
| importance: | Undecided → Medium |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
Not happening on a daily basis so we can deprioritize.
Although I'm pretty sure this is an old issue. Wonder if it's a duplicate...