Name of cpc_uuid config option

Bug #1659304 reported by Andreas Maier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
nova-dpm
Fix Released
Medium
Andreas Scheuring
os-dpm
Fix Released
Medium
Andreas Maier

Bug Description

The "cpc_uuid" config option in the os-dpm and nova-dpm projects has a misleading name. The official term that can be found in the HMC API book is "unique identifier" in the description and the resource property name is 'object-id'. The HMC API book does not reveal anywhere that the format of the unique identifier is a UUID.

Change sets #425156 and #425092 already fix the help text for this config option in both projects, but the issue of its config option name still remains to be addressed.

The proposal is to change the config option name from "cpc_uuid" to "cpc_id".

A more precise alternative would be "cpc_object_id", but we have to keep in mind that some HMC managed resources have an "element-id" instead of the "object-id" and carrying that distinction into the OpenStack config option names also creates some complexity, so I don't think we should use "cpc_object_id".

A decision about the option name should be made, and then it needs to be updated in the code and in the config option definitions.

Andreas Maier (maiera)
Changed in networking-dpm:
assignee: nobody → Andreas Maier (maiera)
Changed in nova-dpm:
assignee: nobody → Andreas Maier (maiera)
Changed in os-dpm:
assignee: nobody → Andreas Maier (maiera)
Revision history for this message
Andreas Maier (maiera) wrote :

We discussed this briefly between Andreas S, Markus Z and myself, and all agreed that we want to have the longer and more precise name, i.e. "cpc_object_id" in this case.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-dpm (master)

Fix proposed to branch: master
Review: https://review.openstack.org/425210

Changed in os-dpm:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova-dpm (master)

Fix proposed to branch: master
Review: https://review.openstack.org/425217

Changed in nova-dpm:
status: New → In Progress
Andreas Maier (maiera)
no longer affects: networking-dpm
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-dpm (master)

Reviewed: https://review.openstack.org/425210
Committed: https://git.openstack.org/cgit/openstack/os-dpm/commit/?id=94d8e2293fbcdee924430ea85a050a31d742f6bf
Submitter: Jenkins
Branch: master

commit 94d8e2293fbcdee924430ea85a050a31d742f6bf
Author: Andreas Maier <email address hidden>
Date: Wed Jan 25 15:36:36 2017 +0100

    Changed name of cpc_uuid config option to cpc_object_id

    Reason for the change is that the HMC API book does not
    mention anywhere that the format of the ID is a UUID, and
    the name of the resource property is "object-id".

    This change set changes the name of the DPM config option
    "cpc_uuid" to "cpc_object_id", and updates the unit testcase
    accordingly.

    Change-Id: I9f4b7dbbdbb19d00c6f0752c028a7462c2bbee3e
    Partial-Bug: 1659304
    Signed-off-by: Andreas Maier <email address hidden>

Changed in nova-dpm:
assignee: Andreas Maier (maiera) → Andreas Scheuring (andreas-scheuring)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova-dpm (master)

Reviewed: https://review.openstack.org/425217
Committed: https://git.openstack.org/cgit/openstack/nova-dpm/commit/?id=5fa46366d952ee84ef9a8540fab193a083d6309e
Submitter: Jenkins
Branch: master

commit 5fa46366d952ee84ef9a8540fab193a083d6309e
Author: Andreas Maier <email address hidden>
Date: Wed Jan 25 15:51:32 2017 +0100

    Changed name of cpc_uuid config option to cpc_object_id

    Reason for the change is that the HMC API book does not mention
    anywhere that the format of the ID is a UUID, and the name of the
    resource property is "object-id". This change set changes the
    name of the DPM config option "cpc_uuid" to "cpc_object_id",
    and the devstack variables CPC_UUID to CPC_OBJECT_ID, and
    updates any use of that and the unit testcases accordingly.

    Change-Id: I6153ac791d4296101dc00f23dfb7fb7c3d2fee2c
    Partial-Bug: 1659304
    Signed-off-by: Andreas Maier <email address hidden>

Changed in os-dpm:
status: In Progress → Fix Committed
Changed in nova-dpm:
status: In Progress → Fix Committed
Changed in nova-dpm:
importance: Undecided → Medium
Changed in os-dpm:
importance: Undecided → Medium
Changed in nova-dpm:
status: Fix Committed → Fix Released
Changed in os-dpm:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.