deja-dup refers to "Files" instead of "Caja"

Status changed to 'Confirmed' because the bug affects multiple users.

Does it work though? In Caja? Do you get the restore/revert options when you right-click?

Cause if I understand correctly those are allowed by libdeja-dup.so in /usr/lib/[x86_64-linux-gnu]/nautilus/extensions-3.0, so perhaps Caja looks into a different directory (.../caja/extensions-3.0?).

"Files" should be changed to "the file manager" rather than "Caja" since the name is still Files in Ubuntu (Unity and GNOME). Unless someone particularly motivated wants to fork Déjà-Dup to make a MATE version that specifically says "Caja".

Yes, it works in Caja. I originally filed this against Ubuntu Mate, thinking that it was something to be fixed in Mate, since Files isn't the file manager in Mate :/

It could be fixed in Ubuntu MATE if they had their own fork of Déjà-Dup, like they have their own fork of Files, Gedit, Eye of GNOME, Evince, GNOME Terminal, File Roller.

Another Nautilus fork, Nemo, retained the name Files for its icon in the menus. Didn't MATE did the same?

I can only suggest the following patch, as I'm not a Déjà-Dup developer. I can't tell if it's a good change : "a compatible file manager" is less computer-illiterate-friendly than "Files" or "Caja".

The attachment "Change "Files" to "a compatible file manager" to encompass Nautilus forks e.g. Caja" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

Naëls patch is applicable for the upstream package, I will therefore send this to the upstream and ask for triaging.

@Nathanaël: Could you please upload your patch to a (upstream) branch and propose it for merging?

@Russ Phillips (or anyone using MATE):

Can you confirm that "Caja" is the user-facing name of the file manager in MATE desktop environment? And by that I mean, its name in the menus. Thanks.

Cause in Unity DE and Cinnamon DE, I'm quite certain that the user-facing name of Nautilus and Nemo, respectively, is "Files", even though many people refer to them by their internal names Nautilus and Nemo.

@Russ Phillips:

Don't bother, I checked by myself in the .desktop file.

Quick work :) I wouldn't have had the chance to check before tomorrow.

@Vej (and @Russ too):

I have uploaded my (trivial) patch to an upstream branch, but haven't proposed it for merging yet. To be honest, I'm not too wild about changing the name "Files" to accommodate Caja (sorry), because of the reasons I wrote down in the branch's description:

https://code.launchpad.net/~nathanael-naeri/deja-dup/fix-1657092

Vej, could you please consult with Michael, directly or on the mailing-list, to get his opinion on supporting another desktop environment and/or Nautilus fork (MATE/Caja), and potentially, supporting all DE that use Nautilus forks? Right now Déjà-Dup only officially integrates with GNOME/Nautilus and Unity/Nautilus as far as I know.

If he's OK with Russ's suggestion then I'll be happy to propose for merging of course.

@Naël I see your point and will discuss this on the mailing list.

Reproducing what I wrote in the mailing list:

==
In reality, we only really support what we can easily handle.
Officially, we've always targeted both GNOME and whatever Ubuntu's UI
happens to be (used to be simply GNOME, but has diverged a bit).

I'd prefer to keep tight integration and avoid supporting every
environment under the sun (per our mission statement [1]). But where
it's easy to support another desktop environment, I don't mind.

If it's a simple "if getenv(AM_IN_MATE) == 1, then Caja else Files", I
think that's trivial enough to merge. But I'd prefer to avoid a
slippery slope of more and more integration points.

Seem reasonable?
==

I'm also interested in confirming whether the menus call Caja "Files" or "Caja" though. That might render this all moot.

I originally posted this bug in Mate, since I thought they maintained a forked version of Nautilus and Deja Dup, and this would be something they'd want to include in that.

I'll attach a screenshot to confirm that the file manager is listed as "Caja" in the application menu.

Russ, can you please post the values of the following environment variables in MATE, I'm going to try and implement something and I'm not sure which one to use (probably the last one). You can use printenv var or echo $var to find them out. Thanks.

SESSION
GDMSESSION
DESKTOP_SESSION
XDG_CURRENT_DESKTOP

Here you go:

russ@Chapterhouse:~$ echo $SESSION

russ@Chapterhouse:~$ echo $GDMSESSION
mate
russ@Chapterhouse:~$ echo $DESKTOP_SESSION
mate
russ@Chapterhouse:~$ echo $XDG_CURRENT_DESKTOP
MATE

I wish I was knowledgeable enough to fix less trivial bugs. In the meantime, here are two branches. Michael, which one would you like I request a merge of?

https://code.launchpad.net/~nathanael-naeri/deja-dup/fix-1657092-a

Changes the word "Files" to "the file manager". The more accurate "a compatible file manager" or "a supported file manager" can be considered too.

https://code.launchpad.net/~nathanael-naeri/deja-dup/fix-1657092-b

Uses "Files" or "Caja" depending on the environment variable XDG_CURRENT_DESKTOP ("Caja" if it's MATE, "Files" if it's something else or unset). To test in the test shell, make a first backup, and open deja-dup-preferences as follow:

  $ XDG_CURRENT_DESKTOP=Unity deja-dup-preferences
  $ XDG_CURRENT_DESKTOP=MATE deja-dup-preferences

PS [Michael]: I don't know if Launchpad notified you, but you'll want to read my follow-up comments on my last merge request : https://code.launchpad.net/~nathanael-naeri/deja-dup/fix-1549776/+merge/317042

Thank you Nathanaël!

I've committed your 'b' version (with a small change to translate the file manager names).

@Michael: Sweet, thanks for merging!

@Vej, C de-Avillez: It's nice to nominate this bug for Xenial and Yakkety, but I'm not sure it's really worth fixing in these series, or that it fits the SRU requirements (I would personally go with Won't Fix for the published releases).

This text is only visible after a first full backup. I will change the [Test Case] accordingly.

@Nathanaël: It can be debated, if this qualifies for an SRU. I would put it under "Bugs which do not fit under above categories, but (1) have an obviously safe patch and (2) affect an application rather than critical infrastructure packages (like X.org or the kernel)." Nevertheless, I will currently work on getting this to zesty.

Status changed to 'Confirmed' because the bug affects multiple users.

I prepared a patch for zesty and seek sponsorship.
Please note that this is my first Ubuntu downstream patch (so please be detailed in your feedback if necessary).

I'm still not convinced that this is worth a SRU, or qualifies for one. The provision about "bugs which [...] (1) have an obviously safe patch and (2) affect an application" in the SRU guidelines applies only to bugs which have "high potential for improving the user experience", and I'm just not sure this particular bug has high potential for that (just potential).

Nevertheless, the debdiff looks good to me, if I understand it correctly. Shouldn't you subscribe ubuntu-sponsors? Or they won't notice it. (Again, IIUC.)

This bug was fixed in the package deja-dup - 34.4-0ubuntu1

---------------
deja-dup (34.4-0ubuntu1) zesty; urgency=medium

  * New bug-fix upstream release:
    - In MATE, call the file manager Caja, not Files (LP: #1657092)
    - Fix documentation and strictness of using xdg location variables
      in gsettings include/exclude keys
    - Don't show control center panel in Unity8

 -- Michael Terry <email address hidden> Thu, 09 Mar 2017 14:30:50 -0500

This had been released as a part of Déjà Dup 34.4.