Selection tool: transformation handles vanishing

Reported symptom was (occasionally) observed while attempting to reproduce bug #1635982 (comment 15), in a new default document with just a single rectangle (fill, no stroke), at the time with lp:inkscape/0.92.x r15315 IIRC (OS X 10.7.5, GTK+/X11). The steps to reproduce (for bug #1635982) required repeated selection and de-selection of the same object.

--
Replaces hidden comment 3 to fix typo in revision number.

Most of the time the reported symptom seems to reproduce briefly, as a single occurrence (i.e. the handles are restored with the next click) - this part reproduces easily with 0.91 too, but not with 0.48.5.

The sticky part (requiring a tool switch to restore the transformation handles of the select tool) seems to occur much rarer (and I haven't been able to reproduce it with 0.91 yet).

Yes, I noticed those briefly missing handles, too (but only when clicking wildly, so I wasn't entirely sure if I maybe just missed them...).

Probably has the same trigger as for (later) bug #1657874 - a (single) click on the rotation center is sufficient to make the transformation handles disappear. This can happen accidentally when «selecting different and same objects repeatedly with selection tool».

@Hachmann - any chance you could test the patch from bug #1657874 with your local 0.92.x build? Given the details vlada added there (indeed, any of the transformation handles also triggers the issue when clicked on, not just the rotation center), it would be great if this fix would make it into the stable release branch (likely for 0.92.2).

I also think that the two reports are basically about the same issue - would you mind linking yours as duplicate to bug #1657874 which has more details about the trigger, as well as the patch?

Wanted to re-build anyway, because of the missing potrace during the last build.

Let's see if I can do a manual patch (what is 'three hunks'?... I'll try by copy-pasting the added / replacement lines into their appropriate places later tonight.)...

<off-topic>
Hachmann wrote:
> Let's see if I can do a manual patch ...

You don't have to do that manually - jabiertxof simply mentioned that the trunk patch applies to 0.92.x as well (just with a few warnings that the changes are applied offset from the location as noted in the diff file).

Download the patch file, then first try a dry-run:

$ patch -p0 --dry-run < path-to-download/fix-bug-1657874.patch
checking file src/gradient-drag.cpp
checking file src/gradient-drag.h
checking file src/knot.cpp
Hunk #1 succeeded at 229 (offset 15 lines).
Hunk #2 succeeded at 256 (offset 15 lines).
Hunk #3 succeeded at 294 (offset 18 lines).
checking file src/knot.h
$

These messages are all ok (all changes succeeded, nothing failed to apply).

Now apply the patch, and then recompile.
$ patch -p0 < path-to-download/fix-bug-1657874.patch

You can later remove the changes of the patch (e.g. to prevent a potential conflict when updating the local branch after a final version of the fix was committed):
$ patch -p0 --dry-run -R < path-to-download/fix-bug-1657874.patch
$ patch -p0 -R < path-to-download/fix-bug-1657874.patch

</off-topic>

<off-topic>

Thank you, su_v, this saves some time searching for those patch commands (and even with safety net, that's something to copy and keep somewhere)! (Jabier explained to me what a hunk is)

</off-topic>