Formatting tags gets included in searchable lyric text
Bug #1655988 reported by
Tomas Groth
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Committed
|
High
|
Tomas Groth | ||
| 2.4 |
Fix Released
|
High
|
Tomas Groth | ||
Bug Description
OpenLPs song DB has a special search_lyrics field that should contain text special for searching. Unfortunately formatting tags (and chords) are currently included in the searchable text.
Confirmed in 2.4.4 and trunk.
Example of original text:
{y}Am[G]azing Gr[G7]ace, how [C]sweet the so[G]und,{/y}
Text in search_lyrics:
y am g azing gr g7 ace how c sweet the so g und y
Related branches
lp:~tomasgroth/openlp/song-import-fixes25
- Tim Bentley: Approve
-
Diff: 311 lines (+130/-29)9 files modifiedopenlp/plugins/songs/lib/__init__.py (+2/-2)
openlp/plugins/songs/lib/importers/easyslides.py (+12/-12)
openlp/plugins/songs/lib/importers/songbeamer.py (+9/-6)
openlp/plugins/songs/lib/importers/videopsalm.py (+4/-2)
tests/functional/openlp_plugins/songs/test_easyslidesimport.py (+2/-0)
tests/resources/easyslidessongs/Amazing Grace.json (+6/-6)
tests/resources/easyslidessongs/Export_2017-01-12_BB.json (+44/-0)
tests/resources/easyslidessongs/Export_2017-01-12_BB.xml (+50/-0)
tests/resources/videopsalmsongs/videopsalm-as-safe-a-stronghold.json (+1/-1)
lp:~tomasgroth/openlp/song-import-fixes24
- Tim Bentley: Approve
-
Diff: 407 lines (+174/-29)12 files modifiedopenlp/core/__init__.py (+38/-2)
openlp/core/lib/treewidgetwithdnd.py (+6/-1)
openlp/core/ui/slidecontroller.py (+2/-0)
openlp/plugins/songs/lib/__init__.py (+2/-2)
openlp/plugins/songs/lib/importers/easyslides.py (+12/-12)
openlp/plugins/songs/lib/importers/songbeamer.py (+7/-3)
openlp/plugins/songs/lib/importers/videopsalm.py (+4/-2)
tests/functional/openlp_plugins/songs/test_easyslidesimport.py (+2/-0)
tests/resources/easyslidessongs/Amazing Grace.json (+6/-6)
tests/resources/easyslidessongs/Export_2017-01-12_BB.json (+44/-0)
tests/resources/easyslidessongs/Export_2017-01-12_BB.xml (+50/-0)
tests/resources/videopsalmsongs/videopsalm-as-safe-a-stronghold.json (+1/-1)
| description: | updated |
| Changed in openlp: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Tomas Groth (tomasgroth) |
| Changed in openlp: | |
| milestone: | none → 2.5.1 |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
