Fuel for OpenStack

[fuel-plugins] Missed 'major_version' rendering key

Bug #1655289 reported by Dmitry Belyaninov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Georgy Kibardin
Fuel for OpenStack 11.0
Mitaka
Fix Released
High
Georgy Kibardin
Fuel for OpenStack 9.2
Newton
Fix Released
High
Georgy Kibardin
Fuel for OpenStack 10.1
Ocata
Fix Committed
High
Georgy Kibardin
Fuel for OpenStack 11.0

Bug Description

After the [0] commit was merged, 'fpb --create *' command fails.
There is error message in the swarm test [1]

So additional rendering context key should be added to [2].
        self.render_ctx = {'plugin_name': self.plugin_name,
                           'major_version': ***some_value***}

[0] https://github.com/openstack/fuel-plugins/commit/57476f32d3cc436dcd32d2ec0215aca371870cb0

[1] https://product-ci.infra.mirantis.net/job/9.x.system_test.ubuntu.fuel_plugin_reboot/167/testReport/(root)/deploy_cluster_with_reboot_plugin_timeout/deploy_cluster_with_reboot_plugin_timeout/

[2] https://github.com/openstack/fuel-plugins/blob/master/fuel_plugin_builder/actions/create.py#L41

Georgy Kibardin (gkibardin)
Changed in fuel:
status: Confirmed → In Progress
Nastya Urlapova (aurlapova)
tags: added: swarm-blocker
removed: swarm-fail
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-plugins (master)

Fix proposed to branch: master
Review: https://review.openstack.org/418327

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-plugins (master)

Reviewed: https://review.openstack.org/418327
Committed: https://git.openstack.org/cgit/openstack/fuel-plugins/commit/?id=6a1ae7f5204dadcdc5326c668c09ca5840bd5c7e
Submitter: Jenkins
Branch: master

commit 6a1ae7f5204dadcdc5326c668c09ca5840bd5c7e
Author: Georgy Kibardin <email address hidden>
Date: Tue Jan 10 13:50:47 2017 +0300

    Move Release.mako into v1 template dir

    It turned out that templates/base is used to create new plugin
    directory structure by fpb --create and, therefore, is a bad place to
    put Release.mako since it is attempted to render it at plugin creation
    time, not at a build time as inteded.

    Change-Id: I7dbbf192827f8b2a0c0675050f7b48820952f6af
    Closes-Bug: #1655289

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Ekaterina Shutova (eshutova) wrote :

Test is passed on 9.2 snapshot #748. Passed run: https://product-ci.infra.mirantis.net/job/9.x.system_test.ubuntu.fuel_plugin_reboot/169/testReport/

tags: added: on-verification
tags: removed: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-plugins (master)

Fix proposed to branch: master
Review: https://review.openstack.org/419880

Revision history for this message
Dmitry Belyaninov (dbelyaninov) wrote :

Verified on Newton.
Passed run:
https://product-ci.infra.mirantis.net/view/10.0_swarm/job/10.0.system_test.ubuntu.fuel_plugin_reboot/233/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-plugins (master)

Reviewed: https://review.openstack.org/419880
Committed: https://git.openstack.org/cgit/openstack/fuel-plugins/commit/?id=fae06cf5aa86e2d0a1cbc18bee41bfa830b1962f
Submitter: Jenkins
Branch: master

commit fae06cf5aa86e2d0a1cbc18bee41bfa830b1962f
Author: Georgy Kibardin <email address hidden>
Date: Fri Jan 13 13:27:27 2017 +0300

    Separate create and build templates

    In order to prevent build templates to render during plugin
    creation we need to put them into different directories.

    Change-Id: I439bc7618a43ad07cc73fb69b60d99d725c3f9d0
    Closes-Bug: #1655289

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.