Bazaar PQM Plugin

working tree clean check comes after branch check

Bug #165313 reported by Robert Collins
2
Affects Status Importance Assigned to Milestone
Bazaar PQM Plugin
Fix Released
Undecided
Unassigned

Bug Description

It's cheaper to detect uncommitted changes in the local tree than it is
to check if the branch is up to date, so the branch check should be done
second.

 affects bzr-pqm

--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Revision history for this message
John A Meinel (jameinel) wrote :

That depends if the branch is local or remote. If it is local (co-located with the WT) it seems like it would be a lot cheaper to check for up-to-date.

Revision history for this message
James Henstridge (jamesh) wrote :

The public location of the branch is generally going to be a, http, bzr or bzr+ssh URL: all of which will involve some form of IPC (often remote), so we still try to access it using an external protocol even if the working tree is nominally the public location.

In contrast, the uncomitted changes check is always going to be local and will likely be quite fast if it is in cache. It won't be any slower than "bzr status". So I think it is worth doing the changes in the other order.

Revision history for this message
James Henstridge (jamesh) wrote :

Fixed in r48.

Changed in bzr-pqm:
status: New → Fix Committed
Revision history for this message
James Henstridge (jamesh) wrote :

Fix released in bzr-pqm-1.3.0

Changed in bzr-pqm:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.