dell recovery tests being executed unexpectedly

Bug #1651503 reported by Jeff Lane 
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox Provider - Base
Fix Released
Medium
Sylvain Pineau

Bug Description

There are some recovery partition tests that have been recently added that are being executed automatically by checkbox regardless of the suite being chosen.

Specifically, the following jobs are now appearing in all runs of canonical-certification-server:
info/detect_dell_recovery
info/detect_recovery
dell_bto_xml_attachment_json
recovery_info_attachment_json

These last two are included as depends for miscellanea/submission_resources
They are defined in submission.txt

dell_bto_xml_attachment_json lists info/detect_dell_recovery as a depends
recovery_info_attachment_json lists info/detect_recovery as a depends.

Both info/detect_dell_recovery and info/detect_recovery are defined in info.txt. Both appear to be standard shell jobs.

However, these are all being run as part of the server test suite and they shouldn't be.

To recreate this, I can do the following:
1: Set up 16.04.x VM
2: add-apt-repository -u ppa:hardware-certification/public
3: apt install -y canonical-certification-server
4: run canonical-certification-server
5: pick a whitelist, any whitelist
6: on the Test Selection Screen, expand the Informational Tests category and see that these tests are listed as tests to be executed. These tests are NOT included in my whitelists

For example, in my recreation, I chose the USB Only whitelist. That list does NOT call these recovery detection jobs, but they still appear in the Test Selection screen as shown in the attached screenshot.

It's not a big deal, as they are not executed because the dell-recovery and ubuntu-recovery packages are not installed, but they should not be appearing in my test runs at all to begin with.

root@ubuntu-2gb-nyc3-01:~# dpkg -l |grep plainbox-provider|awk '{print $2" " $3}'
plainbox-provider-certification-server 0.30.0~ppa~ubuntu16.04.1
plainbox-provider-checkbox 0.33.0~ppa~ubuntu16.04.1
plainbox-provider-resource-generic 0.30.0~ppa~ubuntu16.04.1

Revision history for this message
Jeff Lane  (bladernr) wrote :
description: updated
description: updated
Changed in plainbox-provider-checkbox:
status: New → In Progress
assignee: nobody → Maciej Kisielewski (kissiel)
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Job `miscellanea/submission-resources` is listed in `mandatory_include` so it's always run, and pulls in all its dependencies.

Those two unwanted jobs got added by spineau here: https://git.launchpad.net/plainbox-provider-checkbox/commit/?id=339a6b82c979622c4e523454f8944f67cbedb464

I don't know the reasoning behind it, so I'm assigning this to Sylvain.

Changed in plainbox-provider-checkbox:
assignee: Maciej Kisielewski (kissiel) → Sylvain Pineau (sylvain-pineau)
status: In Progress → Confirmed
Revision history for this message
Jerry Kao (jerry.kao) wrote :

This issue also can be seen in Euclid test with desktop client cert whitelist.

tags: added: ce-qa-concern
Jeff Lane  (bladernr)
Changed in plainbox-provider-checkbox:
importance: Undecided → Medium
milestone: none → 0.36.0
Changed in plainbox-provider-checkbox:
milestone: 0.36.0 → none
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

I added those 2 jobs (dell_bto_xml_attachment_json and recovery_info_attachment_json) as the new submission service will populate C3 related info from the json exporter (and not the xml).

they should be safe to remove. But if a testplan requires those info to be part of the final submission, remember that old bto/recovery attachments jobs won't create the same info on C3 once the submission service will go to production.

Changed in plainbox-provider-checkbox:
status: Confirmed → Triaged
Revision history for this message
Jeff Lane  (bladernr) wrote :

So, just to point out also, the submission-resources job won't even run if those don't run...

job cannot be started: required dependency '2013.com.canonical.certification::dell_bto_xml_attachment_json' has failed, required dependency '2013.com.canonical.certification::recovery_info_attachment_json' has failed

Changed in plainbox-provider-checkbox:
milestone: none → 0.40.0
status: Triaged → In Progress
Changed in plainbox-provider-checkbox:
status: In Progress → Fix Committed
Changed in plainbox-provider-checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.