ISST-LTE:UbuntuKVM:virt-manager can generate invalid guest XML for virtio-scsi controllers

------- Comment From <email address hidden> 2016-12-13 04:03 EDT-------
Please cherry pick this commit

https://github.com/virt-manager/virt-manager/commit/5a11cf0782998a36eef42718231bcb4c2de8ebba

virt-manage is a community supported package, please cherry pick the patch mentioned in this bug.

------- Comment From <email address hidden> 2017-07-06 13:42 EDT-------
Has this patch been cherry-picked into Ubuntu already?

------- Comment From <email address hidden> 2017-08-04 22:31 EDT-------
This has been awaiting to be cherry picked for 6 months now. Any updates?

Hi lagarcia,
I didn't watch virt-manager bugs before so this only got to my attention now.
The fix is released with virt-manager v1.4.1 which isn't in Debian yet and Ubuntu is waiting for a merge anyway.
So no - for now it seems nothing has happened yet.

Since the merge might have way more complexity cherry picking this should be the faster solution.
I'm just back today and can't do this immediately - but I'll put it more clearly on our Teams list.

This bug was fixed in the package virt-manager - 1:1.4.0-5ubuntu1

---------------
virt-manager (1:1.4.0-5ubuntu1) artful; urgency=medium

  * Merge with Debian unstable (LP: #1667114 LP: #1683747). Remaining changes:
    - Depend on gir1.2-appindicator3-0.1 for appindicator support.
    - Add lsb-release to Build-Depends so we can detect whether we're running
      on Ubuntu or Debian.
    - d/rules: Set the preferred distro so we appear first in the list.
    - d/rules: Set qemu user to libvirt-qemu so appropriate permissions get set.
    - d/p/virtinst/9006_fix_path_to_qemu-dm.patch: drop the full path from
      qemu-dm as already done for hvmloader and pygrub. The Xen tools will
      handle this and add the missing path.
    - d/p/mark-libvirt-lxc: Clearly mark the LXC connections as being
      libvirt-lxc, to avoid confusion due to differing features and
      configurations.
    - d/p/add_qemu_binaries.patch: add the actual binary name from the qemu
      packages so default hypervisor detection works properly on first run.
    - d/p/use_qxl_for_ubuntu.patch: use qxl by default for Ubuntu VMs, it
      seems to work better than vmvga now.
    - d/p/prefer-qemu.patch: Prefer QEMU as the default URI, even if it's
      not installed.
    - Fix virt-install so that it can install 16.04 and newer images.
      Error message is 'Couldn't find hvm kernel for Ubuntu tree
      Closes (LP 1634304)
  * Dropped changes:
    - d/rules: Remove data/gschemas.compiled generated by clean (in Debian).
    - d/p/0001-details-Fix-screenshot-on-F24-rawhide-bz-1297988.patch:
      Cherry-pick from upstream. Fix screenshot capture with newer
      gdk-pixbuf/pygobject. (LP 1571702) (now Upstream)
    - d/p/use_virtio_for_pseries_disks.patch: virtinst: Use virtio bus type for
      disks on pSeries machines. Closes LP 1597610. (now Upstream)
    - Change Recommends to libvirt-bin instead of libvirt-daemon-system
      which isn't available in Ubuntu (Debian and Ubuntu share names again).
    - With package names now matching delta would be wrong, calling kvm
      leads to the right suggestive apt install message. Remaining messages
      are considered good enough (or should be fixed upstream)
      - d/p/more_helpful_error_message.patch: explain to the user why
        connecting to qemu:///system failed and how to fix it.
      - d/p/use_ubuntu_package_names.patch: Suggest installing the packages
        that are actually available in Ubuntu.
    - d/p/virtinst/dont_disable_vmport.patch: Don't disable vmport even if
      we're using spice, as this prevents having a seamless mouse when
      using Ubuntu as a guest (Seamless mouse was reported ok without).
    - d/p/leave-mnemonics-alone-on-focus-change.patch: Leave
      gtk-enable-mnemonics setting alone under Unity when windows change
      focus (No Unity supporte anymore).
  * Added changes:
    - Refreshed patches to match new version:
      - d/p/mark-libvirt-lxc.patch
      - d/p/virtinst/use_qxl_for_ubuntu.patch
    - d/p/virt-manager-generates-invalid-guest-XML.patch: fix generation of
      invalid xml when a spapr-vio SCSI model controller is changed to a
      virtio-scsi model controller...