Use of consistent styling in magnum configure snippets

Bug #1648099 reported by Dirk Mueller
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
Dirk Mueller

Bug Description

Similarly to the use of pep8 for python code, bashate style checker allows enforcing of basic guidelines, similar to pep8 and flake8 tools for Python.

bashate can enforce some rules like for example:

Whitespace Rules

* lines should not include trailing whitespace
* there should be no hard tabs in the file
* indents are 4 spaces, and all indentation should be some multiple of them
* then should be on the same line as the if
* do should be on the same line as the for

These can be individually enabled or disabled. I propose to start easy and enforce a consistent indenting (4 spaces no tabs) only for now.

Changed in magnum:
assignee: nobody → Dirk Mueller (dmllr)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/390668
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=80fc5a2d42138c884894da212e923f96e6533ef0
Submitter: Jenkins
Branch: master

commit 80fc5a2d42138c884894da212e923f96e6533ef0
Author: Dirk Mueller <email address hidden>
Date: Tue Oct 25 22:46:14 2016 +0200

    Add bashate checks to pep8 step

    Similarly to pep8 checks, this allows enforcing a consistent
    style of the shell scripts accross modfications. For now
    only the indentation is enforced to reduce code churn.

    Closes-Bug: 1648099
    Change-Id: Ie66cbe1aea4bd01a8bba8833ef6cbd2cff6a7c6a

Changed in magnum:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 4.0.0

This issue was fixed in the openstack/magnum 4.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.