Use of consistent styling in magnum configure snippets
Bug #1648099 reported by
Dirk Mueller
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Magnum |
Fix Released
|
Undecided
|
Dirk Mueller |
Bug Description
Similarly to the use of pep8 for python code, bashate style checker allows enforcing of basic guidelines, similar to pep8 and flake8 tools for Python.
bashate can enforce some rules like for example:
Whitespace Rules
* lines should not include trailing whitespace
* there should be no hard tabs in the file
* indents are 4 spaces, and all indentation should be some multiple of them
* then should be on the same line as the if
* do should be on the same line as the for
These can be individually enabled or disabled. I propose to start easy and enforce a consistent indenting (4 spaces no tabs) only for now.
Changed in magnum: | |
assignee: | nobody → Dirk Mueller (dmllr) |
status: | New → In Progress |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/390668 /git.openstack. org/cgit/ openstack/ magnum/ commit/ ?id=80fc5a2d421 38c884894da212e 923f96e6533ef0
Committed: https:/
Submitter: Jenkins
Branch: master
commit 80fc5a2d42138c8 84894da212e923f 96e6533ef0
Author: Dirk Mueller <email address hidden>
Date: Tue Oct 25 22:46:14 2016 +0200
Add bashate checks to pep8 step
Similarly to pep8 checks, this allows enforcing a consistent
style of the shell scripts accross modfications. For now
only the indentation is enforced to reduce code churn.
Closes-Bug: 1648099 1a8bba8833ef6cb d2cff6a7c6a
Change-Id: Ie66cbe1aea4bd0