docker should not de-configure pre-existing bridge interfaces

Bug #1647376 reported by Stefan Bader
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
docker.io (Ubuntu)
Fix Released
High
Michael Hudson-Doyle
Declined for Zesty by Michael Hudson-Doyle
Xenial
Fix Released
Undecided
Unassigned
Yakkety
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
Since moving to docker 1.12, management of networks to be used by docker images is done via "docker network (create/rm)". Currently docker assumes (for the bridge driver at least) that it has to do full setup/cleanup of the associated bridge interface. This is fatal for those cases where an existing bridge interface is used to declare the network to docker.

This is fixed in docker 1.13 by the attached patch (this is a backport from docker upstream, it applies to yakkety and xenial but has to drop one more hunk in zesty).

[Test Case]
See https://wiki.ubuntu.com/DockerUpdates

[Regression potential]
See above.

Revision history for this message
Stefan Bader (smb) wrote :
tags: added: patch
Revision history for this message
Stefan Bader (smb) wrote :

This would be the proposed update for Zesty (the version this is based on is currently in proposed).

Revision history for this message
Stefan Bader (smb) wrote :
Revision history for this message
Stefan Bader (smb) wrote :
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I've included the patch in the version of docker.io that I've just uploaded to zesty. Once that has hit release I'll also upload it to the Xenial and Yakkety queues for SRU processing.

Changed in docker.io (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Michael Hudson-Doyle (mwhudson)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package docker.io - 1.12.3-0ubuntu4

---------------
docker.io (1.12.3-0ubuntu4) zesty; urgency=medium

  * Explicity depend on the version of runc that was built with seccomp
    support.

 -- Michael Hudson-Doyle <email address hidden> Mon, 12 Dec 2016 11:15:01 +1300

Changed in docker.io (Ubuntu):
status: In Progress → Fix Released
Changed in docker.io (Ubuntu Xenial):
status: New → In Progress
Changed in docker.io (Ubuntu Yakkety):
status: New → In Progress
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Stefan, or anyone else affected,

Accepted docker.io into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/docker.io/1.12.3-0ubuntu4~16.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in docker.io (Ubuntu Yakkety):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Stefan Bader (smb) wrote :

Leann did some testing but mentioned that the version of docker.io in yakkety now has dependency issues with runc (unmet dependencies on runc > 1.0.0~rc1-0ubuntu2 (which is what is in zesty), but yakkety-proposed has 1.0.0~rc1-0ubuntu2~16.10.1).

tags: added: verification-failed
removed: verification-needed
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote : Re: [Bug 1647376] Re: docker should not de-configure pre-existing bridge interfaces

Yeah, I noticed that too and uploaded a fix, it's still sat in the
unapproved queue though.

On 22 December 2016 at 01:23, Stefan Bader <email address hidden>
wrote:

> Leann did some testing but mentioned that the version of docker.io in
> yakkety now has dependency issues with runc (unmet dependencies on runc
> > 1.0.0~rc1-0ubuntu2 (which is what is in zesty), but yakkety-proposed
> has 1.0.0~rc1-0ubuntu2~16.10.1).
>
> ** Tags removed: verification-needed
> ** Tags added: verification-failed
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1647376
>
> Title:
> docker should not de-configure pre-existing bridge interfaces
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/docker.io/+bug/
> 1647376/+subscriptions
>

Revision history for this message
Andy Whitcroft (apw) wrote : Please test proposed package

Hello Stefan, or anyone else affected,

Accepted docker.io into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/docker.io/1.12.3-0ubuntu4~16.10.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: removed: verification-failed
tags: added: verification-needed
Revision history for this message
Stefan Bader (smb) wrote :

#> dpkg -l|grep docker.io
ii docker.io 1.12.3-0ubuntu4~16.10.2

[fan-250 already configured but not enabled for docker, yet]

#> fanatic enable-docker -u <underlay> -o <overlay>
configuring docker for ...
[ok]

#> docker network ls
...
f666283aed62 fan-250 bridge local
...
[ok]

#> fanatic test-local-docker -u <underlay> -o <overlay>
[passes all tests]

#> fanatic disable-docker -u <underlay> -o <overlay>
de-configuring docker ...
[ok]

#> ifconfig fan-250
[still up and with address assigned -> ok]

tags: added: verification-done
removed: verification-needed
Revision history for this message
Andy Whitcroft (apw) wrote :

Hello Stefan, or anyone else affected,

Accepted docker.io into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/docker.io/1.12.3-0ubuntu4~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in docker.io (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: removed: verification-done
tags: added: verification-needed
Revision history for this message
Stefan Bader (smb) wrote :

@Michael, looking at the britney log I get a felling that the xenial backport suffers from a similar runc dependency related issue as the yakkety one did...

Depends: runc (>= 1.0.0~rc1-0ubuntu2) which probably should be (>= 1.0.0~rc1-0ubuntu2~) together with an upload of runc.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Stefan,

Argh! I was sure I'd uploaded a new version but obviously I was confused. I've uploaded a new version now, hopefully the SRU team will forgive me soon :)

Revision history for this message
Stefan Bader (smb) wrote :

Repeated testing from comment #11 for Xenial (docker.io version 1.12.3-0ubuntu4~16.04.2). Again, with the new version the pre-existing bridge is still up after deleting it from docker.

tags: added: verification-done
removed: verification-needed
tags: added: verification-done-xenial verification-done-yakkety
removed: verification-done
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package docker.io - 1.12.3-0ubuntu4~16.10.2

---------------
docker.io (1.12.3-0ubuntu4~16.10.2) yakkety; urgency=medium

  * Update runc dep to account for its backported version.

docker.io (1.12.3-0ubuntu4~16.10.1) yakkety; urgency=medium

  * Backport to Yakkety. (LP: #1647376, #1639407)

 -- Michael Hudson-Doyle <email address hidden> Mon, 19 Dec 2016 09:20:48 +1300

Changed in docker.io (Ubuntu Yakkety):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for docker.io has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package docker.io - 1.12.3-0ubuntu4~16.04.2

---------------
docker.io (1.12.3-0ubuntu4~16.04.2) xenial; urgency=medium

  * Update runc dep to account for its backported version.

 -- Michael Hudson-Doyle <email address hidden> Mon, 19 Dec 2016 09:20:48 +1300

Changed in docker.io (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.