Squirrelmail - missing Subject/Body on some messages in 16.04

Bug #1636333 reported by Scott Talbert
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
squirrelmail (Ubuntu)
Fix Released
Undecided
Nish Aravamudan
Xenial
Fix Released
Undecided
Unassigned
Yakkety
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

 * In Ubuntu 16.04, Squirrelmail has a regression from 14.04. Certain messages are missing the subject or message body. Investigation reveals that this is due to the removal of the /e modifier in preg_replace in PHP 7. The server logs show numerous error messages similar to the following:

[Mon Oct 24 19:40:36.248894 2016] [:error] [pid 4699] [client AAA.BBB.CCC.DDD:12345] PHP Warning: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead in /usr/share/squirrelmail/functions/decode/utf_8.php on line 87, referer: xyz

 * Upstream has resolved this issue:
https://sourceforge.net/p/squirrelmail/code/14359/

 * After applying the patch in 14359 (plus the trivial 14347 which is necessary to make 14359 apply cleanly), the problems go away.

[Test Case]

 * Install and configure squirrelmail. Determine if all emails have subject and message body.

   (@Scott, do you have a better test case?)

[Regression Potential]

 * Squirrelmail as currently packaged is broken in 16.04, 16.10 and 17.04, due to syntax changes in PHP7.0. The risk for regression is consequentially very low, as the fix involves backporting upstream fixes that make the code-base PHP7.0-compliant.

---

PPA with the patches applied: https://launchpad.net/~swt-techie/+archive/ubuntu/squirrelmail

Nish Aravamudan (nacc)
Changed in squirrelmail (Ubuntu):
status: New → In Progress
assignee: nobody → Nish Aravamudan (nacc)
Nish Aravamudan (nacc)
description: updated
Revision history for this message
Scott Talbert (swt-techie) wrote :

The other test case than can be used is to check the apache error_log and verify it is not being filled with the "PHP Warning: preg_replace()" errors.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in squirrelmail (Ubuntu Xenial):
status: New → Confirmed
Changed in squirrelmail (Ubuntu Yakkety):
status: New → Confirmed
Revision history for this message
Nish Aravamudan (nacc) wrote :

@Scott, just FYI, I've uploaded the fix to zesty, yakkety and xenial today. It will need to get into Z (which should just happen automatically once the package is done building) before the SRU team considers it for Y and X.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package squirrelmail - 2:1.4.23~svn20120406-2ubuntu2

---------------
squirrelmail (2:1.4.23~svn20120406-2ubuntu2) zesty; urgency=medium

  * debian/patches/php7_remove_e_modifier_preg_replace: Remove use of
    deprecated /e modifier in preg_replace. Thanks to Thijs Kinkhorst
    <email address hidden>. Closes LP: #1636333.

 -- Nishanth Aravamudan <email address hidden> Mon, 28 Nov 2016 16:23:55 -0800

Changed in squirrelmail (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Scott, or anyone else affected,

Accepted squirrelmail into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/squirrelmail/2:1.4.23~svn20120406-2ubuntu1.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in squirrelmail (Ubuntu Xenial):
status: Confirmed → Fix Committed
tags: added: verification-needed
Changed in squirrelmail (Ubuntu Yakkety):
status: Confirmed → Fix Committed
Revision history for this message
Chris J Arges (arges) wrote :

Hello Scott, or anyone else affected,

Accepted squirrelmail into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/squirrelmail/2:1.4.23~svn20120406-2ubuntu1.16.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Scott Talbert (swt-techie) wrote :

Updated package verified on Xenial.

tags: added: verification-done-xenial
Nish Aravamudan (nacc)
tags: added: verification-done-yakkety
tags: removed: verification-needed
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for squirrelmail has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package squirrelmail - 2:1.4.23~svn20120406-2ubuntu1.16.10.1

---------------
squirrelmail (2:1.4.23~svn20120406-2ubuntu1.16.10.1) yakkety; urgency=medium

  * debian/patches/php7_remove_e_modifier_preg_replace: Remove use of
    deprecated /e modifier in preg_replace. Thanks to Thijs Kinkhorst
    <email address hidden>. Closes LP: #1636333.

 -- Nishanth Aravamudan <email address hidden> Mon, 28 Nov 2016 16:27:50 -0800

Changed in squirrelmail (Ubuntu Yakkety):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package squirrelmail - 2:1.4.23~svn20120406-2ubuntu1.16.04.1

---------------
squirrelmail (2:1.4.23~svn20120406-2ubuntu1.16.04.1) xenial; urgency=medium

  * debian/patches/php7_remove_e_modifier_preg_replace: Remove use of
    deprecated /e modifier in preg_replace. Thanks to Thijs Kinkhorst
    <email address hidden>. Closes LP: #1636333.

 -- Nishanth Aravamudan <email address hidden> Mon, 28 Nov 2016 16:31:02 -0800

Changed in squirrelmail (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.