zaqar

Don't send confirm notification if the feature is not enabled

Bug #1633222 reported by Feilong Wang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
Medium
Feilong Wang
zaqar ocata-1

Bug Description

Currently, even though 'require_confirmation' is set as 'False', Zaqar will still send a require-confirm message/notification to subscribers. It will bring some troubles for existing users after migrated to Newton. The expected behaviour is don't send any confirm notification, just like before.

Feilong Wang (flwang)
Changed in zaqar:
importance: Undecided → Medium
assignee: nobody → Fei Long Wang (flwang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to zaqar (master)

Fix proposed to branch: master
Review: https://review.openstack.org/393010

Changed in zaqar:
status: New → In Progress
Thomas Herve (therve)
Changed in zaqar:
milestone: none → ocata-2
milestone: ocata-2 → ocata-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zaqar (master)

Reviewed: https://review.openstack.org/393010
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=c19d0a0153a0e63d6806616092ed234431d4599d
Submitter: Jenkins
Branch: master

commit c19d0a0153a0e63d6806616092ed234431d4599d
Author: Fei Long Wang <email address hidden>
Date: Wed Nov 2 14:59:59 2016 +1300

    Don't send confirmation notification if it's not enabled

    Currently even though the 'require_confirmation' option is False,
    Zaqar will send the confirmation notification anyway, which is
    breaking the backward compatibility. This patch will fix it and
    add a test for that.

    Closes-Bug: #1633222

    Change-Id: I2d6363feab90ff737684d5c1d903c2c2d7abe106

Changed in zaqar:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to zaqar (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/395236

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zaqar (stable/newton)

Reviewed: https://review.openstack.org/395236
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=9d4497dbd9278739611d143d17224cc2355cfab9
Submitter: Jenkins
Branch: stable/newton

commit 9d4497dbd9278739611d143d17224cc2355cfab9
Author: Fei Long Wang <email address hidden>
Date: Wed Nov 2 14:59:59 2016 +1300

    Don't send confirmation notification if it's not enabled

    Currently even though the 'require_confirmation' option is False,
    Zaqar will send the confirmation notification anyway, which is
    breaking the backward compatibility. This patch will fix it and
    add a test for that.

    Closes-Bug: #1633222

    Change-Id: I2d6363feab90ff737684d5c1d903c2c2d7abe106
    (cherry picked from commit c19d0a0153a0e63d6806616092ed234431d4599d)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/zaqar 4.0.0.0b1

This issue was fixed in the openstack/zaqar 4.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.