[2.1, FUJ] Section complete/incomplete icon
Bug #1628054 reported by
Maria Vrachni
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Low
|
Unassigned |
Bug Description
MAAS bzr5400
[FUJ] Section complete/incomplete icon
Bug description:
* Current result:
Given in the first use journey in any of the sections
When the section is incomplete or there is an error with one of the fields of the section
Then there is a red icon on the top left of the section
* Expected/ correct result:
Given that I am in any of the sections of the first use journey
When the section is incomplete or there is an error with one of the fields of the section
Then there should be a grey (tick) icon
OS X Sierra
Chrome, 53.0.2785.116 (64-bit)
Related branches
lp:~ricgard/maas/device-discovery-backport-2.1
- Gavin Panella (community): Approve
-
Diff: 6972 lines (+1211/-4869)94 files modifieddocs/changelog.rst (+12/-0)
src/maasserver/static/assets/images/icons/account.svg (+1/-163)
src/maasserver/static/assets/images/icons/add-logical-volume.svg (+1/-91)
src/maasserver/static/assets/images/icons/add-partition.svg (+1/-117)
src/maasserver/static/assets/images/icons/add.svg (+1/-24)
src/maasserver/static/assets/images/icons/cross-orange.svg (+1/-10)
src/maasserver/static/assets/images/icons/cross.svg (+1/-18)
src/maasserver/static/assets/images/icons/cross_orange.svg (+1/-10)
src/maasserver/static/assets/images/icons/debug.svg (+1/-18)
src/maasserver/static/assets/images/icons/delete.svg (+1/-178)
src/maasserver/static/assets/images/icons/edit.svg (+1/-168)
src/maasserver/static/assets/images/icons/error-mono.svg (+0/-96)
src/maasserver/static/assets/images/icons/error.svg (+1/-117)
src/maasserver/static/assets/images/icons/error_colour_black.svg (+0/-117)
src/maasserver/static/assets/images/icons/error_colour_white.svg (+0/-117)
src/maasserver/static/assets/images/icons/error_mono.svg (+0/-96)
src/maasserver/static/assets/images/icons/green-tick.svg (+1/-20)
src/maasserver/static/assets/images/icons/help-mono.svg (+0/-96)
src/maasserver/static/assets/images/icons/help.svg (+1/-104)
src/maasserver/static/assets/images/icons/help_colour_black.svg (+0/-104)
src/maasserver/static/assets/images/icons/help_colour_white.svg (+0/-104)
src/maasserver/static/assets/images/icons/help_mono.svg (+0/-96)
src/maasserver/static/assets/images/icons/info-mono.svg (+1/-96)
src/maasserver/static/assets/images/icons/info.svg (+1/-113)
src/maasserver/static/assets/images/icons/information_colour_white.svg (+0/-113)
src/maasserver/static/assets/images/icons/information_mono.svg (+0/-96)
src/maasserver/static/assets/images/icons/logical-volume.svg (+1/-91)
src/maasserver/static/assets/images/icons/magnifying_glass.svg (+1/-10)
src/maasserver/static/assets/images/icons/mount.svg (+1/-81)
src/maasserver/static/assets/images/icons/partition.svg (+1/-117)
src/maasserver/static/assets/images/icons/power-error.svg (+1/-12)
src/maasserver/static/assets/images/icons/power-off.svg (+1/-12)
src/maasserver/static/assets/images/icons/power-on.svg (+1/-12)
src/maasserver/static/assets/images/icons/remove.svg (+1/-12)
src/maasserver/static/assets/images/icons/settings.svg (+1/-174)
src/maasserver/static/assets/images/icons/success-mono.svg (+1/-95)
src/maasserver/static/assets/images/icons/success.svg (+1/-103)
src/maasserver/static/assets/images/icons/success_colour_black.svg (+1/-103)
src/maasserver/static/assets/images/icons/success_colour_white.svg (+1/-103)
src/maasserver/static/assets/images/icons/success_mono.svg (+1/-95)
src/maasserver/static/assets/images/icons/sync.svg (+1/-165)
src/maasserver/static/assets/images/icons/system-shutdown.svg (+1/-148)
src/maasserver/static/assets/images/icons/tags.svg (+1/-117)
src/maasserver/static/assets/images/icons/tick.svg (+1/-20)
src/maasserver/static/assets/images/icons/tooltip.svg (+1/-125)
src/maasserver/static/assets/images/icons/unmount.svg (+1/-81)
src/maasserver/static/assets/images/icons/warning-mono.svg (+1/-96)
src/maasserver/static/assets/images/icons/warning.svg (+1/-123)
src/maasserver/static/assets/images/icons/warning_colour_black.svg (+1/-114)
src/maasserver/static/assets/images/icons/warning_colour_white.svg (+1/-123)
src/maasserver/static/assets/images/icons/warning_mono.svg (+1/-96)
src/maasserver/static/css/build.css (+1/-1)
src/maasserver/static/js/angular/3rdparty/sticky.js (+684/-0)
src/maasserver/static/js/angular/controllers/dashboard.js (+2/-2)
src/maasserver/static/js/angular/controllers/tests/test_dashboard.js (+1/-1)
src/maasserver/static/js/angular/directives/boot_images.js (+1/-1)
src/maasserver/static/js/angular/directives/error_overlay.js (+1/-1)
src/maasserver/static/js/angular/directives/maas_obj_form.js (+11/-0)
src/maasserver/static/js/angular/directives/tests/test_boot_images.js (+1/-1)
src/maasserver/static/js/angular/directives/tests/test_maas_obj_form.js (+29/-0)
src/maasserver/static/js/angular/maas.js (+2/-1)
src/maasserver/static/partials/boot-images.html (+1/-1)
src/maasserver/static/partials/dashboard.html (+194/-184)
src/maasserver/static/partials/domain-details.html (+1/-1)
src/maasserver/static/partials/domains-list.html (+1/-1)
src/maasserver/static/partials/error.html (+1/-1)
src/maasserver/static/partials/fabric-details.html (+2/-2)
src/maasserver/static/partials/images.html (+1/-1)
src/maasserver/static/partials/intro-user.html (+30/-29)
src/maasserver/static/partials/intro.html (+68/-67)
src/maasserver/static/partials/networks-list.html (+1/-1)
src/maasserver/static/partials/node-details.html (+2/-2)
src/maasserver/static/partials/node-events.html (+3/-3)
src/maasserver/static/partials/node-result.html (+2/-2)
src/maasserver/static/partials/nodes-list.html (+1/-1)
src/maasserver/static/partials/settings.html (+1/-1)
src/maasserver/static/partials/space-details.html (+2/-2)
src/maasserver/static/partials/ssh-keys.html (+14/-16)
src/maasserver/static/partials/subnet-details.html (+5/-5)
src/maasserver/static/partials/vlan-details.html (+2/-2)
src/maasserver/static/scss/_base.forms.scss (+1/-0)
src/maasserver/static/scss/_components.buttons.scss (+6/-0)
src/maasserver/static/scss/_components.flashmessages.scss (+4/-4)
src/maasserver/static/scss/_components.forms.scss (+6/-0)
src/maasserver/static/scss/_components.icons.scss (+0/-12)
src/maasserver/static/scss/_components.tables.scss (+48/-0)
src/maasserver/static/scss/_helpers.display.scss (+15/-0)
src/maasserver/static/scss/_helpers.spacing.scss (+1/-1)
src/maasserver/static/scss/_patterns.page-header.scss (+1/-0)
src/maasserver/templates/maasserver/base.html (+1/-1)
src/maasserver/templates/maasserver/form_field.html (+2/-0)
src/maasserver/templates/maasserver/js-conf.html (+3/-0)
src/maasserver/templates/maasserver/settings.html (+0/-11)
src/maasserver/views/combo.py (+6/-0)
Changed in maas: | |
milestone: | none → 2.1.0 |
importance: | Undecided → Low |
status: | New → Triaged |
summary: |
- [FUJ] Section complete/incomplete icon + [2.1, FUJ] Section complete/incomplete icon |
Changed in maas: | |
status: | Incomplete → Won't Fix |
status: | Won't Fix → Incomplete |
Changed in maas: | |
milestone: | 2.1.0 → 2.1.1 |
Changed in maas: | |
milestone: | 2.1.1 → 2.1.2 |
Changed in maas: | |
milestone: | 2.1.2 → 2.1.3 |
Changed in maas: | |
status: | Incomplete → Fix Released |
milestone: | 2.1.3 → none |
To post a comment you must log in.
Hi Maria,
Can you please point us to where in the designs is this defined. Maybe I'm looking in the wrong place but in here https:/ /github. com/CanonicalLt d/MAAS- design/ tree/master/ First%20Use% 20Journey/ Flat_Visuals
I don't see what you are referring to.
That said, I'd argue that showing a red X when there's an error with one of the input fields (such in your example), is better than showing a grey tick, because that affects the whole section. We can discuss in the standup.