patch - fix reverse search in various terminal apps

Bug #1627007 reported by Vlad Orlov
8
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Gnome Virtual Terminal Emulator
Fix Released
Medium
vte2.91 (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

[Impact]

Due to a regression in vte2.91 0.44.0, reverse search was broken in various terminals like mate-terminal (GTK+3 build) or gnome-terminal. Searching with Ctrl-Shift-G could show you a result or two in the currently visible part of terminal log, but further searching (with scrolling the terminal upwards) stopped working completely.

This wasn't fixed in version 0.44.2, so 0.44.2-1ubuntu2 in Ubuntu 16.10 still has this bug. The fix was recently applied upstream, and it would be good to have it backported to 16.10.

The debdiff with the fix is in the attachment below.

[Test Case]

1. Have Ubuntu 16.10 and mate-terminal or gnome-terminal.
2. Have a lot of text in your terminal window, enough to make the vertical scrollbar show. For example, you can build some package which is built with autotools. You'll get lots of occurrences of the same word, like 'make' or 'installing'.
3. Try searching for some word with reverse search.

[Regression Potential]

The code change in the patch only affects the search functionality, and that was already broken so you can't break it more. I've tested both forward and reverse search with the patch, and they both work fine now. I consider the regression risk to be quite low here.

Tags: patch yakkety
Revision history for this message
Vlad Orlov (monsta) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "this patch fixes reverse search in terminal apps" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

Changed in vte:
importance: Unknown → Medium
status: Unknown → Fix Released
Mathew Hodson (mhodson)
Changed in vte2.91 (Ubuntu):
importance: Undecided → Medium
Revision history for this message
dino99 (9d9) wrote :

@Mathew,

i was hoping some cleanup before the yakkety final release: for example start a gnome-shell session and check the journalctl output. You will see a bunch a widgets garbage when the terminal is used.

Please backport the required fixes recently published; these logs are warnings, but give a very bad feeling of dirty apps maintenance.

 https://git.gnome.org/browse/vte/

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in vte2.91 (Ubuntu):
status: New → Confirmed
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Thank you!

I made some changes to your debian/changelog entry. In particular, Ubuntu does not have NMUs because all Ubuntu packages are collectively maintained by Ubuntu contributors.

And I added this bug number so that the bug will automatically be closed when the package arrives in yakkety.

Changed in vte2.91 (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Vlad Orlov (monsta) wrote :

Thanks. Indeed, I keep forgetting about this nuance. Sometimes I submit patches to Debian as well, and I'm used to running 'dch --nmu' as described in this tutorial:

https://raphaelhertzog.com/2011/07/04/how-to-prepare-patches-for-debian-packages/

Also I didn't know there's an auto-closing feature. I need to remember to use it from now on. :)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package vte2.91 - 0.44.2-1ubuntu3

---------------
vte2.91 (0.44.2-1ubuntu3) yakkety; urgency=medium

  * Add fix-reverse-search.patch:
    - Backport commit from 0.44 branch to fix regression in 0.44.0 that broke
      reverse search (LP: #1627007)

 -- Vlad Orlov <email address hidden> Fri, 23 Sep 2016 14:49:51 +0300

Changed in vte2.91 (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.