Ubuntu
ubuntu-ui-toolkit package

Layouts unit tests fail on Yakkety

Bug #1625137 reported by Tim Peeters on 2016-09-19

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	ubuntu-ui-toolkit (Ubuntu)	Fix Released	Critical	Tim Peeters

Bug Description

/«BUILDDIR»/ubuntu-ui-toolkit-1.3.2104+16.10.20160919.2/tests/checkresults.sh /«BUILDDIR»/ubuntu-ui-toolkit-1.3.2104+16.10.20160919.2/tests/*.xml || exit 1; pep8 /«BUILDDIR»/ubuntu-ui-toolkit-1.3.2104+16.10.20160919.2 || exit 1;
3 fatal warnings which MUST be fixed:
layouts

Only warnings, but our shell script checks for warnings and makes them fatal.

********* Start testing of tst_Layouts *********
Config: Using QtTest library 5.6.1, Qt 5.6.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 6.2.0 20160914)
PASS : tst_Layouts::initTestCase()
[New Thread 0x7fffe1824700 (LWP 19588)]
[New Thread 0x7fffe1023700 (LWP 19589)]
[New Thread 0x7fffe0822700 (LWP 19590)]
[New Thread 0x7fffe0021700 (LWP 19591)]
[New Thread 0x7fffdf820700 (LWP 19592)]
[Thread 0x7fffdf820700 (LWP 19592) exited]
PASS : tst_Layouts::testCase_NoLayouts()
[New Thread 0x7fffdf820700 (LWP 19593)]
[Thread 0x7fffdf820700 (LWP 19593) exited]
PASS : tst_Layouts::testCase_SimpleLayout()
[New Thread 0x7fffdf820700 (LWP 19594)]
[Thread 0x7fffdf820700 (LWP 19594) exited]
PASS : tst_Layouts::testCase_SimpleLayout_Medium()
[New Thread 0x7fffdf820700 (LWP 19595)]
[Thread 0x7fffdf820700 (LWP 19595) exited]
PASS : tst_Layouts::testCase_SimpleLayout_Large()
[New Thread 0x7fffdf820700 (LWP 19596)]
[Thread 0x7fffdf820700 (LWP 19596) exited]
PASS : tst_Layouts::testCase_OverlappingCondition()
[New Thread 0x7fffdf820700 (LWP 19597)]
[Thread 0x7fffdf820700 (LWP 19597) exited]
PASS : tst_Layouts::testCase_ExternalLayouts()
[New Thread 0x7fffdf820700 (LWP 19598)]
[Thread 0x7fffdf820700 (LWP 19598) exited]
PASS : tst_Layouts::testCase_ExternalLayouts_Medium()
[New Thread 0x7fffdf820700 (LWP 19599)]
[Thread 0x7fffdf820700 (LWP 19599) exited]
PASS : tst_Layouts::testCase_ExternalLayouts_Large()
[New Thread 0x7fffdf820700 (LWP 19600)]
[Thread 0x7fffdf820700 (LWP 19600) exited]
PASS : tst_Layouts::testCase_NestedLayouts()
[New Thread 0x7fffdf820700 (LWP 19601)]
[Thread 0x7fffdf820700 (LWP 19601) exited]
PASS : tst_Layouts::testCase_NestedLayouts_ExtraLarge()
[New Thread 0x7fffdf820700 (LWP 19602)]
[Thread 0x7fffdf820700 (LWP 19602) exited]
PASS : tst_Layouts::testCase_ResizingContainers()
[New Thread 0x7fffdf820700 (LWP 19603)]
XFAIL : tst_Layouts::testCase_CurrentLayoutChange() Layout change should not happen when component is not defined
Loc: [tst_layouts.cpp(387)]
[Thread 0x7fffdf820700 (LWP 19603) exited]
PASS : tst_Layouts::testCase_CurrentLayoutChange()
[New Thread 0x7fffdf820700 (LWP 19604)]
XFAIL : tst_Layouts::testCase_PositioningOnLayoutChange() Layout change should not happen when component is not defined
Loc: [tst_layouts.cpp(408)]
[Thread 0x7fffdf820700 (LWP 19604) exited]
PASS : tst_Layouts::testCase_PositioningOnLayoutChange()
[New Thread 0x7fffdf820700 (LWP 19605)]
[Thread 0x7fffdf820700 (LWP 19605) exited]
PASS : tst_Layouts::testCase_LaidOutItemsOutsideOfLayout()
[New Thread 0x7fffdf820700 (LWP 19606)]
[Thread 0x7fffdf820700 (LWP 19606) exited]
PASS : tst_Layouts::testCase_OverlaidInItemLayout()
[New Thread 0x7fffdf820700 (LWP 19607)]
[Thread 0x7fffdf820700 (LWP 19607) exited]
PASS : tst_Layouts::testCase_AnchorFilledReparenting()
[New Thread 0x7fffdf820700 (LWP 19608)]
[Thread 0x7fffdf820700 (LWP 19608) exited]
PASS : tst_Layouts::testCase_AnchorFilledMargins()
[New Thread 0x7fffdf820700 (LWP 19609)]
[Thread 0x7fffdf820700 (LWP 19609) exited]
PASS : tst_Layouts::testCase_AnchorFilledSeparateMargins()
[New Thread 0x7fffdf820700 (LWP 19610)]
[Thread 0x7fffdf820700 (LWP 19610) exited]
PASS : tst_Layouts::testCase_AnchorCenteredInDefault()
[New Thread 0x7fffdf820700 (LWP 19611)]
[Thread 0x7fffdf820700 (LWP 19611) exited]
PASS : tst_Layouts::testCase_AnchorVerticalCenter()
[New Thread 0x7fffdf820700 (LWP 19612)]
[Thread 0x7fffdf820700 (LWP 19612) exited]
PASS : tst_Layouts::testCase_AnchorVerticalCenterOffset()
[New Thread 0x7fffdf820700 (LWP 19613)]
[Thread 0x7fffdf820700 (LWP 19613) exited]
PASS : tst_Layouts::testCase_AnchorHorizontalCenter()
[New Thread 0x7fffdf820700 (LWP 19614)]
[Thread 0x7fffdf820700 (LWP 19614) exited]
PASS : tst_Layouts::testCase_AnchorHorizontalCenterOffset()
[New Thread 0x7fffdf820700 (LWP 19615)]
[Thread 0x7fffdf820700 (LWP 19615) exited]
PASS : tst_Layouts::testCase_AnchorCenterWithOffset()
[New Thread 0x7fffdf820700 (LWP 19616)]
[Thread 0x7fffdf820700 (LWP 19616) exited]
PASS : tst_Layouts::testCase_AnchorLeft()
[New Thread 0x7fffdf820700 (LWP 19617)]
[Thread 0x7fffdf820700 (LWP 19617) exited]
PASS : tst_Layouts::testCase_AnchorTop()
[New Thread 0x7fffdf820700 (LWP 19618)]
[Thread 0x7fffdf820700 (LWP 19618) exited]
PASS : tst_Layouts::testCase_AnchorRight()
[New Thread 0x7fffdf820700 (LWP 19619)]
[Thread 0x7fffdf820700 (LWP 19619) exited]
PASS : tst_Layouts::testCase_AnchorBottom()
[New Thread 0x7fffdf820700 (LWP 19620)]
[Thread 0x7fffdf820700 (LWP 19620) exited]
PASS : tst_Layouts::testCase_AnchorAll()
[New Thread 0x7fffdf820700 (LWP 19621)]
[Thread 0x7fffdf820700 (LWP 19621) exited]
PASS : tst_Layouts::testCase_ItemInstanceAsProperty()
[New Thread 0x7fffdf820700 (LWP 19622)]
QWARN : tst_Layouts::testCase_DialerCrash() libpng warning: iCCP: known incorrect sRGB profile
[Thread 0x7fffdf820700 (LWP 19622) exited]
PASS : tst_Layouts::testCase_DialerCrash()
[New Thread 0x7fffdf820700 (LWP 19623)]
[Thread 0x7fffdf820700 (LWP 19623) exited]
PASS : tst_Layouts::testCase_ExcludedItemDeleted()
[New Thread 0x7fffdf820700 (LWP 19624)]
QDEBUG : tst_Layouts::testCase_Visibility() qml: Page_QMLTYPE_166(0x555555e3ddd0)"Conditional Layouts with PageStack": In Ubuntu.Components 1.3, the use of Page.title, Page.flickable and Page.head is deprecated. Use Page.header and the PageHeader component instead.
[Thread 0x7fffdf820700 (LWP 19624) exited]
PASS : tst_Layouts::testCase_Visibility()
[New Thread 0x7fffdf820700 (LWP 19625)]
QWARN : tst_Layouts::testCase_NestedVisibility(portrait) libpng warning: iCCP: known incorrect sRGB profile
[New Thread 0x7fffd7fff700 (LWP 19626)]
QDEBUG : tst_Layouts::testCase_NestedVisibility(portrait) qml: Page.tools is a deprecated property. Please use Page.head instead.
[Thread 0x7fffdf820700 (LWP 19625) exited]
[Thread 0x7fffd7fff700 (LWP 19626) exited]
PASS : tst_Layouts::testCase_NestedVisibility(portrait)
[New Thread 0x7fffd7fff700 (LWP 19627)]
QWARN : tst_Layouts::testCase_NestedVisibility(landscape) libpng warning: iCCP: known incorrect sRGB profile
[New Thread 0x7fffdf820700 (LWP 19628)]
QDEBUG : tst_Layouts::testCase_NestedVisibility(landscape) qml: Page.tools is a deprecated property. Please use Page.head instead.
[Thread 0x7fffd7fff700 (LWP 19627) exited]
[Thread 0x7fffdf820700 (LWP 19628) exited]
PASS : tst_Layouts::testCase_NestedVisibility(landscape)
PASS : tst_Layouts::cleanupTestCase()
Totals: 37 passed, 0 failed, 0 skipped, 0 blacklisted
********* Finished testing of tst_Layouts *********

Tags:

Related branches

lp:~tpeeters/ubuntu-ui-toolkit/y-libpng-fix

Merged into lp:ubuntu-ui-toolkit/staging at revision 2129

ubuntu-sdk-build-bot: Approve (continuous-integration) on 2016-09-23

Zsombor Egri: Approve on 2016-09-23

lp:~ci-train-bot/ubuntu-ui-toolkit/ubuntu-ui-toolkit-ubuntu-yakkety-2035 (Merged)

Revision history for this message

Tim Peeters (tpeeters) wrote on 2016-09-19:

A lot of other tests also have the libpng warnings, but it seems they are not fatal there.

Revision history for this message

Tim Peeters (tpeeters) wrote on 2016-09-19:

I temporarily disable the test here https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/disable-layouts-tests/+merge/306077

tags:

added: qt5.6

Zsombor Egri (zsombi) on 2016-09-20

Changed in ubuntu-ui-toolkit (Ubuntu):
importance:	Undecided → Critical

Tim Peeters (tpeeters) on 2016-09-23

Changed in ubuntu-ui-toolkit (Ubuntu):
assignee:	nobody → Tim Peeters (tpeeters)
status:	New → In Progress

Revision history for this message

Tim Peeters (tpeeters) wrote on 2016-09-23:

This bug also blocks https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/qt56fixes2sections/+merge/306328 because it fails on some libpng warnings in tst_mainview11.

Tim Peeters (tpeeters) on 2016-09-27

Changed in ubuntu-ui-toolkit (Ubuntu):
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-10-06:

Download full text (4.4 KiB)

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.2135+16.10.20161003.1

---------------
ubuntu-ui-toolkit (1.3.2135+16.10.20161003.1) yakkety; urgency=medium

  [ Christian Dywan ]
  * Fix warning about using implicit char* to QString conversion.
  * __styleInstance may be null, when doesn't handle that. Fixes LP: #1586013
  * Focus ring, arrow keys and space to expand OptionSelector.
    Fixes LP: #1514860
  * Use QStringLiteral with QString.replace. Fixes LP: #1625507
  * Use displayText to determine if the clear button should show.
    Fixes LP: #1461571
  * && escapes an ampersand used in a mnemonic label. Fixes LP: #1587580
  * Try harder to pass an item to QuickUtils.rootItem. Fixes LP: #1586013

  [ Timo Jyrinki ]
  * Enable arm64 unit tests on xenial and newer. Fixes LP: #1580172.
  * Add initial snapcraft.yaml

  [ Marco Trevisan ]
  * UCSlotsLayout: update the size of the element when top/bottom paddings change.
    Fixes LP: #1628161

  [ Tim Peeters ]
  * Ensure that the model in TabBarStyle is a list and not null.
    Fixes LP: #1622577.
  * Initialize the 'window' context property with null and add MainView 1.3 unit
    tests. Fixes LP: #1610231, LP: #1621509, LP: #1625993.
  * Fix libpng sRGB profile warnings on Yakkety. Fixes LP: #1625137.
  * Disable layouts unit test to work around bug 1625137 on Yakkety.

  [ Zsombor Egri ]
  * Fix AdaptivePageLayout behavior on Qt5.6. Fixes LP: #1585996.
  * Fix property binding restore on theme palette values. Fixes LP: #1570478.
  * Move activeFocusOnTab from style into components. Fixes LP: #1590005.

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.2135+16.10.20161003.1

---------------
ubuntu-ui-toolkit (1.3.2135+16.10.20161003.1) yakkety; urgency=medium

[ Timo Jyrinki ]
  * Enable arm64 unit tests on xenial and newer. Fixes LP: #1580172.
  * Add initial snapcraft.yaml

[ Marco Trevisan ]
  * UCSlotsLayout: update the size of the element when top/bottom paddings change.
    Fixes LP: #1628161

[ Loïc Molinari ]
  * Added public headers extra robustness checks. Made use of the qmake
    headersclean feature to check the robustness of our public headers.
  * Excluded LTTng features from non-Linux builds.
  * Moved common C++ configs to ubuntu_common.prf. The common config file
    doesn't add -Werror directly to QMAKE_CXXFLAGS anymore, it sets the
    warnings_are_errors variable so that it is correctly handled by different
    compilers (not just GCC). That allows to remove the
    -Werror=deprecated-declarations flag since warnings_are_errors defines it
    for us. Removed the DEFINES += QT_USE_QSTRINGBUILDER lines since it's
    already handled by qt_module.prf. Set the -Wsuggest-override warning to
    QMAKE_CXXFLAGS_WARN_ON instead of QMAKE_CXXFLAGS directly.
  * Cleaned up qmake Ubuntu packaging variables. The qtbase packaging for Ubuntu
    exports the CFLAGS, CXXFLAGS and LFLAGS variables in the environment before
    running configure so that the qtbase shared libraries can be compiled with
    the required distribution defined compiler flags. That is fine (though I
    guess that could be handled better at the qtbase packaging level with maybe
    a dedicated prf) but it results in qt_build_config.prf defining the
    QMAKE_CFLAGS, QMAKE_CXXFLAGS and QMAKE_LFLAGS variables with these
    distribution specific flags. Since we load this prf, these variables end up
    being defined when building the toolkit for development purpose. This is
    problematic because -O2 and -g are always defined (whatever the debug or
    release config chosen by the developer), also these are GCC specific flags
    which makes our build break with other compilers. This is also ugly because
    preprocessor defines are directly set in the QMAKE_C*FLAGS. In order to
    workaround these issues, we unset these variables and set the different
    flags apart from -g and -O2 in the right qmake variables. This allows to
    keep compiling with the Debian flags but in a more flexible way. For the
    Debian packaging, we keep the former behaviour by simply passing the
    debian_build config.
  * Optimised QString code gen for ASCII strings known at compile-time. That
    allows the compiler to optimise our code better by putting all these
    QStrings known at compile time in the .rodata section of the binary as well
    as preventing a bunch of useless processing on them. That also allows us to
    remove "DEFINES -= QT_ASCII_CAST_WARNINGS" from the UbuntuToolkit pro file.

[ Zoltán Balogh ]
  * Explicit include of cstdio.

[ Andrea Bernabei ]
  * Qt5.6: Fix expandablescolumn.11 and expandables.11 unit tests
  * Qt5.6 fixes QTBUG-41686 and requires x/y to be explicitly passed.
    Fixes LP: #1610230.
  * Qt5.6: fix Scrollbar unit tests
  * Qt5.6: fix ubuntulistview.10 unit test

-- Zoltán Balogh <zoltan.balogh@canonical.com>  Mon, 03 Oct 2016 11:39:58 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.

Ubuntuubuntu-ui-toolkit package

Layouts unit tests fail on Yakkety

Bug Description

Related branches

Other bug subscribers

Remote bug watches

Ubuntu
ubuntu-ui-toolkit package