python-muranoclient

[glare] It is possible to import package twice via plugin with enabled glance artifact repository

Bug #1624943 reported by Kirill Zaitsev
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-muranoclient
Fix Released
Critical
Kirill Zaitsev
python-muranoclient 0.12.0
Newton
Fix Committed
Critical
Valerii Kovalchuk
python-muranoclient 0.11.1
Ocata
Fix Released
Critical
Kirill Zaitsev
python-muranoclient 0.12.0

Bug Description

Bug description:
Currently it is possible to import any app several times via murano cli if you are using fuel murano plugin with enabled glance artifact repository.

Steps to reproduce:
1) deploy fuel 9.0
2) install fuel murano plugin
3) add 1 controller and 1 compute
4) enable fuel murano plugin and enable glance artifact repository
5) deploy environment
6) ssh to the controller
7) use "murano --murano-repo-url=http://storage.apps.openstack.org package-import com.example.databases.MySql" to import MySql. Use this command second time to import in again.

Expected results:
the second time command should tell that MySql is already exist. So it will be only one MySql package

Actual results:
MySql will be imported twice(see screenshot)

upstream glance bug: https://bugs.launchpad.net/glance/+bug/1623567

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-muranoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/372181

Changed in python-muranoclient:
assignee: nobody → Kirill Zaitsev (kzaitsev)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-muranoclient (master)

Reviewed: https://review.openstack.org/372181
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=9f8e6c3286c51f0c49b89c37e83de70ce93396b6
Submitter: Jenkins
Branch: master

commit 9f8e6c3286c51f0c49b89c37e83de70ce93396b6
Author: Kirill Zaitsev <email address hidden>
Date: Mon Sep 19 01:17:46 2016 +0300

    Populate tenant information in client

    Python-muranoclient uses tenant id when talking to glare to avoid
    importing the same package twice. However tenant information was not
    available in the CLI and tenant id defaulted to None.
    This led to a situation, where it was possible to
    import the same package multiple times if it was not public.

    This patch fixes the issue by acquiring package information from
    keystoneauth or from user-supplied values in case no-auth is enforced.

    Murano dashboard was not affected by this issue.

    Change-Id: I72ad006c76945bf5707172ab128a89f1f6a7b112
    Closes-Bug: #1624943

Changed in python-muranoclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-muranoclient (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/378669

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-muranoclient (stable/newton)

Reviewed: https://review.openstack.org/378669
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=2600d963ff909578b796f4faa6d72382b4156261
Submitter: Jenkins
Branch: stable/newton

commit 2600d963ff909578b796f4faa6d72382b4156261
Author: Kirill Zaitsev <email address hidden>
Date: Mon Sep 19 01:17:46 2016 +0300

    Populate tenant information in client

    Python-muranoclient uses tenant id when talking to glare to avoid
    importing the same package twice. However tenant information was not
    available in the CLI and tenant id defaulted to None.
    This led to a situation, where it was possible to
    import the same package multiple times if it was not public.

    This patch fixes the issue by acquiring package information from
    keystoneauth or from user-supplied values in case no-auth is enforced.

    Murano dashboard was not affected by this issue.

    Change-Id: I72ad006c76945bf5707172ab128a89f1f6a7b112
    Closes-Bug: #1624943
    (cherry picked from commit 9f8e6c3286c51f0c49b89c37e83de70ce93396b6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-muranoclient 0.11.1

This issue was fixed in the openstack/python-muranoclient 0.11.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-muranoclient 0.12.0

This issue was fixed in the openstack/python-muranoclient 0.12.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.