Wrong bit set in klibc PXE dhcp/bootp flags

Bug #1624014 reported by Dan Streetman
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
klibc (Ubuntu)
Fix Released
High
Mathieu Trudel-Lapierre
Trusty
Fix Released
High
Mathieu Trudel-Lapierre
Xenial
Fix Released
High
Mathieu Trudel-Lapierre
Yakkety
Fix Released
High
Mathieu Trudel-Lapierre

Bug Description

[Description]

The patch for bug 1327412 set the wrong bit in the bootp flags field. It set flags to 0x800, but the correct value is 0x8000. That sets the "broadcast" bit, and the spec requires all other bits to be 0.

Setting one of the "must be zero" bits in the flags field causes some DHCP relay agents to drop the packets, causing PXE to fail.

[Test Case]

Get a DHCP relay agent that drops PXE packets with an invalid bootp.flags bit set, and try to PXE boot; it fails.

[Regression]

None, the previous patch introduced this regression.

Revision history for this message
Dan Streetman (ddstreet) wrote :
Revision history for this message
Dan Streetman (ddstreet) wrote :
Revision history for this message
Dan Streetman (ddstreet) wrote :
Revision history for this message
Dan Streetman (ddstreet) wrote :
Revision history for this message
Dan Streetman (ddstreet) wrote :
Mathew Hodson (mhodson)
tags: added: regression-update
Changed in klibc (Ubuntu Trusty):
status: New → In Progress
Changed in klibc (Ubuntu Yakkety):
status: New → In Progress
Changed in klibc (Ubuntu Xenial):
status: New → In Progress
Changed in klibc (Ubuntu Yakkety):
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)
Changed in klibc (Ubuntu Trusty):
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)
Changed in klibc (Ubuntu Xenial):
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)
Changed in klibc (Ubuntu Trusty):
importance: Undecided → High
Changed in klibc (Ubuntu Xenial):
importance: Undecided → High
Changed in klibc (Ubuntu Yakkety):
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package klibc - 2.0.4-8ubuntu3

---------------
klibc (2.0.4-8ubuntu3) yakkety; urgency=medium

  * debian/patches/broadcast_dhcp_send.patch: the patch sets the wrong bit in
    the bootp flags field, instead of 0x800 it must be 0x8000. (LP: #1624014)

 -- Dan Streetman <email address hidden> Fri, 16 Sep 2016 20:20:58 -0400

Changed in klibc (Ubuntu Yakkety):
status: In Progress → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Dan, or anyone else affected,

Accepted klibc into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/klibc/2.0.4-8ubuntu1.16.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in klibc (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Dan, or anyone else affected,

Accepted klibc into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/klibc/2.0.3-0ubuntu1.14.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in klibc (Ubuntu Trusty):
status: In Progress → Fix Committed
Revision history for this message
Kevin Metz (pertinent) wrote :

The fix has been tested and is working. Several machine's have been booted and commissioned successfully

tags: added: verification-done-xenial verification-needed-trusty
removed: verification-needed
Revision history for this message
Rich Doyle (o-rich) wrote :

I can confirm that with this fix I have been successfully able to enlist, commission and deploy ubuntu to multiple servers in a cabinet via a DHCP relay agent to MaaS in another cabinet. THis is great! THanks.

Revision history for this message
Rich Doyle (o-rich) wrote :

Note, I was using a provided hotfix build of xenial in my tests.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package klibc - 2.0.4-8ubuntu1.16.04.2

---------------
klibc (2.0.4-8ubuntu1.16.04.2) xenial; urgency=medium

  * debian/patches/fix_broadcast_flag-bit.patch: the previous patch set the
    wrong bit in the bootp flags field, instead of 0x800 it must be 0x8000.
    (LP: #1624014)

 -- Dan Streetman <email address hidden> Tue, 20 Sep 2016 14:20:36 -0500

Changed in klibc (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for klibc has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Guga (tylderon) wrote :

Hello, cyphermox!

Do you think you could send your patches upstream as well?

The same bug affects Debian (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756633) and, probably, the source packages. It's sad seeing this fixed in Ubuntu only.

Thanks!

Revision history for this message
Guga (tylderon) wrote :

I've tested Clonezilla's Alternative Stable branch (Yakkety-based), and its Alternative Testing branch (Zesty-based) and the bug is squashed on both platforms. It would be nice if someone could test Trusty as well.

Revision history for this message
Dan Streetman (ddstreet) wrote :

I confirmed the fix is correct in trusty by tcpdumping a run of /usr/lib/klibc/bin/ipconfig

tags: added: verification-done-trusty
removed: verification-needed-trusty
Revision history for this message
Dan Streetman (ddstreet) wrote :

to clarify, tcpdump with klibc-utils 2.0.3-0ubuntu1.14.04.1 shows the flag is 0x0800 (incorrect) while tcpdump with klibc-utils 2.0.3-0ubuntu1.14.04.2 (from -proposed) shows the flag is 0x8000 (correct).

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package klibc - 2.0.3-0ubuntu1.14.04.2

---------------
klibc (2.0.3-0ubuntu1.14.04.2) trusty; urgency=medium

  * debian/patches/fix_broadcast_flag-bit.patch: the previous patch set the
    wrong bit in the bootp flags field, instead of 0x800 it must be 0x8000.
    (LP: #1624014)

 -- Dan Streetman <email address hidden> Tue, 20 Sep 2016 14:07:24 -0500

Changed in klibc (Ubuntu Trusty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.