[2.1] NTP server settings: delimiters and address families
Bug #1619693 reported by
LaMont Jones
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Medium
|
Gavin Panella | ||
Bug Description
It is not clear on the setup page that NTP servers must be a comma separated list.
We should either clear that up on the page, or notice that they gave us a space-delimited list, and make it comma-delimited.
Furthermore, IPv6 literals in the list cause the IPv4 DHCP daemon to throw errors, and should only be present in the sntp-servers option. I don't recall if IPv4 addresses are fatal to the sntp-servers option, but this should be verified, and fixed if needed.
Related branches
lp:~allenap/maas/ntp-ui-delimiter
- Mike Pontillo (community): Approve
-
Diff: 59 lines (+23/-4)3 files modifiedsrc/maasserver/fields.py (+4/-0)
src/maasserver/forms_settings.py (+6/-4)
src/maasserver/tests/test_fields.py (+13/-0)
Revision history for this message
| Mike Pontillo (mpontillo) wrote | #1 |
| Changed in maas: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| milestone: | none → 2.1.0 |
| milestone: | 2.1.0 → none |
| summary: |
- [ntp] NTP server settings: delimiters and address families + [2.1] NTP server settings: delimiters and address families |
| Changed in maas: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Gavin Panella (allenap) |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think when you specify upstream DNS servers, we allow the user to specify commas and/or spaces. I think we should be consistent with that behavior.