tempest

Tempest lib check-uuid enforces use of private tempest methods

Bug #1616913 reported by Kiall Mac Innes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tempest
Fix Released
Medium
Ken'ichi Ohmichi

Bug Description

The check-uuid command from tempest.lib enforces use of tempest.test.idempotent_id, vs the tempest.lib.decorators.idempotent_id method.

tempest.test is not included in the list of stable APIs plugins may use[1]. This should be updated to use the tempest.lib paths.

[1]: http://docs.openstack.org/developer/tempest/plugin.html#stable-tempest-apis-plugins-may-use

Revision history for this message
Matthew Treinish (treinish) wrote :

Yeo, this needs to be updated. We'll have to switch tempest over to just directly import the decorator from tempest.lib everywhere at the same time instead of the alias in tempest.test. But that was only ever added to make the initial migration easier and was going to be removed eventually

Changed in tempest:
importance: Undecided → Medium
status: New → Confirmed
Kiall Mac Innes (kiall)
Changed in tempest:
assignee: nobody → Kiall Mac Innes (kiall)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/360689

Changed in tempest:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tempest (master)

Change abandoned by Kiall Mac Innes (<email address hidden>) on branch: master
Review: https://review.openstack.org/360689

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tempest (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/426442

Ken'ichi Ohmichi (oomichi)
Changed in tempest:
assignee: Kiall Mac Innes (kiall) → Ken'ichi Ohmichi (oomichi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/426445

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/426446

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/426448

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/426450

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/426453

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/426455

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/426456

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/426457

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/426458

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/426459

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tempest (master)

Reviewed: https://review.openstack.org/426442
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=ebbfd1c74dd2c29101f0207979a750a5dbf16883
Submitter: Jenkins
Branch: master

commit ebbfd1c74dd2c29101f0207979a750a5dbf16883
Author: Ken'ichi Ohmichi <email address hidden>
Date: Fri Jan 27 16:37:00 2017 -0800

    Switch to decorators.idempotent_id on compute.admin

    So many modules are using test.idempotent_id and this is the first
    step for switching to decorators.idempotent_id.

    Change-Id: I55a61d40f18f8fa0fea8423ad65302c1e3559205
    Related-Bug: #1616913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/426445
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=14b0ae1a31fae195eeeff941470440df36f070e2
Submitter: Jenkins
Branch: master

commit 14b0ae1a31fae195eeeff941470440df36f070e2
Author: Ken'ichi Ohmichi <email address hidden>
Date: Fri Jan 27 17:18:52 2017 -0800

    Switch to decorators.idempotent_id on compute.servers

    So many modules are using test.idempotent_id and this is for
    switching to decorators.idempotent_id on compute.servers.

    Change-Id: I6a7f8633b4808469dd92f2ac668674fba0bdb0ca
    Related-Bug: #1616913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/426446
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=6c92edfa2f242289192e5ff8bd9aadb079f26bca
Submitter: Jenkins
Branch: master

commit 6c92edfa2f242289192e5ff8bd9aadb079f26bca
Author: Ken'ichi Ohmichi <email address hidden>
Date: Fri Jan 27 17:32:10 2017 -0800

    Switch to decorators.idempotent_id on compute.*

    So many modules are using test.idempotent_id and this is for
    switching to decorators.idempotent_id on compute.*.

    Change-Id: Ib4ace375a41b9607d1b1cea7dda296fb601a0264
    Related-Bug: #1616913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/426448
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=eeabdd2ce6576836a4572bdd5eced17809675515
Submitter: Jenkins
Branch: master

commit eeabdd2ce6576836a4572bdd5eced17809675515
Author: Ken'ichi Ohmichi <email address hidden>
Date: Fri Jan 27 17:46:00 2017 -0800

    Switch to decorators.idempotent_id on identity

    So many modules are using test.idempotent_id and this is for
    switching to decorators.idempotent_id on identity.

    Change-Id: I8c3ad6a3b20c6829c752f9fae5a27bd3e284c1b1
    Related-Bug: #1616913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/426450
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=f35efa216df4356507219ddbb28fc1bf24f44ac3
Submitter: Jenkins
Branch: master

commit f35efa216df4356507219ddbb28fc1bf24f44ac3
Author: Ken'ichi Ohmichi <email address hidden>
Date: Fri Jan 27 17:55:24 2017 -0800

    Switch to decorators.idempotent_id on image

    So many modules are using test.idempotent_id and this is for
    switching to decorators.idempotent_id on image.

    Change-Id: I854b1afb59a4e46991df3672313e5a46a71f8210
    Related-Bug: #1616913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/426453
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=53b9a63b12da5ae6f010b0202c8a55202e5880b7
Submitter: Jenkins
Branch: master

commit 53b9a63b12da5ae6f010b0202c8a55202e5880b7
Author: Ken'ichi Ohmichi <email address hidden>
Date: Fri Jan 27 18:04:39 2017 -0800

    Switch to decorators.idempotent_id on network

    So many modules are using test.idempotent_id and this is for
    switching to decorators.idempotent_id on network.

    Change-Id: I2735d04dfbd5d48e87894457f2fc1172edf4da44
    Related-Bug: #1616913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/426456
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=835a945c107e421ccfb3852ad52ecca8cdbe758c
Submitter: Jenkins
Branch: master

commit 835a945c107e421ccfb3852ad52ecca8cdbe758c
Author: Ken'ichi Ohmichi <email address hidden>
Date: Fri Jan 27 18:17:07 2017 -0800

    Switch to decorators.idempotent_id on orchestration

    So many modules are using test.idempotent_id and this is for
    switching to decorators.idempotent_id on orchestration.

    Change-Id: I263beb986a43b12c2d6ce18ea2ded6d9db61faf1
    Related-Bug: #1616913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/426457
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=6b279c7dd64106a03784dbe86fcd5ecc95f2b8d3
Submitter: Jenkins
Branch: master

commit 6b279c7dd64106a03784dbe86fcd5ecc95f2b8d3
Author: Ken'ichi Ohmichi <email address hidden>
Date: Fri Jan 27 18:26:59 2017 -0800

    Switch to decorators.idempotent_id on volume

    So many modules are using test.idempotent_id and this is for
    switching to decorators.idempotent_id on volume.

    Change-Id: Icbf4a8d3e91cf25dda9529e0379e0336181a3570
    Related-Bug: #1616913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/426458
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=c85a951881a6d9a7408d8cc5c00f0ad6d1009c9a
Submitter: Jenkins
Branch: master

commit c85a951881a6d9a7408d8cc5c00f0ad6d1009c9a
Author: Ken'ichi Ohmichi <email address hidden>
Date: Fri Jan 27 18:34:24 2017 -0800

    Switch to decorators.idempotent_id on scenario

    So many modules are using test.idempotent_id and this is for
    switching to decorators.idempotent_id on scenario.

    Change-Id: Ieae5a2ee6937ad4339aff531eadc5e4986d7ec42
    Related-Bug: #1616913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/426455
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=b7bc1de859e0a101d11fd8ef31e43ac0b98fd942
Submitter: Jenkins
Branch: master

commit b7bc1de859e0a101d11fd8ef31e43ac0b98fd942
Author: Ken'ichi Ohmichi <email address hidden>
Date: Fri Jan 27 18:12:22 2017 -0800

    Switch to decorators.idempotent_id on object_storage

    So many modules are using test.idempotent_id and this is for
    switching to decorators.idempotent_id on object_storage.

    Change-Id: I200875e4c4c61127c8dd430f09e5a9a24a03a129
    Related-Bug: #1616913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (master)

Reviewed: https://review.openstack.org/426459
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=44f01273cff6edaf2f2fb079895105e79afbf1c1
Submitter: Jenkins
Branch: master

commit 44f01273cff6edaf2f2fb079895105e79afbf1c1
Author: Ken'ichi Ohmichi <email address hidden>
Date: Fri Jan 27 18:44:14 2017 -0800

    Finish switching to decorators.idempotent_id

    Most modules are switched to using decorators.idempotent_id and
    this patch covers the remaining and removes the old decorator check.

    NOTE: The old decorator test.idempotent_id is still necessary to be
          used on the other projects.

    Change-Id: Ice7f593fbc109863eba11402c2f3af75fc6ab9a1
    Closes-Bug: #1616913

Changed in tempest:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.