Juju isn't protected from new versions of LXD

Bug #1614724 reported by Nicholas Skaggs
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-release-tools
Fix Released
High
Nicholas Skaggs
juju-core (Ubuntu)
Fix Released
Undecided
Nicholas Skaggs
Xenial
Fix Released
Undecided
Nicholas Skaggs
Yakkety
Fix Released
Undecided
Nicholas Skaggs

Bug Description

Juju's autopkgtests don't execute when a new version of LXD is uploaded. This means a breaking change uploaded into LXD isn't caught before LXD lands.

This is because juju 2.0 doesn't depend on LXD directly, but instead lists it as a recommends. The juju-1 package, juju-local, depends on lxc directly and therefore the autopkgtests run during each new lxc upload. However, we are vulnerable for 2.0. Juju's autopkgtests do cover LXD and would provide protection if they were run.

To fix, we could list LXD as a depends on a package juju-core source package creates. This would run our tests and block incompatible LXD changes. Alternatively, we can explore ideas about checking proposed ourselves; however, the upload will not be blocked apart from a failing autopkgtest.

[SRU Information]

[Impact]
The addition of a dependency of LXD ensure juju binaries can only be built on platforms that also can build LXD and publish a package.

[Verification]
The debian control field lists LXD as a dependency. We should also see new adt runs of juju when LXD is uploaded.

[Regression Potential]
None.

[Other]
This should have no impact on end users of the package; the verification can be done by viewing juju-core source upload.

no longer affects: juju-core-1 (Ubuntu)
no longer affects: juju-core
Changed in juju-release-tools:
status: New → Triaged
importance: Undecided → High
Changed in juju-release-tools:
status: Triaged → In Progress
Changed in juju-core (Ubuntu):
status: New → In Progress
Changed in juju-release-tools:
assignee: nobody → Nicholas Skaggs (nskaggs)
Changed in juju-core (Ubuntu):
assignee: nobody → Nicholas Skaggs (nskaggs)
Revision history for this message
Anastasia (anastasia-macmood) wrote :

As part of the fix for https://bugs.launchpad.net/juju/+bug/1614559, Juju now checks for LXD versions and will reject newer versions that it is not compatible with.

Changed in juju-release-tools:
status: In Progress → Fix Released
Changed in juju-core (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package juju-core - 2.0~rc3-0ubuntu4.16.10.1

---------------
juju-core (2.0~rc3-0ubuntu4.16.10.1) yakkety-proposed; urgency=medium

  * Also pass no_proxy to bootstrap

 -- Nicholas Skaggs <email address hidden> Tue, 11 Oct 2016 11:10:06 -0400

Changed in juju-core (Ubuntu):
status: Fix Committed → Fix Released
Changed in juju-core (Ubuntu Xenial):
status: New → In Progress
Changed in juju-core (Ubuntu Yakkety):
status: New → In Progress
Changed in juju-core (Ubuntu Yakkety):
status: In Progress → Fix Released
assignee: nobody → Nicholas Skaggs (nskaggs)
Changed in juju-core (Ubuntu Xenial):
assignee: nobody → Nicholas Skaggs (nskaggs)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Nicholas, or anyone else affected,

Accepted juju-core into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/juju-core/2.0.0-0ubuntu0.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in juju-core (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Diff shows LXD is added, and we can see from yakkety and zesty the tests are running on new LXD uploads.

https://launchpadlibrarian.net/290947340/juju-core_2.0~beta15-0ubuntu2.16.04.1_2.0.0-0ubuntu0.16.04.1.diff.gz

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package juju-core - 2.0.0-0ubuntu0.16.04.2

---------------
juju-core (2.0.0-0ubuntu0.16.04.2) xenial; urgency=medium

  * DPKG_MAINTSCRIPT_ARCH doesn't work in .config, use dpkg check (LP: #1614969)

 -- Nicholas Skaggs <email address hidden> Mon, 31 Oct 2016 15:55:49 -0400

Changed in juju-core (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.