Remove incomplete fips in openssl in xenial.
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| openssl (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| Xenial |
Fix Released
|
Undecided
|
Marc Deslauriers | ||
| Yakkety |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Package: openssl-
Distro: xenial
The openssl contains incomplete fips patches. In light that the fips is incomplete and will not be completed in the main archive and they are impacting customers, they should be withdrawn. See lp bugs 1593953, 1591797, 1594748, 1588524, 1613658. Removal of these fips patches will remove these fips-related issues.
[Test case]
1. Problem in 1594748
Note: this problem was reported in upstream openssl and testcase posted there also.
https:/
CRYPTO_
This testcase should cause openssl to abort, but instead it returns a context.
#include <stdio.h>
#include <stdlib.h>
#include <openssl/ssl.h>
void * my_alloc(size_t n) { abort(); }
void my_free(void *p) { abort(); }
void * my_realloc(void *p, size_t n) { abort(); }
int main(int argc, const char **argv)
{
const SSL_METHOD *method;
SSL_CTX *ctx;
CRYPTO_
SSL_library_
method = SSLv23_
ctx = SSL_CTX_
printf("Got ctx %p\n", ctx);
return 0;
}
2. Problem in 1593953
EC key generation allows user to generate keys using EC curves that the EC sign and verify
do not support when OPENSSL_FIPS is defined.
Testcase taken from lp #1593953
openssl ecparam -genkey -name Oakley-EC2N-4
will fail when OPENSSL_FIPS is defined since it causes a fips key-pair consistency check to be done.
Otherwise, without OPENSSL_FIPS defined, the check is not done.
3. Problem reported in 1588524
Error code being skipped...
Testcase taken from lp #1588524
#include <openssl/err.h>
#include <openssl/ssl.h>
int main() {
int rc;
unsigned long fips_err;
SSL_
SSL_
ERR_
OpenSSL_
rc = FIPS_mode_set(1);
fips_err = ERR_peek_
// FIPS_mode_set will return 0 on failure, which is expected if
// the FIPS module is not compiled. In this case, we should then
// be able to get the error code
// CRYPTO_
// https:/
printf("%d %lu\n", rc, fips_err);
ERR_
ERR_
return 0;
}
Should report an error message.
[ Regression potential ]
Removing the fips patches should decrease regression potential of openssl in the main archive.
| description: | updated |
| description: | updated |
| Marc Deslauriers (mdeslaur) wrote | #1 |
| Changed in openssl (Ubuntu Yakkety): | |
| status: | New → Fix Committed |
| Changed in openssl (Ubuntu Xenial): | |
| status: | New → Confirmed |
| assignee: | nobody → Marc Deslauriers (mdeslaur) |
| Marc Deslauriers (mdeslaur) wrote | #2 |
| Changed in openssl (Ubuntu Yakkety): | |
| status: | Fix Committed → Fix Released |
| Changed in openssl (Ubuntu Xenial): | |
| status: | Confirmed → In Progress |
| Chris J Arges (arges) wrote Please test proposed package | #3 |
| Changed in openssl (Ubuntu Xenial): | |
| status: | In Progress → Fix Committed |
| tags: | added: verification-needed |
| Ken Baker (bakerkj) wrote | #4 |
| tags: |
added: verification-done removed: verification-needed |
| Launchpad Janitor (janitor) wrote | #5 |
| Changed in openssl (Ubuntu Xenial): | |
| status: | Fix Committed → Fix Released |
There's an openssl package already in xenial-proposed. Once that gets published, I'll upload a fixed package for this bug for processing by the SRU team.