NotShowIn and OnlyShowIn in .desktop files are ignored
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-app-launch (Ubuntu) |
Fix Released
|
High
|
Ted Gould |
Bug Description
Applications with .desktop file containing NotShowIn=Unity or OnlyShowIn=/!Unity/ should be treated as Hidden. This affects libertine, as some applications with these properties are currently shown resulting in unlaunchable applications (#1606593). There are certainly many more libertine applications which will be affected by this and cause the users to see unlaunchable apps.
This bug can be traced directly to the workaround in the Desktop constructor in application-
I discussed with @ted why this has yet to be undone and have included the chat log:
<ted> larryprice: So the issue is that design doesn't want the media player to show up in the list of applications.
<ted> larryprice: But they do want users to be able to play media files and have them show up.
<ted> larryprice: The proper way to do that is to have a trusted prompt overlay that plays the video.
<ted> larryprice: But... the trusted prompt overlays basically allow you to take over the application, and you can't remove them.
<ted> larryprice: So if something like the media player (or something else) was to hang or crash you'd lose access to your app.
<ted> larryprice: Thus we need some way for Unity8 to allow closing the trusted prompt overlay.
<ted> larryprice: In the mean time, we're making media player an app, but just marking its desktop files incorrectly to cause the application grid to invalidate it.
<ted> larryprice: Since UAL didn't check that before when launching, it worked, and we've become dependent on that working.
<larryprice> ted, geez louise
<ted> In general, the U8 team has said they will fix this, but eh, it's been a while that I've pinged them on it. I don't think they've fixed it yet.
Related branches
- Charles Kerr (community): Approve
- unity-api-1-bot: Needs Fixing (continuous-integration)
- Lukáš Tinkl (community): Needs Fixing
- Iain Lane: Pending requested
- Larry Price: Pending requested
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 193 lines (+94/-16)2 files modifiedlibubuntu-app-launch/application-info-desktop.cpp (+49/-5)
tests/application-info-desktop.cpp (+45/-11)
- Iain Lane: Needs Fixing
- unity-api-1-bot: Needs Fixing (continuous-integration)
- Larry Price: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 34 lines (+1/-5)2 files modifiedlibubuntu-app-launch/application-info-desktop.cpp (+1/-2)
tests/application-info-desktop.cpp (+0/-3)
Changed in ubuntu-app-launch (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in ubuntu-app-launch (Ubuntu): | |
status: | Confirmed → In Progress |
assignee: | nobody → Ted Gould (ted) |
This bug was fixed in the package ubuntu-app-launch - 0.9+17. 04.20170113. 1-0ubuntu1
--------------- 04.20170113. 1-0ubuntu1) zesty; urgency=medium
ubuntu-app-launch (0.9+17.
[ Pete Woods ]
* Compatibility with unversioned cmake-extras modules (LP: #1563573)
[ Rodney Dawes ]
* Handle more common Icon entries in .desktop files for snaps. (LP:
#1639952)
[ Ted Gould ]
* Fixes to the exec-util test to ensure it is more reliable
* Reenable OnlyShowIn checking for Desktop files (LP: #1580092,
#1606593, #1608546)
-- Ted Gould <email address hidden> Fri, 13 Jan 2017 22:16:18 +0000