Core library can not be imported via client if Glare used as backend

Bug #1608440 reported by Victor Ryzhenkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-muranoclient
Fix Released
Critical
Alexander Tivelkov

Bug Description

HOW TO REPRODUCE:
1. Deploy devstack (or use master murano)
2. Explore devstack logs or navigate to murano dashboard to the package manage page

Expected:
Core library is imported correctly

Actual:
There is no core library at all

INFO:

stack@srv66-bud:/opt/stack/python-muranoclient$ cd /opt/stack/murano/meta/io.murano/
stack@srv66-bud:/opt/stack/murano/meta/io.murano$ murano -d package-import io.murano.zip
REQ: curl -g -i -X GET http://172.18.162.71:5000/v2.0 -H "Accept: application/json" -H "User-Agent: python-keystoneclient"
Starting new HTTP connection (1): 172.18.162.71
"GET /v2.0 HTTP/1.1" 200 343
RESP: [200] Date: Mon, 01 Aug 2016 09:37:01 GMT Server: Apache/2.4.7 (Ubuntu) Vary: X-Auth-Token x-openstack-request-id: req-be91633a-ee30-4d5f-8c31-9f721a34783d Content-Length: 343 Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Content-Type: application/json
RESP BODY: {"version": {"status": "stable", "updated": "2014-04-17T00:00:00Z", "media-types": [{"base": "application/json", "type": "application/vnd.openstack.identity-v2.0+json"}], "id": "v2.0", "links": [{"href": "http://172.18.162.71/identity/v2.0/", "rel": "self"}, {"href": "http://docs.openstack.org/", "type": "text/html", "rel": "describedby"}]}}

REQ: curl -g -i -X GET http://172.18.162.71:5000/v2.0 -H "Accept: application/json" -H "User-Agent: python-keystoneclient"
"GET /v2.0 HTTP/1.1" 200 343
RESP: [200] Date: Mon, 01 Aug 2016 09:37:01 GMT Server: Apache/2.4.7 (Ubuntu) Vary: X-Auth-Token x-openstack-request-id: req-3c66b9b1-60c6-4d69-9f8e-10b7cefeca40 Content-Length: 343 Keep-Alive: timeout=5, max=99 Connection: Keep-Alive Content-Type: application/json
RESP BODY: {"version": {"status": "stable", "updated": "2014-04-17T00:00:00Z", "media-types": [{"base": "application/json", "type": "application/vnd.openstack.identity-v2.0+json"}], "id": "v2.0", "links": [{"href": "http://172.18.162.71/identity/v2.0/", "rel": "self"}, {"href": "http://docs.openstack.org/", "type": "text/html", "rel": "describedby"}]}}

Making authentication request to http://172.18.162.71/identity/v2.0/tokens
Starting new HTTP connection (1): 172.18.162.71
"POST /identity/v2.0/tokens HTTP/1.1" 200 5013
Importing package io.murano
Error expected a single document in the stream
  in "Classes/test/TestFixture.yaml", line 13, column 1
but found another document
  in "Classes/test/TestFixture.yaml", line 18, column 1 occurred while installing package io.murano

Changed in python-muranoclient:
milestone: none → 0.9.1
importance: Undecided → Critical
status: New → Confirmed
Changed in python-muranoclient:
assignee: nobody → Alexander Tivelkov (ativelkov)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-muranoclient (master)

Reviewed: https://review.openstack.org/349452
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=98adda6a46fd5d2032077758de1d72cefe4ef55c
Submitter: Jenkins
Branch: master

commit 98adda6a46fd5d2032077758de1d72cefe4ef55c
Author: Alexander Tivelkov <email address hidden>
Date: Mon Aug 1 14:04:35 2016 +0300

    Support for multi-class yamls in client

    MuranoClient needs to analyse package classes (names and inheritance
    chains) to properly add packages to Glare. This requires it to
    properly resolve class names in the appropriate namespaces.

    Since Mitaka Murano supports multi-class yamls, i.e. yaml files
    containing multiple MuranoPL classes in a single yaml file using it
    multi-document format. Optionally this allows to reuse a single
    namespace definition for multiple classes defined in the same file.

    Client was not aware of this feature, always loading classes as
    single-document yamls. It was also always using the current-class
    namespace definitions, thus likely to fail if the shared namespace
    definition is in use.

    This has been addressed.

    Closes-bug: #1608440
    Change-Id: Ibd08454f71e0266c76a2ac517b441df97311d8b9

Changed in python-muranoclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-muranoclient (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/352015

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-muranoclient (stable/mitaka)

Reviewed: https://review.openstack.org/352015
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=56605d2740a4088631117cd44276f2b13c2a2a07
Submitter: Jenkins
Branch: stable/mitaka

commit 56605d2740a4088631117cd44276f2b13c2a2a07
Author: Alexander Tivelkov <email address hidden>
Date: Mon Aug 1 14:04:35 2016 +0300

    Support for multi-class yamls in client

    MuranoClient needs to analyse package classes (names and inheritance
    chains) to properly add packages to Glare. This requires it to
    properly resolve class names in the appropriate namespaces.

    Since Mitaka Murano supports multi-class yamls, i.e. yaml files
    containing multiple MuranoPL classes in a single yaml file using it
    multi-document format. Optionally this allows to reuse a single
    namespace definition for multiple classes defined in the same file.

    Client was not aware of this feature, always loading classes as
    single-document yamls. It was also always using the current-class
    namespace definitions, thus likely to fail if the shared namespace
    definition is in use.

    This has been addressed.

    Closes-bug: #1608440
    Change-Id: Ibd08454f71e0266c76a2ac517b441df97311d8b9
    (cherry picked from commit 98adda6a46fd5d2032077758de1d72cefe4ef55c)

tags: added: in-stable-mitaka
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-muranoclient 0.10.0

This issue was fixed in the openstack/python-muranoclient 0.10.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-muranoclient 0.8.6

This issue was fixed in the openstack/python-muranoclient 0.8.6 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

This issue was fixed in the openstack/python-muranoclient 0.8.6 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/python-muranoclient 0.8.6 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.