neutron-linuxbridge-cleanup.service uses wrong config file

Hi Paul,

Thanks for reporting this bug. This looks to be a valid bug and I'll work on a fix for this. Adding some triage below for now.

Looking at an install of the neutron-linuxbridge-agent package, /etc/neutron/plugins/ml2/linuxbridge_agent.ini includes the following section:

[linux_bridge]

#
# From neutron.ml2.linuxbridge.agent
#

# Comma-separated list of <physical_network>:<physical_interface> tuples
# mapping physical network names to the agent's node-specific physical network
# interfaces to be used for flat and VLAN networks. All physical networks
# listed in network_vlan_ranges on the server should have mappings to
# appropriate interfaces on each agent. (list value)
#physical_interface_mappings =

# List of <physical_network>:<physical_bridge> (list value)
#bridge_mappings =

And the linuxbridge cleanup code does indeed access options such as physical_interface_mappings and bridge_mappings:

https://github.com/openstack/neutron/blob/master/neutron/cmd/linuxbridge_cleanup.py#L31
https://github.com/openstack/neutron/blob/master/neutron/cmd/linuxbridge_cleanup.py#L39

Hi Paul, I've uploaded a fix for this to Yakkety for Newton. If you can test this out that would be helpful. Then we can get it backported to Xenial for Mitaka.

Hello Paul, or anyone else affected,

Accepted neutron into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/neutron/2:8.2.0-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Paul, or anyone else affected,

Accepted neutron into mitaka-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:mitaka-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-mitaka-needed to verification-mitaka-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-mitaka-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Sorry I lost track of this issue.

Thanks for the fix! Works quite well in Xenial. Sadly I don't have a test environment for Yakkety/Newton.

OT: The systemd service file is still broken so if the bug fix of this issue could also make it into Xenial/Mitaka it would be great (https://bugs.launchpad.net/ubuntu/+source/neutron/+bug/1606652).

Package: neutron-linuxbridge-agent
Status: install ok installed
Priority: optional
Section: net
Installed-Size: 70
Maintainer: Ubuntu Developers <email address hidden>
Architecture: all
Source: neutron
Version: 2:8.2.0-0ubuntu1
Replaces: neutron-plugin-linuxbridge-agent (<< 2:8.0.0~b2-0ubuntu5~), neutron-plugin-ml2 (<< 2:8.0.0~b2-0ubuntu5~)
Depends: bridge-utils, conntrack, ebtables, neutron-common (= 2:8.2.0-0ubuntu1), init-system-helpers (>= 1.18~), lsb-base (>= 4.1+Debian11ubuntu7), python:any (>= 2.6~)
Breaks: neutron-plugin-linuxbirdge-agent (<< 2:8.0.0~b2-0ubuntu5~), neutron-plugin-ml2 (<< 2:8.0.0~b2-0ubuntu5~)
Conffiles:
 /etc/init.d/neutron-linuxbridge-agent b993463eb7dcb574d7c6d5a7a5931224
 /etc/init.d/neutron-linuxbridge-cleanup 1892e7a1145726ecf73369f21699cc98
 /etc/init/neutron-linuxbridge-agent.conf 7a738029b4ca0ccadbeb91668dfd4fe6
 /etc/init/neutron-linuxbridge-cleanup.conf 993e8d3493e6c57a2816ecd9d344bf6f
 /etc/neutron/plugins/ml2/linuxbridge_agent.ini f0ac6bd37d0ed9ec2345c680e0572028
 /etc/neutron/rootwrap.d/linuxbridge-plugin.filters 2d4f6cc194e9039d14b992130148b3a7
Description: Neutron is a virtual network service for Openstack - linuxbridge agent
 Neutron is a virtual network service for Openstack, and a part of
 Netstack. Just like OpenStack Nova provides an API to dynamically
 request and configure virtual servers, Neutron provides an API to
 dynamically request and configure virtual networks. These networks
 connect "interfaces" from other OpenStack services (e.g., virtual NICs
 from Nova VMs). The Neutron API supports extensions to provide
 advanced network capabilities (e.g., QoS, ACLs, network monitoring,
 etc.)
 .
 This package provides the linuxbridge plugin agent.
Original-Maintainer: Chuck Short <email address hidden>

I've also regression tested the mitaka UCA proposed pocket successfully.

This bug was fixed in the package neutron - 2:8.2.0-0ubuntu1

---------------
neutron (2:8.2.0-0ubuntu1) xenial; urgency=medium

  [ Corey Bryant ]
  * New upstream version.
  * d/p/skip-test-secure-client.patch: Skip test_secure_client until
    upstream bug is resolved.

  [ James Page ]
  * New upstream version.
  * d/p/skip-ryu-tests.patch: Rebased.

  [ Corey Bryant ]
  * d/neutron-linuxbridge-agent.neutron-linuxbridge-cleanup.init.in:
    Run neutron-linuxbridge-cleanup with linuxbridge_agent.ini (LP: #1606657).

  [ David Della Vecchia ]
  * New upstream stable point release for OpenStack Mitaka (LP: #1619318).
  * d/control: Align (build-)depends with upstream.

 -- David Della Vecchia <email address hidden> Tue, 27 Sep 2016 08:19:10 -0400

The verification of the Stable Release Update for neutron has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

The verification of the Stable Release Update for neutron has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package neutron - 2:8.2.0-0ubuntu1~cloud0
---------------

 neutron (2:8.2.0-0ubuntu1~cloud0) trusty-mitaka; urgency=medium
 .
   * New upstream release for the Ubuntu Cloud Archive.
 .
 neutron (2:8.2.0-0ubuntu1) xenial; urgency=medium
 .
   [ Corey Bryant ]
   * New upstream version.
   * d/p/skip-test-secure-client.patch: Skip test_secure_client until
     upstream bug is resolved.
 .
   [ James Page ]
   * New upstream version.
   * d/p/skip-ryu-tests.patch: Rebased.
 .
   [ Corey Bryant ]
   * d/neutron-linuxbridge-agent.neutron-linuxbridge-cleanup.init.in:
     Run neutron-linuxbridge-cleanup with linuxbridge_agent.ini (LP: #1606657).
 .
   [ David Della Vecchia ]
   * New upstream stable point release for OpenStack Mitaka (LP: #1619318).
   * d/control: Align (build-)depends with upstream.