iscsitarget kernel module compile fails in event.c:98

I'm sorry. Running Gutsy:

root@xen1:/usr/src# uname -a
Linux xen1 2.6.22-14-xen #1 SMP Sun Oct 14 23:20:20 GMT 2007 x86_64 GNU/Linux

Fixes attached. Also includes fixes for Bug #160106

This issue should not be fixed in the same way in hardy, as the kernel is expected to be updated, causing symptoms similar to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=449237. Separately, it is expected that the Debian sync process will soon pull 0.4.15-4, therefore introducing the same issue (with the opposite solution) into hardy once the kernel is updated.

I've unsubscribed ubuntu-universe-sponsors, as the candidate debdiff does not match the requirements for a stable release update, and there is no "TEST CASE" section in the description (please see https://wiki.ubuntu.com/StableReleaseUpdates). Also, when updating a stable release, please only include a minimal diff to address critical issues. Thirdly, the changelog mentions that it fixes a problem in feisty, but I don't find any references to problems with 2.6.20, just with 2.6.22 and 2.6.23. Has this been tested in feisty, and shown to be addressed by the same fix? Please resubscribe ubuntu-universe-sponsors when an updated candidate revision is available.

Thanks Emmet.

For the purposes of staying on top of the issue... What is the target
kernel version for hardy?

As hardy is slated to be an LTS release, I am very interested that
these bugs are fixed by the time hardy releases.

iscsitarget is a service which has a lot of usefulness in Production scenarios.

Best regards,
- alvinc

With guidance from Emmet, work on evaluating the impact of this bug is proceeding.

I configuring dapper and feisty environments, and constructing FAI classes and nfsroot for edgy (as the edgy ISO images are no longer available in any of the mirrors which I have checked).

More status will be added this weekend.

Thanks for your work, Alvin, on this bug. For now it seems to not be a backport but rather a StableReleaseUpdate.

I have FAI'd an edgy system and done a CD install of a dapper system.

iscsitarget is not present in either release, nor is it listed in any of the repositories (updates, security, backports, commercial).

Would this then qualify as a backport?

Best regards,
- alvinc

A backport could be requested for iscsitools, but it seems a fair amount of effort considering that most users will be expected to be on either gutsy or hardy fairly soon, and it may require significant effort to follow the differences in the kernel API. I'd suggest working to get gutsy updated with the SRU, and then looking forward to hardy as a solution for all users.

I'm being bitten by this too. What's the proper way to patch iscsitarget-source so that module-assistant can build it?
Thanks.

Hi Brendan,

Further up in this bug, I attached a diff of event.c. Changing line
98 of event.c in accordance with the diff will do the trick.

This will be fixed in the future, I'm working that out now (learning
pbuilder and experimenting with doing things properly). But if you're
in patient, you can try to fix it the same way I have.

Procedurally, the following:

# apt-get install iscsitarget-source
# cd /usr/src
# tar jxvf iscsitarget.tar.bz2
# vi modules/iscsitarget-module/kernel/event.c
<make the change to line 98>
# mv iscsitarget.tar.bz2 iscsitarget.tar.bz2.ORIG
# tar jcvf iscsitarget.tar.bz2 modules/

After this, module assistant will work.

# m-a a-i iscsitarget

Best regards,
- alvinc

On Sunday, 25 November 2007 at 10:51, Alvin Cura wrote:
> Hi Brendan,
>
> Further up in this bug, I attached a diff of event.c. Changing line
> 98 of event.c in accordance with the diff will do the trick.
>
> This will be fixed in the future, I'm working that out now (learning
> pbuilder and experimenting with doing things properly). But if you're
> in patient, you can try to fix it the same way I have.
>
> Procedurally, the following:
>
> # apt-get install iscsitarget-source
> # cd /usr/src
> # tar jxvf iscsitarget.tar.bz2
> # vi modules/iscsitarget-module/kernel/event.c
> <make the change to line 98>
> # mv iscsitarget.tar.bz2 iscsitarget.tar.bz2.ORIG
> # tar jcvf iscsitarget.tar.bz2 modules/
>
> After this, module assistant will work.
>
> # m-a a-i iscsitarget

Thank you, this worked fine!

Fixes are attached.

Fixes for Bug #160106 are included in the diff. I put in a control structure to check for kernel version as well.

Cheers,
- alvinc

I really don't see the point in fixing this in hardy, as kernel 2.6.24 is in the archives (which doesn't expose this bug). On the other hand, I believe this is likely a valid SRU, but there are a few outstanding issues:

1) For an SRU, the version should be something like 0.4.15-2.1 rather than 0.4.15.3
2) It would be a lot easier to review a debdiff than the diff.gz. You can generate this with "debdiff orig.dsc new.dsc"
3) Please just s/==/=/ in initd.debian, rather than adding initd.ubuntu: it's hard to see the change easily (this also allows you to drop the Makefile changes, making the diff even smaller)
4) Please update the bug description to contain a clear test case (for both 160104 and 160106), and subscribe ~motu-sru for approval for the stable release update.
5) Once you've received approval from ~motu-sru, if it is still not uploaded, resubscribe ubuntu-universe-sponsors to request upload.

I'm closing the main task for this bug leaving the Gutsy task open as somebody still needs to get this worked up for an SRU.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

It would be my honour to work on the SRU of this bug. Alas, I
have not looked at it in a while, and it will take me a little bit of
time to review the documentation which Emmet referred me to at the
beginning.

I expect to look at it this weekend (US time)

- - alvinc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: http://getfiregpg.org

iEYEARECAAYFAkiZPEoACgkQSkZVoNjHaTzaOgCgpe7g23x9hgAxTt1rzcWKQ4e5
O8AAoMbppI5ytH5UAHrrbIE4dr535E7c
=w2PP
-----END PGP SIGNATURE-----

The 18 month support period for Gutsy Gibbon 7.10 has reached its end of life -
http://www.ubuntu.com/news/ubuntu-7.10-eol . As a result, we are closing the
Gutsy task.