Ubuntu
unity8 package

brightness not changing from either u-s-s or hardkey on unity8-desktop

Bug #1595947 reported by kevin gunn
38
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Michał Sawicz
Canonical System Image p1 "Ubuntu Personal"
Mir
Invalid
Undecided
Unassigned
unity8-desktop-session
Fix Released
High
Unassigned
mir (Ubuntu)
Invalid
High
Unassigned
repowerd (Ubuntu)
Fix Released
High
Alexandros Frantzis
unity-system-compositor (Ubuntu)
Invalid
High
Unassigned
unity8 (Ubuntu)
Fix Released
High
Lukáš Tinkl
unity8-desktop-session (Ubuntu)
Fix Released
High
Unassigned

Bug Description

Running unity8-desktop session on my macbookpro which has a hard display brightness key, currently it makes no effect. Also, opened ubuntu-sytstem-settings and changing the brightness slider also makes no effect.
sorry for spamming projects, not sure which to log against.

Related branches

lp:~lukas-kde/unity8/brightnessControl
Michael Zanetti (community): Approve
Unity8 CI Bot: Approve (continuous-integration)
Diff: 92 lines (+57/-5)
3 files modified
plugins/Unity/Indicators/indicatorsmanager.cpp (+1/-4)
qml/Components/BrightnessControl.qml (+54/-0)
qml/Shell.qml (+2/-1)
~afrantzis/repowerd:session-support
Repowerd CI Bot: Approve (continuous-integration)
Repowerd development team: Pending requested
Diff: 6397 lines (+3763/-422)
61 files modified
CMakeLists.txt (+1/-1)
debian/changelog (+9/-0)
debian/repowerd.service (+0/-1)
src/adapters/CMakeLists.txt (+1/-0)
src/adapters/android_device_quirks.cpp (+16/-1)
src/adapters/android_device_quirks.h (+2/-0)
src/adapters/device_quirks.h (+1/-0)
src/adapters/logind_session_tracker.cpp (+477/-0)
src/adapters/logind_session_tracker.h (+98/-0)
src/adapters/unity_screen_service.cpp (+96/-55)
src/adapters/unity_screen_service.h (+12/-9)
src/core/CMakeLists.txt (+2/-0)
src/core/alarm_id.h (+16/-3)
src/core/client_requests.h (+9/-6)
src/core/daemon.cpp (+235/-46)
src/core/daemon.h (+35/-3)
src/core/daemon_config.h (+4/-2)
src/core/default_state_machine.cpp (+86/-4)
src/core/default_state_machine.h (+15/-1)
src/core/default_state_machine_factory.cpp (+32/-0)
src/core/default_state_machine_factory.h (+37/-0)
src/core/notification_service.h (+8/-5)
src/core/null_state_machine.h (+63/-0)
src/core/session_tracker.h (+53/-0)
src/core/state_event_adapter.cpp (+58/-0)
src/core/state_event_adapter.h (+44/-0)
src/core/state_machine.h (+6/-0)
src/core/state_machine_factory.h (+41/-0)
src/default_daemon_config.cpp (+19/-6)
src/default_daemon_config.h (+4/-2)
src/tools/CMakeLists.txt (+14/-0)
src/tools/session_tool.cpp (+54/-0)
tests/adapter-tests/CMakeLists.txt (+3/-0)
tests/adapter-tests/fake_device_quirks.cpp (+12/-1)
tests/adapter-tests/fake_device_quirks.h (+3/-0)
tests/adapter-tests/fake_logind.cpp (+322/-0)
tests/adapter-tests/fake_logind.h (+77/-0)
tests/adapter-tests/test_android_device_quirks.cpp (+63/-0)
tests/adapter-tests/test_logind_session_tracker.cpp (+408/-0)
tests/adapter-tests/test_unity_screen_service.cpp (+130/-110)
tests/core-tests/CMakeLists.txt (+4/-0)
tests/core-tests/acceptance_test.cpp (+94/-13)
tests/core-tests/acceptance_test.h (+24/-4)
tests/core-tests/daemon_config.cpp (+20/-6)
tests/core-tests/daemon_config.h (+6/-2)
tests/core-tests/default_pid.h (+31/-0)
tests/core-tests/fake_client_requests.cpp (+35/-26)
tests/core-tests/fake_client_requests.h (+7/-6)
tests/core-tests/fake_notification_service.cpp (+13/-13)
tests/core-tests/fake_notification_service.h (+8/-8)
tests/core-tests/fake_session_tracker.cpp (+103/-0)
tests/core-tests/fake_session_tracker.h (+78/-0)
tests/core-tests/run_daemon.cpp (+34/-0)
tests/core-tests/run_daemon.h (+31/-0)
tests/core-tests/test_client_requests.cpp (+77/-1)
tests/core-tests/test_daemon.cpp (+251/-56)
tests/core-tests/test_notification.cpp (+54/-27)
tests/core-tests/test_session.cpp (+322/-0)
tests/core-tests/test_turn_on_display_at_startup.cpp (+2/-2)
tests/core-tests/test_user_activity.cpp (+2/-2)
tests/core-tests/test_voice_call.cpp (+1/-0)
kevin gunn (kgunn72)
Changed in unity-system-compositor (Ubuntu):
importance: Undecided → High
Changed in mir (Ubuntu):
importance: Undecided → High
Changed in unity8 (Ubuntu):
importance: Undecided → High
tags: added: unity8-desktop
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in mir (Ubuntu):
status: New → Confirmed
Changed in unity-system-compositor (Ubuntu):
status: New → Confirmed
Changed in unity8 (Ubuntu):
status: New → Confirmed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Backlight brightness technically is nothing to do with Mir right now. Although there's a good argument that we should make it Mir's responsibility.

To see what kind of mess it is, install mir-utils and then: $ cat /usr/bin/mirbacklight

I believe alf copied that script when he re-implemented backlight support in USC (?)

Changed in mir:
status: New → Incomplete
Changed in mir (Ubuntu):
status: Confirmed → Incomplete
Lukáš Tinkl (lukas-kde)
Changed in unity8 (Ubuntu):
assignee: nobody → Lukáš Tinkl (lukas-kde)
Lukáš Tinkl (lukas-kde)
Changed in unity8 (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in repowerd (Ubuntu):
status: New → Confirmed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Invalid for Mir: Mir is not related to backlight brightness control.

Invalid for repowerd: Not running at all under Unity8 desktop.

Changed in mir:
status: Incomplete → Invalid
Changed in mir (Ubuntu):
status: Incomplete → Invalid
Changed in repowerd (Ubuntu):
status: Confirmed → Invalid
Changed in canonical-devices-system-image:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Michał Sawicz (saviq) wrote :

Repowerd is meant to be running on the desktop, Alexandros and Lukas are working on it. It's only disabled today because of bad interactions with other sessions.

Changed in repowerd (Ubuntu):
status: Invalid → Won't Fix
status: Won't Fix → Confirmed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Oh that's usual. Sounds like the bug is in a component that's not actually running. The bug *is* that the component isn't running.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Oh that's *unusual*

Daniel van Vugt (vanvugt)
Changed in repowerd (Ubuntu):
importance: Undecided → High
Changed in unity8-desktop-session (Ubuntu):
status: New → Confirmed
importance: Undecided → High
Changed in unity8-desktop-session:
status: New → Confirmed
importance: Undecided → High
Lukáš Tinkl (lukas-kde)
Changed in repowerd (Ubuntu):
assignee: nobody → Alexandros Frantzis (afrantzis)
Lukáš Tinkl (lukas-kde)
Changed in repowerd (Ubuntu):
status: Confirmed → In Progress
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: none → p1
Lukáš Tinkl (lukas-kde)
Changed in repowerd (Ubuntu):
status: In Progress → Fix Committed
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
assignee: nobody → Michał Sawicz (saviq)
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.15+17.04.20161129-0ubuntu1

---------------
unity8 (8.15+17.04.20161129-0ubuntu1) zesty; urgency=medium

  [ Albert Astals Cid ]
  * Fix PreviewProgress implicitHeight (LP: #1641943)
  * Adapt to dummy notification being gone
  * Fix autopilot test_lock_screen tests
  * Autopilot: Add more applications to the list for wider screens
  * Fix autopilot DashHelperTestCase.test_search
  * Also install the Screens mock
  * Give default value to gu-px size

  [ Andrea Azzarone ]
  * Set Mir.cursorName to "grabbing" on first mouse press on a window
    decoration. Don't wait for press+motion. (LP: #1618078)
  * Do not show a divider between each quicklist entry but just between
    each section, similar to how unity7 does. (LP: #1637478)

  [ Andrea Cimitan ]
  * Fix white text (LP: #1644468)
  * Make MascotLoader in CardCreator flat
  * Make the remaining UbuntuShape flat
  * added dropshadow from panel indicators to dash page header extra
    panel, so there is right shadow when the extra panel is narrow
  * Look up for expandable template dash category flag

  [ Brian Douglass ]
  * Added a setting to enable/disable the indicator dropdown menu.

  [ Daniel d'Andrada ]
  * There's no need for WindowDecoration to access the appDelegate

  [ Lukáš Tinkl ]
  * Enable brightness (laptop backlight) handling on desktop/laptop PCs
    (LP: #1595947)

  [ Michael Zanetti ]
  * disable spread interaction while locked (LP: #1641578)

  [ Andrea Azzarone, Michał Sawicz ]
  * Implement launcher tooltips.

  [ Olivier Tilloy ]
  * Remove dependency on transitional package. (LP: #1583079)

 -- Michał Sawicz <email address hidden> Tue, 29 Nov 2016 09:43:33 +0000

Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
Lukáš Tinkl (lukas-kde)
Changed in unity8-desktop-session:
status: Confirmed → Fix Released
Changed in unity8-desktop-session (Ubuntu):
status: Confirmed → Fix Released
Changed in unity-system-compositor (Ubuntu):
status: Confirmed → Invalid
Alexandros Frantzis (afrantzis)
Changed in repowerd (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.