Libertine

libertine-lxc-manager should start on demand

Bug #1591350 reported by Stephen M. Webb
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Libertine
Status tracked in Devel
Devel
Fix Released
Medium
Christopher Townsend
Libertine 1.5
Trunk
Fix Released
Medium
Christopher Townsend
Libertine 1.5
libertine (Ubuntu)
Fix Released
Medium
Christopher Townsend

Bug Description

The libertine-launch tool should attempt to start the libertine-lxc-manager daemon once if it's not already running.

Related branches

lp:~townsend/libertine/lxc-manager-dbus
Larry Price: Approve
Libertine CI Bot: Approve (continuous-integration)
Diff: 359 lines (+123/-142)
6 files modified
data/CMakeLists.txt (+3/-1)
data/com.canonical.libertine.LxcManager.service (+3/-0)
data/libertine-lxc-manager.conf (+0/-13)
debian/python3-libertine-lxc.install (+1/-1)
python/libertine/LxcContainer.py (+10/-18)
tools/libertine-lxc-manager (+106/-109)
lp:~townsend/libertine/release-1.4.1
Larry Price: Approve
Diff: 1848 lines (+846/-451)
32 files modified
CMakeLists.txt (+1/-1)
data/CMakeLists.txt (+3/-1)
data/com.canonical.libertine.LxcManager.service (+3/-0)
data/libertine-lxc-manager.conf (+0/-13)
debian/changelog (+31/-0)
debian/control (+1/-1)
debian/libertine-tools.install (+0/-1)
debian/python3-libertine-lxc.install (+1/-1)
libertine/ContainerAppsList.cpp (+2/-7)
libertine/ContainerAppsList.h (+2/-1)
libertine/ContainerArchivesList.cpp (+2/-7)
libertine/ContainerArchivesList.h (+2/-1)
libertine/ContainerConfigList.cpp (+2/-2)
libertine/qml/ContainerOptionsDialog.qml (+3/-0)
libertine/qml/ContainersView.qml (+15/-9)
libertine/qml/WelcomeView.qml (+4/-3)
python/libertine/ChrootContainer.py (+4/-1)
python/libertine/ContainersConfig.py (+21/-2)
python/libertine/Libertine.py (+228/-18)
python/libertine/LxcContainer.py (+43/-24)
python/libertine/__init__.py (+13/-2)
python/libertine/utils.py (+27/-4)
tests/unit/CMakeLists.txt (+24/-0)
tests/unit/libertine_logger_tests.py (+49/-0)
tests/unit/libertine_session_bridge_tests.py (+106/-0)
tests/unit/libertine_socket_tests.py (+72/-0)
tools/CMakeLists.txt (+2/-2)
tools/libertine-container-manager (+15/-14)
tools/libertine-launch (+64/-9)
tools/libertine-lxc-manager (+106/-109)
tools/libertine-session-bridge (+0/-205)
tools/libertine-session-bridge.1 (+0/-13)
lp:~ci-train-bot/libertine/libertine-ubuntu-yakkety-landing-1947 (Merged)
Revision history for this message
Christopher Townsend (townsend) wrote :

This may not be possible since if we launch libertine-lxc-manager from libertine-launch, then it belong in the cgroup of that particular launched application and not be accessible by other attempted launches. Let alone that the process will get killed when that cgroup get torn down.

That said, I'll investigate to see if there is some way to launch it on demand via some other method.

Christopher Townsend (townsend)
Changed in libertine:
milestone: 1.3 → 1.4
Revision history for this message
Christopher Townsend (townsend) wrote :

The solution is to port over libertine-lxc-manager to be a DBus service and activate it when needed.

Changed in libertine (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Libertine CI Bot (libertine-ci-bot) wrote :

Fix committed into lp:libertine at revision 290, scheduled for release in libertine, milestone Unknown

Changed in libertine:
status: In Progress → Fix Committed
Christopher Townsend (townsend)
Changed in libertine (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Christopher Townsend (townsend)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libertine - 1.4.1+16.10.20160914-0ubuntu1

---------------
libertine (1.4.1+16.10.20160914-0ubuntu1) yakkety; urgency=medium

  [ Brandon Schaefer ]
  * Refactor the libertine-session-bus to be a class, so we will be on the
    same process and we can actually test LSB more then just running it and
    checking exit code.
  * Add a get_logger function to the libertine utils. This function will get
    the logger __libertiner_logger__ which will only be setup once, with one
    handler.

  [ Chris Townsend ]
  * Switch libertine-lxc-manager to be a DBus service and activate it on demand
    via DBus. (LP: #1591350)
  * Add check for special LIBERTINE_JENKAAS_TESTING environment variable for
    the smoke testing harness.
  * Bump version to 1.4.1.

  [ Larry Price ]
  * Return user to homepage when container has been destroyed from under them.
    (LP: #1604015)
  * Introduce a method in ContainersConfig to refresh the database depending
    on an md5 checksum.
  * Creating the first container moves user to ContainersView screen.
    (LP: #1615697)
  * Inject a ContainersConfig instance when creating containers.
  * Fix crash in ContainersConfig when getting host arch by using HostInfo
    object.
  * Create a signal to indicate that container creation has begun.

 -- Christopher Townsend <email address hidden> Wed, 14 Sep 2016 14:46:02 +0000

Changed in libertine (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.