MAAS

twisted's conch does not support ed25519 and ecdsa ssh public keys

Bug #1590081 reported by William
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Undecided
Gavin Panella
MAAS 2.0.0
twisted (Ubuntu)
Confirmed
Undecided
Unassigned

Bug Description

When adding public keys to a user account, ed25519 and ecdsa public keys are showing as not supported public key types; the UI presents "Invalid SSH public key" as feedback.

See original description

Related branches

lp:~allenap/maas/other-ssh-key-types--bug-1590081
Mike Pontillo (community): Approve
Diff: 463 lines (+354/-24)
8 files modified
src/maasserver/models/sshkey.py (+5/-17)
src/maasserver/models/tests/test_sshkey.py (+28/-7)
src/maasserver/tests/data/test_ecdsa256.pub (+1/-0)
src/maasserver/tests/data/test_ecdsa384.pub (+1/-0)
src/maasserver/tests/data/test_ecdsa521.pub (+1/-0)
src/maasserver/tests/data/test_ed25519.pub (+1/-0)
src/provisioningserver/utils/sshkey.py (+161/-0)
src/provisioningserver/utils/tests/test_sshkey.py (+156/-0)
lp:~allenap/maas/packaging.other-ssh-key-types--bug-1590081
Andres Rodriguez (community): Approve
Diff: 25 lines (+4/-0)
2 files modified
debian/changelog (+3/-0)
debian/control (+1/-0)
William (william-forsyth)
summary: when setting up ssh accounts for the key injection, allow specifying
- ed25519 public keys
+ ed25519 and ecdsa public keys
description: updated
description: updated
William (william-forsyth)
description: updated
Andres Rodriguez (andreserl)
Changed in maas:
milestone: none → 2.0.0
Christian Reis (kiko)
description: updated
Changed in maas:
milestone: 2.0.0 → 2.1.0
Revision history for this message
LaMont Jones (lamont) wrote : Re: when setting up ssh accounts for the key injection, allow specifying ed25519 and ecdsa public keys

In /usr/lib/python3/dist-packages/twisted/conch/ssh/keys.py, fromString does not support ed25519 and ecdsa keys.

affects: maas → twisted (Ubuntu)
Changed in twisted (Ubuntu):
milestone: 2.1.0 → none
affects: twisted (Ubuntu) → maas
Changed in maas:
milestone: none → 2.1.0
summary: - when setting up ssh accounts for the key injection, allow specifying
- ed25519 and ecdsa public keys
+ twisted's conch does not support ed25519 and ecdsa ssh public keys
Revision history for this message
LaMont Jones (lamont) wrote :

2016-06-08 13:01:15 [maasserver] ERROR: Invalid SSH public key
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/maasserver/models/sshkey.py", line 41, in validate_ssh_public_key
    key = Key.fromString(value.encode("utf-8"))
  File "/usr/lib/python3/dist-packages/twisted/conch/ssh/keys.py", line 118, in fromString
    raise BadKeyError('cannot guess the type of %r' % (data,))
twisted.conch.ssh.keys.BadKeyError: cannot guess the type of b'ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBKHbdCD8RGTwodwdKnfnd6xOBjRMsh9AL+FTeSst2T9IkEeMhKr/dEr7mzFdHzkS1XvdpYCxQxJ4R5Ik4HCONLM= lamont@tigernut'

Mike Pontillo (mpontillo)
Changed in twisted (Ubuntu):
status: New → Confirmed
Andres Rodriguez (andreserl)
Changed in maas:
status: New → Triaged
Revision history for this message
Matthias Klose (doko) wrote :

please forward this upstream

Gavin Panella (allenap)
Changed in maas:
status: Triaged → In Progress
assignee: nobody → Gavin Panella (allenap)
Mike Pontillo (mpontillo)
Changed in maas:
milestone: 2.1.0 → 2.0.0
MAAS Lander (maas-lander)
Changed in maas:
status: In Progress → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.