MAAS

[2.0b5] Can't force the import of images per Rack Controller

Bug #1583685 reported by Andres Rodriguez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Critical
Jeffrey C Jones
MAAS 2.0.0

Bug Description

Rack controller's page doens't have a way to force the import of images if for any reason they failed. MAAS needs to provide a way to force it.

Related branches

lp:~trapnine/maas/fix-1583685-force-import
Blake Rouse (community): Needs Fixing
Lee Trager (community): Approve
Andres Rodriguez (community): Needs Information
Diff: 614 lines (+191/-140)
11 files modified
src/maasserver/models/node.py (+13/-9)
src/maasserver/models/tests/test_node.py (+69/-112)
src/maasserver/node_action.py (+23/-0)
src/maasserver/static/js/angular/controllers/node_details.js (+26/-6)
src/maasserver/static/js/angular/controllers/node_details_networking.js (+1/-1)
src/maasserver/static/js/angular/controllers/tests/test_node_details.js (+18/-3)
src/maasserver/static/js/angular/controllers/tests/test_node_details_networking.js (+3/-3)
src/maasserver/static/partials/node-details.html (+5/-3)
src/maasserver/tests/test_node_action.py (+29/-0)
src/maasserver/websockets/handlers/controller.py (+2/-1)
src/maasserver/websockets/handlers/tests/test_general.py (+2/-2)
Andres Rodriguez (andreserl)
Changed in maas:
milestone: none → 2.0.0
importance: Undecided → Critical
Revision history for this message
Gavin Panella (allenap) wrote :

Can you explain the problem? Perhaps we can design MAAS so that it recovers automatically without needing "force" buttons.

Changed in maas:
status: New → Incomplete
Revision history for this message
Blake Rouse (blake-rouse) wrote :

The rack controller will retry again after importing fails that is already built in. The issue is more of the UI does not provide what the API allows. This call already exists over the API, we just need to add it to the UI as well.

Changed in maas:
status: Incomplete → Triaged
Revision history for this message
Gavin Panella (allenap) wrote :

The download service loops every 5 minutes, but only downloads if the maas.meta file is at least 15 minutes old. Looping more frequently is therefore quite cheap; changing this to 60 seconds, say, would allow the rack to recover from a transient failure faster than anyone is likely to notice and be able to click the "force" button.

Revision history for this message
Gavin Panella (allenap) wrote :

[Pressed "Post Comment" too soon.]

I think that would be a better experience for users, and it would mean we could omit the "force" button from the UI and remove the call from the Web API. Fewer moving parts, less work to do, less code to maintain.

Newell Jensen (newell-jensen)
summary: - [2.0b5] Can't force the import of images per Rack COntroller
+ [2.0b5] Can't force the import of images per Rack Controller
Jeffrey C Jones (trapnine)
Changed in maas:
assignee: nobody → Jeffrey C Jones (trapnine)
status: Triaged → In Progress
MAAS Lander (maas-lander)
Changed in maas:
status: In Progress → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.