Missing Page.header in APL should cause message or color change

Bug #1583636 reported by Cris Dywan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Unassigned
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Tim Peeters

Bug Description

AdaptivePageLayout still supports legacy Page's from 1.2 times that don't specify a header. Eventually that's going to stop working.

addPageToCurrent/NextColumn should show a warning or otherwise visually highlight the header if no header is defined, so developers will know to update their code.

Related branches

Cris Dywan (kalikiana)
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Tim Peeters (tpeeters)
Revision history for this message
Tim Peeters (tpeeters) wrote :

I don't think we should print a warning, because it is valid to have a Page with no (null) header. It simply won't have a header, which is permitted.

Revision history for this message
Cris Dywan (kalikiana) wrote :

I renamed the bug and updated the description. We can still decide what exactly we'll do as long as something tells developers that they need to update their code.

summary: - addPageToCurrent/NextColumn should complain about missing header
+ Missing Page.header in APL should cause message or color change
description: updated
Revision history for this message
Tim Peeters (tpeeters) wrote :

If you mean to temporarily warn the developer (for example with a red border, which is shown until the fallback header is removed) that the behavior an app relies on is deprecated, I agree.

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Tim Peeters (tpeeters) wrote :

Note: this is temporary until we remove the subheader support completely, see https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1583587

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → In Progress
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Committed
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Fix Committed → Confirmed
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.2009+16.10.20160615.3

---------------
ubuntu-ui-toolkit (1.3.2009+16.10.20160615.3) yakkety; urgency=medium

  [ Tim Peeters ]
  * Introduce Styles.SectionsStyle. Fixes LP: #1585548
  * Update header contents only after its style was initialized.
    Fixes LP: #1588837
  * Update export_qml_dir.qml to work inside a lxd container.
  * Draw a red outline around the subheader in AdaptivePageLayout to warn that
    the old header is deprecated. Fixes LP: #1583636

  [ Christian Dywan ]
  * Select the current item before adding the test page.
  * Introduce gallery for browsing visual tests.
  * Put Scrollbar in ShaderEffectSource to blend with frame. Fixes LP: #1583543
  * Correctly use build/src dir with unit tests. Fixes LP: #1589982

  [ Florian Boucault ]
  * Do not initialize haptics at startup but only when used for the first time.
  * PageHeadButton: do not load the icon until the button is made visible.

  [ Albert Astals Cid ]
  * Prepend UC_ to performance env vars.
  * Using -1 as PERFORMANCE_MONITOR_WARNING_COUNT_THRESHOLD envvar disables the
    warning count threshold.
  * Add envvars to change the performance monitor variables.

 -- Zoltán Balogh <email address hidden> Wed, 15 Jun 2016 18:32:29 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Fix Committed → Fix Released
Changed in canonical-devices-system-image:
status: New → Fix Committed
importance: Undecided → High
milestone: none → 12
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.