MAAS

[2.0b4] Can attempt to commission enlisted nodes without chosen power type

Bug #1579215 reported by Newell Jensen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Medium
Newell Jensen
MAAS 2.0.0

Bug Description

After enlisting some VMs, I was able to select commissioning for them on the nodes list page as well as on the node detail page. This was allowed even though the power type and power parameters to power control the node where not entered and saved. This should not be allowed until the user selects a power type and the power parameters are saved so that MAAS knows how to power control the nodes.

Related branches

lp:~newell-jensen/maas/fix-1579215
Mike Pontillo (community): Approve
Diff: 46 lines (+14/-0)
3 files modified
src/maasserver/api/tests/test_enlistment.py (+1/-0)
src/maasserver/models/node.py (+6/-0)
src/maasserver/models/tests/test_node.py (+7/-0)
Newell Jensen (newell-jensen)
summary: - [2.0b4] Can commission enlisted nodes without chosen power type
+ [2.0b4] Can attempt to commission enlisted nodes without chosen power
+ type
Revision history for this message
Andres Rodriguez (andreserl) wrote :

If no power parameter is selected, I'm thinking that we should either assume 'manual' power parameter by default and show a message that no pwoer parameter was chosen. Or it should always default to manual if not set.

Changed in maas:
status: New → Triaged
milestone: none → 2.0.0
importance: Undecided → Medium
Revision history for this message
Newell Jensen (newell-jensen) wrote :

We currently display the message "This node does not have a power type set and MAAS will be unable to control it. Update the power information below." but we still allow it to try and commission. Just seems weird that we allow it to attempt commissioning and it doesn't fail commissioning unless it times out.

In terms of setting a default power type, I will bring this up in our daily meeting and see what the rest of the team thinks about this.

Newell Jensen (newell-jensen)
Changed in maas:
assignee: nobody → Newell Jensen (newell-jensen)
Revision history for this message
Mike Pontillo (mpontillo) wrote :

I don't think "Manual" should be the default. "Manual" means you're explicitly declaring there is no automatic power control. No power type at all is a red flag that means "you had better set this value or you won't be able to commission/deploy machines".

Revision history for this message
Newell Jensen (newell-jensen) wrote :

Mike,

I agree. As discussed, I think we will now raise an error when we try to commission when no power type is set for the node. In the error message we will mention to the user that if there are currently no power drivers in MAAS for their hardware, that they can use manual power driver.

MAAS Lander (maas-lander)
Changed in maas:
status: Triaged → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.