MAAS

[2.0b3] rack / region controllers are visible to non-admins

Bug #1576417 reported by LaMont Jones
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Critical
Jeffrey C Jones
MAAS 2.0.0

Bug Description

Based on our discussions in IRC today, neither rack nor region controllers should be visible to non-admin users.

1) remove the Controllers tab from the Node pages for non-admin
2) make them disappear in the APIs
3) fix all the tests.

Related branches

lp:~trapnine/maas/fix-1576417-controllers-admin-only
Jeffrey C Jones (community): Approve
Gavin Panella (community): Approve
Diff: 357 lines (+135/-12)
11 files modified
src/maasserver/api/rackcontrollers.py (+2/-0)
src/maasserver/api/tests/test_events.py (+2/-0)
src/maasserver/api/tests/test_rackcontroller.py (+33/-0)
src/maasserver/api/tests/test_regioncontroller.py (+1/-0)
src/maasserver/api/tests/test_tag.py (+42/-6)
src/maasserver/models/node.py (+8/-1)
src/maasserver/models/tests/test_node.py (+21/-0)
src/maasserver/static/js/angular/controllers/nodes_list.js (+5/-0)
src/maasserver/static/js/angular/controllers/tests/test_nodes_list.js (+16/-0)
src/maasserver/static/partials/nodes-list.html (+2/-2)
src/maasserver/websockets/handlers/tests/test_controller.py (+3/-3)
Revision history for this message
LaMont Jones (lamont) wrote :

There are XXX comments in the code in places that are currently testing for the wrong thing... search for "Bug#1576417".

Revision history for this message
Lee Trager (ltrager) wrote :

We should consider hiding the devices page to non-admin users as well. Non-admin users have no actions available to them.

Revision history for this message
Andres Rodriguez (andreserl) wrote : Re: [Bug 1576417] [NEW] rack controllers and region controllers should not be visible to non-admins

Actually, no, users should be able to add devices, request up addresses and
such.

On Friday, April 29, 2016, Lee Trager <email address hidden> wrote:

> We should consider hiding the devices page to non-admin users as well.
> Non-admin users have no actions available to them.
>
> --
> You received this bug notification because you are subscribed to MAAS.
> https://bugs.launchpad.net/bugs/1576417
>
> Title:
> rack controllers and region controllers should not be visible to non-
> admins
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/maas/+bug/1576417/+subscriptions
>

--
Andres Rodriguez (RoAkSoAx)
Ubuntu Server Developer
MSc. Telecom & Networking
Systems Engineer

Andres Rodriguez (andreserl)
summary: - rack controllers and region controllers should not be visible to non-
- admins
+ [2.0b3] rack / region controllers are visible to non-admins
Andres Rodriguez (andreserl)
Changed in maas:
milestone: none → 2.0.0
importance: Undecided → Critical
status: New → Triaged
Jeffrey C Jones (trapnine)
Changed in maas:
assignee: nobody → Jeffrey C Jones (trapnine)
status: Triaged → In Progress
MAAS Lander (maas-lander)
Changed in maas:
status: In Progress → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.