[2.0a4] When power_type changed to manual "power_state" was not set to "unknown"
Bug #1574003 reported by
Blake Rouse
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Critical
|
Newell Jensen | ||
Bug Description
I changed the "power_type" of a machine from "virsh" to "manual". The power_state showed on the node as "on" or previous what the other driver had. When changing to a power_type that doesn't support query we should clear the power_state.
I also tried to check the power of the machine when in the "manual" power state, this caused it to show up as "error", when it should have changed it to "unknown".
Related branches
lp:~newell-jensen/maas/fix-1574003
- Blake Rouse (community): Approve
-
Diff: 344 lines (+145/-62)9 files modifiedsrc/maasserver/models/node.py (+33/-2)
src/maasserver/models/tests/test_node.py (+53/-6)
src/provisioningserver/drivers/power/manual.py (+1/-0)
src/provisioningserver/drivers/power/tests/test_manual.py (+2/-1)
src/provisioningserver/power/query.py (+3/-9)
src/provisioningserver/power/tests/test_query.py (+0/-18)
src/provisioningserver/rpc/cluster.py (+1/-0)
src/provisioningserver/rpc/clusterservice.py (+4/-5)
src/provisioningserver/rpc/tests/test_clusterservice.py (+48/-21)
| Changed in maas: | |
| importance: | Medium → Critical |
| Changed in maas: | |
| assignee: | nobody → Newell Jensen (newell-jensen) |
| Changed in maas: | |
| status: | Triaged → In Progress |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
