Logic to detect if proot is on system uses hardcoded path
Bug #1572591 reported by
Christopher Townsend
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Libertine | Status tracked in Devel | |||||
| Devel |
Fix Released
|
Medium
|
Christopher Townsend | |||
| Trunk |
Fix Released
|
Medium
|
Christopher Townsend | |||
| libertine (Ubuntu) |
Fix Released
|
Medium
|
Christopher Townsend | |||
Bug Description
The logic to determine of proot is on the system uses a hardcoded path to /usr/bin. This does not play nice when trying to use libertine-launch in a snap. Need alternative way to check if proot is in the $PATH like which.
Related branches
lp:~townsend/libertine/fix-detect-proot
- Larry Price: Approve
- Libertine CI Bot: Approve (continuous-integration)
-
Diff: 25 lines (+4/-4)1 file modifiedpython/libertine/ChrootContainer.py (+4/-4)
lp:~townsend/libertine/1.0.1
- Stephen M. Webb (community): Approve
-
Diff: 1885 lines (+656/-378)22 files modifieddata/puritine-click.conf (+9/-4)
debian/changelog (+26/-0)
libertine/ContainerConfig.cpp (+2/-1)
libertine/ContainerConfig.h (+2/-2)
libertine/ContainerManager.cpp (+3/-3)
libertine/ContainerManager.h (+3/-3)
libertine/main.cpp (+8/-0)
libertine/qml/ContainerApps.qml (+0/-27)
libertine/qml/ContainerInfoView.qml (+1/-1)
libertine/qml/ContainersView.qml (+15/-9)
libertine/qml/ExtraArchivesView.qml (+26/-9)
libertine/qml/HomeView.qml (+32/-21)
libertine/qml/ManageContainer.qml (+53/-4)
libertine/qml/PackageInfoView.qml (+0/-34)
libertine/qml/PackageOperationFailureDialog.qml (+36/-0)
libertine/qml/SearchResultsView.qml (+2/-0)
libertine/qml/libertine.qml (+19/-1)
po/en_US.po (+89/-53)
po/libertine.pot (+200/-175)
python/libertine/ChrootContainer.py (+4/-4)
python/libertine/Libertine.py (+41/-15)
tools/libertine-container-manager (+85/-12)
| tags: | added: chroot |
| Changed in libertine (Ubuntu): | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
Revision history for this message
| Libertine CI Bot (libertine-ci-bot) wrote | #1 |
| Changed in libertine: | |
| status: | In Progress → Fix Committed |
| Changed in libertine (Ubuntu): | |
| status: | Triaged → In Progress |
| assignee: | nobody → Christopher Townsend (townsend) |
| Changed in libertine (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
Fix committed into lp:libertine at revision 207, scheduled for release in libertine, milestone Unknown