MAAS

devices results missing interface_set

Bug #1567213 reported by Tim Penhey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
High
Blake Rouse
MAAS 2.0.0
1.9
Fix Released
High
Blake Rouse
MAAS 1.9.2

Bug Description

/MAAS/api/2.0/devices/ does not include the interface_set

whereas

/MAAS/api/2.0/machines/ does.

Noticed when I added an interface to a device and then tried to work out where it appeared.

I know I can get it by listing /MAAS/api/2.0/nodes/{id}/interfaces/ but it would be nice if it came with the device structure.

Related branches

lp:~blake-rouse/maas/fix-1567213
Andres Rodriguez (community): Needs Fixing (missing changelog entry)
Mike Pontillo (community): Approve
Diff: 165 lines (+20/-23)
6 files modified
src/maasserver/api/devices.py (+16/-1)
src/maasserver/api/machines.py (+0/-2)
src/maasserver/api/nodes.py (+0/-8)
src/maasserver/api/tests/test_devices.py (+4/-2)
src/maasserver/api/tests/test_enlistment.py (+0/-2)
src/maasserver/api/tests/test_machines.py (+0/-8)
lp:~blake-rouse/maas/fix-1567213-1.9
Blake Rouse (community): Approve
Diff: 58 lines (+19/-0)
3 files modified
docs/changelog.rst (+2/-0)
src/maasserver/api/devices.py (+15/-0)
src/maasserver/api/tests/test_devices.py (+2/-0)
Revision history for this message
Mike Pontillo (mpontillo) wrote :

I noticed that (on 2.0/trunk) we have the following DISPLAYED_MACHINE_FIELDS in api/machines.py:

    ('interface_set', (
        'id',
        'name',
        'type',
        'vlan',
        'mac_address',
        'parents',
        'children',
        'tags',
        'enabled',
        'links',
        'params',
        'discovered',
        'effective_mtu',
        )),

In devices.py, we only have:

    'macaddress_set',

Prior to MAAS 1.9, macaddress_set would have been correct. It looks like when we moved to the new networking model in MAAS 1.9, we missed changing the displayed API fields for devices.

Changed in maas:
status: New → Triaged
importance: Undecided → High
milestone: none → 2.0.0
Blake Rouse (blake-rouse)
Changed in maas:
assignee: nobody → Blake Rouse (blake-rouse)
status: Triaged → In Progress
MAAS Lander (maas-lander)
Changed in maas:
status: In Progress → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.