Mir

ClientLogging.reports_performance fails under moderate load, is badly named

Bug #1563148 reported by Chris Halse Rogers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Low
Daniel van Vugt
Mir 0.22.0
mir (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Two problems:
1) The ClientLogging.reports_performance test is badly named, as it fails if performance is lower than expected. Leading to..
2) The ClientLogging.reports_performance uses real-time and spuriously fails on a moderately-loaded system.

See original description
Tags: testsfail

Related branches

lp:~vanvugt/mir/fix-1563148
Mir CI Bot: Approve (continuous-integration)
Alan Griffiths: Approve
Kevin DuBois (community): Approve
Diff: 10 lines (+0/-1)
1 file modified
tests/acceptance-tests/test_client_logging.cpp (+0/-1)
lp:~ci-train-bot/mir/mir-ubuntu-xenial-2736
Chris Halse Rogers (raof)
description: updated
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Please split these two concerns into separate bugs. They're very different issues.

Changed in mir:
status: New → Incomplete
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Also note we have a few other acceptance tests that have the same real-time sensitivity issue. It's not a matter of the tests needing fixing, because they're excellently realistic. Just a matter of we need to manage expectations and not run performance-sensitive tests under valgrind for example (which we already filter).

You know, on second thoughts I could probably fix both of these issues at once.

Changed in mir:
status: Incomplete → Triaged
importance: Undecided → Medium
assignee: nobody → Daniel van Vugt (vanvugt)
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.22.0
status: Triaged → In Progress
importance: Medium → Low
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Dropped to low. Test naming is not a severe problem, and failures while theoretically possible have not had any verified sightings.

Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.22.0

Changed in mir:
status: In Progress → Fix Committed
Alberto Aguirre (albaguirre)
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.22.1+16.04.20160516.2-0ubuntu2

---------------
mir (0.22.1+16.04.20160516.2-0ubuntu2) yakkety; urgency=medium

  [ Dimitri John Ledkov ]
  * Fix FTBFS error: call of overloaded ‘abs(float)’ is ambiguous, by
    including cmath c++ header.

 -- Łukasz 'sil2100' Zemczak <email address hidden> Thu, 19 May 2016 21:58:43 +0200

Changed in mir (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.