[2.0a4] Doesn't use modify over the OMAPI
Bug #1561991 reported by
Blake Rouse
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Blake Rouse | ||
Bug Description
At the moment when a host has been modified it will cause remove and then add to be called over the OMAPI. This is could cause a race where the machine DHCP get an address from the dynamic pool if it comes in between that operation. OMAPI supports modification and should be used.
This is also a problem with hosts with snippets as the snippet content will be removed in the remove call and not be added back with the add call.
Related branches
lp:~blake-rouse/maas/fix-1561991
- Gavin Panella (community): Approve
-
Diff: 213 lines (+123/-4)5 files modifiedsrc/provisioningserver/dhcp/omshell.py (+40/-0)
src/provisioningserver/dhcp/tests/test_omshell.py (+56/-0)
src/provisioningserver/rpc/dhcp.py (+17/-2)
src/provisioningserver/rpc/exceptions.py (+5/-0)
src/provisioningserver/rpc/tests/test_dhcp.py (+5/-2)
| Changed in maas: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Blake Rouse (blake-rouse) |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
