NBS never uses mc::MultiMonitorMode::single_monitor_fast, even when only a single monitor is plugged in
Bug #1561418 reported by
Daniel van Vugt
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Low
|
Chris Halse Rogers | ||
Bug Description
NBS never uses mc::MultiMonito
I noticed this via high-speed camera measurements. What I found was that NBS has the same latency as BufferQueue-
Grepping the code confirms NBS never makes use of MultiMonitorMod
Related branches
lp:~vanvugt/mir/disable-early-release
- Cemil Azizoglu (community): Approve
- Kevin DuBois (community): Approve
- Mir CI Bot: Approve (continuous-integration)
-
Diff: 277 lines (+83/-13)10 files modifiedsrc/server/compositor/buffer_bundle.h (+8/-0)
src/server/compositor/buffer_queue.cpp (+10/-1)
src/server/compositor/buffer_queue.h (+2/-0)
src/server/compositor/multi_monitor_arbiter.h (+1/-7)
tests/acceptance-tests/test_latency.cpp (+1/-5)
tests/include/mir/test/doubles/mock_buffer_bundle.h (+1/-0)
tests/integration-tests/test_buffer_scheduling.cpp (+27/-0)
tests/integration-tests/test_exchange_buffer.cpp (+1/-0)
tests/unit-tests/compositor/test_buffer_queue.cpp (+31/-0)
tests/unit-tests/compositor/test_temporary_buffers.cpp (+1/-0)
lp:~raof/mir/remove-never-used-code
- Mir CI Bot: Approve (continuous-integration)
- Alan Griffiths: Approve
-
Diff: 219 lines (+11/-45)7 files modifiedsrc/server/compositor/buffer_acquisition.h (+0/-7)
src/server/compositor/multi_monitor_arbiter.cpp (+2/-11)
src/server/compositor/multi_monitor_arbiter.h (+0/-3)
src/server/compositor/stream.cpp (+1/-2)
tests/integration-tests/test_buffer_scheduling.cpp (+0/-2)
tests/unit-tests/compositor/test_multi_monitor_arbiter.cpp (+8/-19)
tests/unit-tests/compositor/test_temporary_buffers.cpp (+0/-1)
| tags: | added: performance |
Revision history for this message
| Mir CI Bot (mir-ci-bot) wrote | #1 |
| Changed in mir: | |
| status: | New → Fix Committed |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #2 |
| Changed in mir: | |
| status: | Fix Committed → Triaged |
| Changed in mir: | |
| milestone: | none → 0.28.0 |
| assignee: | nobody → Chris Halse Rogers (raof) |
| status: | Triaged → Fix Committed |
| Changed in mir: | |
| milestone: | 0.28.0 → 0.27.0 |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.22.0