scope-aggregator

Duplicat scope local ids blocks subsearch

Bug #1554411 reported by Gary.Wang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
scope-aggregator
Fix Released
High
Gary.Wang

Bug Description

When playing around bollywood aggregator scope. Search functionality doesn't work any more.

Log:
...
==== FINAL ORDER: "com.canonical.scopes.eros_eros:bollywood.movies"
==== FINAL ORDER: "com.canonical.scopes.eros_eros:bollywood.movies"
==== FINAL ORDER: "cinema_1"
==== FINAL ORDER: "cinema_2"
==== FINAL ORDER: "cinema_3"
...

[2016-03-08 12:00:50.240449] WARNING: bollywood.canonicalpartners_unity-scope-bollywood: query loop for query "Nba", client: c-989c63b400000000, aggregator: bollywood.canonicalpartners_unity-scope-bollywood, receiver: com.canonical.scopes.eros_eros, details: {"department_id":"","filter_state":{},"metadata":{"cardinality":4,"form_factor":"phone","hints":{"com.canonical.scopes.eros_eros:bollywood.movies":"valueMeansNothing","query-id":2,"session-id":"3bab7a28-bf80-4304-b135-54a0be141e28","user-agent":"release=15.04&scopes-api=1.0.2+15.04.20151218.2-0ubuntu1&plugin=0.5.6+15.04.20160104.1-0ubuntu1&unity8=8.11+15.04.20160122-0ubuntu1&build=29&partner=bq"},"internet_connectivity":true,"locale":"en_US","type":"search_metadata"},"query_string":"Nba","user_data":null}

When declaring a scope that supports multiple keywords more than once in child_scopes.json, this issue can be reproduced 100% during searching.

Related branches

lp:~gary-wzl77/scope-aggregator/fix_1554411
Kyle Nitzsche (community): Approve
Diff: 277 lines (+42/-19)
7 files modified
CMakeLists.txt (+1/-1)
include/query.h (+2/-2)
src/listener.cpp (+2/-0)
src/query.cpp (+6/-2)
src/resultforwarder.cpp (+3/-1)
src/scope.cpp (+1/-0)
src/utils.cpp (+27/-13)
Gary.Wang (gary-wzl77)
Changed in scope-aggregator:
status: New → In Progress
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Hi Gary,

Can you please provide a child_scopes.json for the bollywood scope that has this problem so I can understand it fully? thanks

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

For example, I just tested News Scope with scope-agg release 4.4 and search works, so the statement that "search doesn't work anymore" is perhaps too broad.

Probably you mean to say search doesn't work in the specific case you mentioned, so I'd like to understand it fully.

Cheers

Revision history for this message
Gary.Wang (gary-wzl77) wrote :

Hi Kyle
     I think I didn't explain this issue well enough.
     This issue only happens to keyword scope when search after aggregator supports sorting .

     I put my testing branch here
     bzr branch lp:~hanloon-team/hanloon/bollywood_opt_keyword

     steps to reproduce this bug
    1. Install all bollywod click package in attachments on device.
    2.launch bollywood aggregator scope
    3.query sth in searchbox, e.g. "Nba"

    actual results:
    Scope only shows results from "Eros now", "Shemarro", "ZeeTV" scope, but no results retrieved from cinema scope.

    expected results:
    There should be some results retrieved from cineme scope, alongside with other child scopes("Eros now", "Shemarro", "ZeeTV")

Revision history for this message
Gary.Wang (gary-wzl77) wrote :

fixed with 4.5

Changed in scope-aggregator:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.