[FFe] Add support for launcher at the bottom
Bug #1552630 reported by
Anthony Wong
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Kylin |
Fix Released
|
Undecided
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
Medium
|
Unassigned |
Bug Description
We are working with Unity team for quite some time on merge proposals so that the launcher can be moved to the bottom of the screen, they are pending review.
https:/
https:/
Related branches
lp:~feng-kylin/unity/MoveDashToBottom
- Marco Trevisan (Treviño): Approve
-
Diff: 1051 lines (+369/-139)21 files modifieddash/DashController.cpp (+22/-5)
dash/DashView.cpp (+17/-1)
hud/HudView.cpp (+1/-0)
launcher/AbstractLauncherIcon.h (+1/-0)
launcher/CairoBaseWindow.cpp (+6/-0)
launcher/CairoBaseWindow.h (+1/-0)
launcher/Launcher.h (+2/-1)
launcher/LauncherController.cpp (+12/-0)
launcher/LauncherIcon.cpp (+8/-0)
launcher/LauncherIcon.h (+1/-0)
launcher/MockLauncherIcon.h (+1/-0)
launcher/QuicklistView.cpp (+26/-1)
launcher/SoftwareCenterLauncherIcon.cpp (+0/-1)
launcher/TooltipManager.cpp (+7/-1)
tests/autopilot/unity/tests/launcher/test_keynav.py (+7/-4)
tests/test_launcher.cpp (+1/-0)
unity-shared/DashStyle.cpp (+82/-37)
unity-shared/DashStyle.h (+13/-9)
unity-shared/OverlayRenderer.cpp (+151/-79)
unity-shared/OverlayRenderer.h (+7/-0)
unity-shared/UBusMessages.h (+3/-0)
lp:~feng-kylin/unity/unityshell-rotated-kylin
- Marco Trevisan (Treviño): Approve
-
Diff: 3776 lines (+1504/-456)49 files modifiedcom.canonical.Unity.gschema.xml (+9/-0)
dash/DashController.cpp (+22/-7)
hud/HudController.cpp (+11/-6)
launcher/BFBLauncherIcon.cpp (+4/-3)
launcher/BFBLauncherIcon.h (+1/-1)
launcher/EdgeBarrierController.cpp (+19/-4)
launcher/HudLauncherIcon.cpp (+5/-3)
launcher/HudLauncherIcon.h (+2/-3)
launcher/Launcher.cpp (+337/-94)
launcher/Launcher.h (+5/-0)
launcher/LauncherController.cpp (+57/-33)
launcher/LauncherControllerPrivate.h (+5/-3)
launcher/LauncherIcon.cpp (+8/-1)
launcher/QuicklistView.cpp (+205/-93)
launcher/SoftwareCenterLauncherIcon.cpp (+1/-0)
launcher/Tooltip.cpp (+213/-61)
launcher/Tooltip.h (+4/-0)
panel/PanelView.cpp (+4/-2)
plugins/unityshell/src/unityshell.cpp (+29/-15)
resources/launcher_arrow_btt_19.svg (+18/-0)
resources/launcher_arrow_btt_37.svg (+21/-0)
resources/launcher_arrow_outline_btt_19.svg (+15/-0)
resources/launcher_arrow_outline_btt_37.svg (+19/-0)
resources/launcher_arrow_ttb_19.svg (+16/-0)
resources/launcher_arrow_ttb_37.svg (+21/-0)
resources/launcher_pip_btt_19.svg (+18/-0)
resources/launcher_pip_btt_37.svg (+19/-0)
tests/autopilot/unity/emulators/__init__.py (+8/-1)
tests/autopilot/unity/emulators/launcher.py (+57/-26)
tests/autopilot/unity/tests/launcher/__init__.py (+10/-1)
tests/autopilot/unity/tests/launcher/test_icon_behavior.py (+13/-4)
tests/autopilot/unity/tests/launcher/test_keynav.py (+13/-13)
tests/autopilot/unity/tests/launcher/test_reveal.py (+2/-2)
tests/autopilot/unity/tests/launcher/test_scroll.py (+3/-2)
tests/autopilot/unity/tests/launcher/test_switcher.py (+1/-1)
tests/autopilot/unity/tests/launcher/test_tooltips.py (+2/-2)
tests/autopilot/unity/tests/test_dash.py (+6/-4)
tests/autopilot/unity/tests/test_hud.py (+30/-8)
tests/autopilot/unity/tests/test_quicklist.py (+16/-6)
tests/autopilot/unity/tests/test_spread.py (+1/-1)
tests/autopilot/unity/tests/test_wm_keybindings.py (+8/-2)
tests/test_bfb_launcher_icon.cpp (+1/-1)
tests/test_hud_launcher_icon.cpp (+1/-1)
tests/test_launcher.cpp (+35/-1)
tests/test_launcher_controller.cpp (+20/-0)
unity-shared/IconRenderer.cpp (+134/-37)
unity-shared/SpreadFilter.cpp (+5/-2)
unity-shared/UnitySettings.cpp (+39/-8)
unity-shared/UnitySettings.h (+11/-4)
description: | updated |
description: | updated |
Changed in unity (Ubuntu): | |
importance: | Undecided → Medium |
Changed in ubuntukylin: | |
status: | New → Fix Committed |
Changed in ubuntukylin: | |
milestone: | none → xenial-beta2 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
2 weeks until beta and 6 weeks until release.
I'm worried that if this proves to be buggy then it's going to distract the developers from the many other Unity fixes that are queued up to be worked on (http:// reqorts. qa.ubuntu. com/reports/ rls-mgr/ rls-x-tracking- bug-tasks. html). It's rare that things are 100% straight away, and Unity has had some late feature additions in the past that have required fixing up. These branches are quite large in terms of LOC delta.
I don't think it's going to be a niche feature - this is something that will be promoted and so people will use it, and it'll need to be properly supported.
Why is adding this feature now in 16.04 LTS worth the risk of other fixes not making it?