Ubuntu
systemtap package

systemtap does not work on wily kernel, hrtimer_get_res

Bug #1547644 reported by Dan Streetman
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
systemtap (Ubuntu)
Fix Released
High
Dan Streetman
Wily
Fix Released
High
Dan Streetman

Bug Description

[Impact]

Attempting to use systemtap with any timer on wily fails with:

In file included from /usr/share/systemtap/runtime/timer.c:17:0,
                 from /tmp/stapNgYUlz/stap_d73751f21cb6a8e35c1e92f712612cc2_4574_src.c:869:
/usr/share/systemtap/runtime/linux/timer.c: In function ‘_stp_hrtimer_init’:
/usr/share/systemtap/runtime/linux/timer.c:19:2: error: implicit declaration of function ‘hrtimer_get_res’ [-Werror=implicit-function-declaration]
  hrtimer_get_res (CLOCK_MONOTONIC, &res);
  ^

[Test Case]

on a wily system that's running the wily kernel, with the kernel dbgsym installed, simply create a dummy stap script that uses a timer and try to run it, e.g.:

$ cat test.stap
#!/usr/bin/stap

probe timer.sec(1) {
  println("tick")
}
$ sudo stap test.stap

the above compilation failure will happen.

[Regression Potential]

As the commit only changes the way systemtap uses the kernel timer function, and it already fails now, there is no regression potential.

[Other Info]

this requires upstream systemtap commit 86f726b7785a035a2d6bc9ec2642c46621587d23

See original description
Dan Streetman (ddstreet)
Changed in systemtap (Ubuntu):
status: New → Fix Committed
Changed in systemtap (Ubuntu Wily):
status: New → In Progress
Changed in systemtap (Ubuntu):
assignee: nobody → Dan Streetman (ddstreet)
Changed in systemtap (Ubuntu Wily):
assignee: nobody → Dan Streetman (ddstreet)
Changed in systemtap (Ubuntu):
status: Fix Committed → Fix Released
Dan Streetman (ddstreet)
tags: added: sts
Revision history for this message
Dan Streetman (ddstreet) wrote :

debdiff containing above commit

Revision history for this message
Dan Streetman (ddstreet) wrote :

this can be reproduced with any stap script using a timer, e.g.:

#!/usr/bin/stap

probe timer.sec(1) {
  println("tick")
}

tags: added: sts-sru
Dan Streetman (ddstreet)
description: updated
Mathew Hodson (mhodson)
Changed in systemtap (Ubuntu):
importance: Undecided → High
Changed in systemtap (Ubuntu Wily):
importance: Undecided → High
Revision history for this message
Dan Streetman (ddstreet) wrote :

systemtap patched with attached debdiff tested and verified to fix the compilation error.

Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Dan, or anyone else affected,

Accepted systemtap into wily-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemtap/2.8-2ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in systemtap (Ubuntu Wily):
status: In Progress → Fix Committed
tags: added: verification-needed
Dan Streetman (ddstreet)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package systemtap - 2.8-2ubuntu1.1

---------------
systemtap (2.8-2ubuntu1.1) wily; urgency=medium

  * debian/patches/0001-Fixed-PR18634-by-getting-timer-probes-to-compile-on-.patch:
    - Build for wily kernel. LP: #1547644

 -- Dan Streetman <email address hidden> Fri, 18 Mar 2016 16:58:14 +0100

Changed in systemtap (Ubuntu Wily):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for systemtap has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Louis Bouchard (louis)
tags: removed: sts-sru
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.