Ubuntu
ubuntu-system-settings package

Allow setup of fingerprint auth in Security & Privacy

Bug #1547040 reported by Jonas G. Drange
44
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Unassigned
Canonical System Image 12 "OTA12"
Ubuntu UX
New
Undecided
Unassigned
platform-api
In Progress
High
Thomas Voß
gsettings-ubuntu-touch-schemas (Ubuntu)
In Progress
High
Jonas G. Drange
ubuntu-settings-components (Ubuntu)
In Progress
High
Jonas G. Drange
ubuntu-system-settings (Ubuntu)
Fix Released
Critical
Jonas G. Drange

Bug Description

The panel Security & Privacy should allow for setup of fingerprint authentication for use on the lock screen. The story looks like this:
* A “Fingerprint” item will be added under “Security & Privacy”
* The corresponding “Fingerprint” panel will let you add a passcode if necessary, register a fingerprint, or forget previously recorded fingerprints.
* An “Add Fingerprint” dialog will record fingerprints with buttons “Cancel” and “Done” if recorded successfully.

This is currently blocked due to the fingerprint API being non-existent.

<https://wiki.ubuntu.com/SecurityAndPrivacySettings#Phone>
<https://wiki.ubuntu.com/SecurityAndPrivacySettings#fingerprint>

See original description

Related branches

lp:~jonas-drange/gsettings-ubuntu-touch-schemas/fingerprint
Michael Terry (community): Approve
Diff: 54 lines (+18/-1)
3 files modified
accountsservice/com.ubuntu.AccountsService.SecurityPrivacy.xml (+4/-0)
debian/changelog (+9/-1)
schemas/com.ubuntu.touch.system.gschema.xml.in.in (+5/-0)
lp:~phablet-team/ubuntu-system-settings/fingerprint
Jonas G. Drange (community): Needs Fixing
Ken VanDine: Approve
system-apps-ci-bot: Needs Fixing (continuous-integration)
PS Jenkins bot: Pending (continuous-integration) requested
Diff: 459 lines (+187/-18)
6 files modified
debian/control (+4/-3)
plugins/security-privacy/LockSecurity.qml (+118/-12)
plugins/security-privacy/PageComponent.qml (+27/-1)
plugins/security-privacy/PhoneLocking.qml (+6/-1)
plugins/security-privacy/securityprivacy.cpp (+23/-0)
plugins/security-privacy/securityprivacy.h (+9/-1)
lp:~phablet-team/ubuntu-settings-components/fingerprint
Unity8 CI Bot: Approve (continuous-integration)
Ken VanDine: Needs Fixing
PS Jenkins bot: Pending (continuous-integration) requested
Diff: 4441 lines (+4059/-19)
56 files modified
debian/changelog (+8/-1)
debian/control (+5/-2)
examples/Fingerprint.qml (+43/-0)
plugins/Ubuntu/Settings/CMakeLists.txt (+1/-0)
plugins/Ubuntu/Settings/Fingerprint/CMakeLists.txt (+15/-0)
plugins/Ubuntu/Settings/Fingerprint/CircularSegment.qml (+64/-0)
plugins/Ubuntu/Settings/Fingerprint/DirectionVisual.qml (+103/-0)
plugins/Ubuntu/Settings/Fingerprint/Fingerprint.qml (+133/-0)
plugins/Ubuntu/Settings/Fingerprint/FingerprintVisual.qml (+72/-0)
plugins/Ubuntu/Settings/Fingerprint/Fingerprints.qml (+439/-0)
plugins/Ubuntu/Settings/Fingerprint/SegmentBoundingBoxes.qml (+81/-0)
plugins/Ubuntu/Settings/Fingerprint/SegmentRenderer.qml (+95/-0)
plugins/Ubuntu/Settings/Fingerprint/SegmentedImage.qml (+52/-0)
plugins/Ubuntu/Settings/Fingerprint/Setup.qml (+387/-0)
plugins/Ubuntu/Settings/Fingerprint/StatusLabel.qml (+84/-0)
plugins/Ubuntu/Settings/Fingerprint/assets.qrc (+11/-0)
plugins/Ubuntu/Settings/Fingerprint/assets/fingerprint_boxes.json (+1/-0)
plugins/Ubuntu/Settings/Fingerprint/assets/shape-down@27.sci (+7/-0)
plugins/Ubuntu/Settings/Fingerprint/assets/shape-up@27.sci (+7/-0)
plugins/Ubuntu/Settings/Fingerprint/plugin.cpp (+35/-0)
plugins/Ubuntu/Settings/Fingerprint/plugin.h (+30/-0)
plugins/Ubuntu/Settings/Fingerprint/qmldir (+7/-0)
plugins/Ubuntu/Settings/Fingerprint/ubuntusettingsfingerprint.cpp (+39/-0)
plugins/Ubuntu/Settings/Fingerprint/ubuntusettingsfingerprint.h (+37/-0)
plugins/Ubuntu/Settings/Fingerprint/utils/segment.py (+84/-0)
po/ubuntu-settings-components.pot (+101/-16)
tests/qmltests/CMakeLists.txt (+7/-0)
tests/qmltests/Fingerprint/tst_FingerprintNames.qml (+364/-0)
tests/qmltests/Fingerprint/tst_FingerprintSetup.qml (+236/-0)
tests/qmltests/Fingerprint/tst_FingerprintVisual.qml (+132/-0)
tests/qmltests/Fingerprint/tst_Fingerprints.qml (+230/-0)
tests/qmltests/mocks/Biometryd/CMakeLists.txt (+20/-0)
tests/qmltests/mocks/Biometryd/MockDevice.cpp (+30/-0)
tests/qmltests/mocks/Biometryd/MockDevice.h (+38/-0)
tests/qmltests/mocks/Biometryd/MockFingerprintReader.cpp (+49/-0)
tests/qmltests/mocks/Biometryd/MockFingerprintReader.h (+65/-0)
tests/qmltests/mocks/Biometryd/MockObserver.cpp (+88/-0)
tests/qmltests/mocks/Biometryd/MockObserver.h (+52/-0)
tests/qmltests/mocks/Biometryd/MockOperation.cpp (+34/-0)
tests/qmltests/mocks/Biometryd/MockOperation.h (+36/-0)
tests/qmltests/mocks/Biometryd/MockService.cpp (+42/-0)
tests/qmltests/mocks/Biometryd/MockService.h (+46/-0)
tests/qmltests/mocks/Biometryd/MockTemplateStore.cpp (+56/-0)
tests/qmltests/mocks/Biometryd/MockTemplateStore.h (+86/-0)
tests/qmltests/mocks/Biometryd/MockUser.cpp (+33/-0)
tests/qmltests/mocks/Biometryd/MockUser.h (+38/-0)
tests/qmltests/mocks/Biometryd/plugin.cpp (+60/-0)
tests/qmltests/mocks/Biometryd/plugin.h (+31/-0)
tests/qmltests/mocks/Biometryd/qmldir (+2/-0)
tests/qmltests/mocks/CMakeLists.txt (+32/-0)
tests/qmltests/mocks/GSettings.1.0/CMakeLists.txt (+20/-0)
tests/qmltests/mocks/GSettings.1.0/fake_gsettings.cpp (+124/-0)
tests/qmltests/mocks/GSettings.1.0/fake_gsettings.h (+101/-0)
tests/qmltests/mocks/GSettings.1.0/plugin.cpp (+33/-0)
tests/qmltests/mocks/GSettings.1.0/plugin.h (+31/-0)
tests/qmltests/mocks/GSettings.1.0/qmldir (+2/-0)
Jonas G. Drange (jonas-drange)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ubuntu-system-settings (Ubuntu):
status: New → Confirmed
Matthew Paul Thomas (mpt)
Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Matthew Paul Thomas (mpt)
Jonas G. Drange (jonas-drange)
Changed in ubuntu-system-settings (Ubuntu):
assignee: Matthew Paul Thomas (mpt) → Jonas G. Drange (jonas-drange)
status: Confirmed → In Progress
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Specification updated. <https://wiki.ubuntu.com/SecurityAndPrivacySettings?action=diff&rev2=74&rev1=73>

description: updated
description: updated
Thomas Voß (thomas-voss)
Changed in platform-api:
assignee: nobody → Thomas Voß (thomas-voss)
status: New → In Progress
importance: Undecided → High
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

@mpt, it's currently hard/impossible to obtain the number of enrolled fingerprints. Also, Thomas points out that multiple enrolled fingerprints per user does not necessarily make sense in a multi-user environment like Ubuntu is.

Additionally, the enrollment screen should perhaps allow for more nuanced error messages than “Sorry, the reader doesn’t seem to be working.”. The reader could be malfunctioning, but the enrollment would also fail if the image was bad, e.g.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

I don’t see why System Settings needs to “obtain the number of enrolled fingerprints”. System Settings is the only access point through which you can register a fingerprint, so it can keep count itself. Even later, once the first-run setup lets you register fingerprints too, it could place an initial count somewhere that System Settings can read.

Can you explain how multiple fingerprints vs. multiple users are related? The purpose of registering multiple fingerprints is so that you can, for example, register one on each hand, to avoid having to juggle a baby, briefcase, shopping bag, or whatever you’re carrying with your other hand.

For the error messages, could you provide a complete list of possible error messages/codes returned by the reader?

description: updated
Revision history for this message
Jonas G. Drange (jonas-drange) wrote : Re: [Bug 1547040] Re: Allow setup of fingerprint auth in Security & Privacy

On 25 March 2016 at 11:39, Matthew Paul Thomas <email address hidden> wrote:

> System Settings is the only access point through which
> you can register a fingerprint, so it can keep count itself.

​So the Wizard will not ever provide fingerprint ID setup?​

> Can you explain how multiple fingerprints vs. multiple users are
> related?

> For the error messages, could you provide a complete list of possible
> error messages/codes returned by the reader?
>
>
​Both of these will hopefully be addressed by Thomas.​

Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

The question “​So the Wizard will not ever provide fingerprint ID setup?​” is based on an assumption that the two can't talk among themselves, which is false, so I'm going to retract this question.

From the spec:
> “Fingerprint” should be disabled unless you currently have at least one fingerprint registered.

This is one reason why we need the count: To communicate to the user, in the “Lock security” screen, that Fingerprint ID is only possible if correctly set up (i.e. some fingerprint has been enrolled). It's easy to know this if we have a count, which we will put in AccountsService so it is accessible by both the Wizard and System Settings.

Jonas G. Drange (jonas-drange)
Changed in ubuntu-system-settings (Ubuntu):
importance: Undecided → Critical
Jonas G. Drange (jonas-drange)
Changed in gsettings-ubuntu-touch-schemas (Ubuntu):
status: New → In Progress
Changed in ubuntu-settings-components (Ubuntu):
status: New → In Progress
assignee: nobody → Jonas G. Drange (jonas-drange)
Changed in gsettings-ubuntu-touch-schemas (Ubuntu):
assignee: nobody → Jonas G. Drange (jonas-drange)
importance: Undecided → High
Changed in ubuntu-settings-components (Ubuntu):
importance: Undecided → High
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: New → Fix Committed
milestone: none → 12
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.4+16.10.20160619-0ubuntu1

---------------
ubuntu-system-settings (0.4+16.10.20160619-0ubuntu1) yakkety; urgency=medium

  [ jonas-drange ]
  * expose fingerprint ID panel and the Fingerprint lock setting (LP:
    #1547040)

 -- Ken VanDine <email address hidden> Sun, 19 Jun 2016 02:48:24 +0000

Changed in ubuntu-system-settings (Ubuntu):
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.