Popovers doesn’t allow overriding onEscapePressed

I suppose this could be fixed in at least a couple of ways:

 - implementing the escapePressed handler on the top-level Popover element, instead of on its foreground child (I just did a quick test and it seems that in this case, if overriden, both the original handler and the override are called, not sure whether that’s intended or a bug in QML, but in any case that would work for our use case)

 - adding a cancel() or escape() signal on the popover which would be emitted when ESC is pressed, thus allowing embedders to do specific processing, while keeping the default behaviour of closing the popover

A third option (maybe better than the previous two) would be to keep the implementation as it is, but after calling hide() in the escapePressed handler, set event.accepted to false, so that the event bubbles up.

If a component consumes a key event, my feeling is that it should not propagate it up, unless we want to make an exception. That is point of handling key events after all ;)

Just my 2 cents

A Popover is closed automatically if you click outside of it. Esc and outside click is basically the same thing. In any other circumstances it is the developer who closes it, for instance when an action is selected. So there shouldn't be any difference between handling Esc or outside click. Any other closing case can be captured by the actions assigned to close the Popover.

I see the Browser's bookmarking popover has a Cancel action on the bottom. This is pretty confusing as Popovers are not Dialogs, which would need an explicit action on their layout to be able to close - Esc or outside click does the job.

But really, what si the use case you need to know the Popover was dismissed?

Just filed bug #1546698 in the hope that design can comment on the current bookmark options popover in the browser. Depending on their answer, we might be able to mark this bug invalid.

[Expired for ubuntu-ui-toolkit (Ubuntu) because there has been no activity for 60 days.]