Pcbnew: length matching dialog shows "45-degree," but miters are still round

Bug #1545856 reported by Sam
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Undecided
Jeff Young

Bug Description

I'm not sure if this is a bug or a feature request, but I'll put it here just in case.

When length-tuning a trace or tuning diff pair skew, the settings dialog for length tuning shows "miter style" as being "45-degree" sometimes. There doesn't seem to be any pattern to it; it'll do it one time but the next time you open the settings, it doesn't. (screenshot attached)

Graphical glitches aside, I don't think it would be too hard to actually implement a 45-degree miter style. Just about every commercially produced PCB out there uses them in length matching. To me, 45-degree is better because it allows for easier editing of the meanders in the traces (as opposed to manually moving/creating 16 traces per arc).

I have attached an image containing both the current pcbnew settings window and three different length tuning miter styles from Altium.

Revision history for this message
Sam (samuelchinnery) wrote :
Revision history for this message
Sam (samuelchinnery) wrote :

Additionally, if at all possible, it would be helpful if the "constraint" drop-down box had an "automatic" selection. I know this would involve quite a bit of work, specifically in implementing a constraint manager, but I am also sure it would be of great use to many KiCad users developing high speed boards (there are more than you probably think!). Again, I don't mean to nag, but I have no idea where else to put feature requests like this.

Thanks,
Sam

Changed in kicad:
assignee: nobody → Tomasz Wlostowski (twlostow)
Revision history for this message
Benjamin Kohl (ben-819) wrote :

Yes, length matching with 45-degrees maender would be nice. Its easier to edit.

Revision history for this message
Sam (samuelchinnery) wrote :

Just from browsing the source code, it appears the code is already present to allow 45-degree miters. The settings dialog has it as an option in the drop-down box, and it is defined as a miter style. Perhaps it would be easiest to implement using an "arc" with only three segments at 45-degrees to each other?

Sam (samuelchinnery)
Changed in kicad:
status: New → Confirmed
Revision history for this message
Jeff Young (jeyjey) wrote :

45-degree mitering has been implemented. However there are some bugs in this area:

1) Length tooltip stays on screen (at least on OSX) when Length Tuning Settings... dialog is up, obscuring some of its settings.

2) Context menu displays before starting the tuning, but the dialog won't come up.

3) 'L' shortcut to bring dialog up doesn't work (at least on OSX).

4) Radius is disabled for diff-pair tuning (probably because it doesn't work well), but it isn't reset to 100% so if you set it to 25% for a single track and then do a diff pair it'll be messed up.

5) The Miter Style label is always greyed out.

Changed in kicad:
assignee: Tomasz Wlostowski (twlostow) → Jeff Young (jeyjey)
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 63c9e11aae477630dfb14654c7c70d3fe6f9be4f
https://git.launchpad.net/kicad/patch/?id=63c9e11aae477630dfb14654c7c70d3fe6f9be4f

Changed in kicad:
status: Confirmed → Fix Committed
Revision history for this message
Seth Hillbrand (sethh) wrote :

Jeff-

I think that this patch has a bug in pns_meander.cpp. m_type is not a PNS_MODE enum but a MT_ enum.

Revision history for this message
Jeff Young (jeyjey) wrote : Re: [Bug 1545856] Re: Pcbnew: length matching dialog shows "45-degree, " but miters are still round

Nice catch, Seth. It certainly does. Fix coming….

> On 21 May 2018, at 01:26, Seth Hillbrand <email address hidden> wrote:
>
> Jeff-
>
> I think that this patch has a bug in pns_meander.cpp. m_type is not a
> PNS_MODE enum but a MT_ enum.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1545856
>
> Title:
> Pcbnew: length matching dialog shows "45-degree," but miters are still
> round
>
> Status in KiCad:
> Fix Committed
>
> Bug description:
> I'm not sure if this is a bug or a feature request, but I'll put it
> here just in case.
>
> When length-tuning a trace or tuning diff pair skew, the settings
> dialog for length tuning shows "miter style" as being "45-degree"
> sometimes. There doesn't seem to be any pattern to it; it'll do it one
> time but the next time you open the settings, it doesn't. (screenshot
> attached)
>
> Graphical glitches aside, I don't think it would be too hard to
> actually implement a 45-degree miter style. Just about every
> commercially produced PCB out there uses them in length matching. To
> me, 45-degree is better because it allows for easier editing of the
> meanders in the traces (as opposed to manually moving/creating 16
> traces per arc).
>
> I have attached an image containing both the current pcbnew settings
> window and three different length tuning miter styles from Altium.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1545856/+subscriptions

Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision cdde4c4b40da1d80eb62279ea6c8ac9e32569473
https://git.launchpad.net/kicad/patch/?id=cdde4c4b40da1d80eb62279ea6c8ac9e32569473

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.