MAAS 1.9+ should not allow whitespace characters in space names
Bug #1543707 reported by
Dimiter Naydenov
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Unassigned | ||
| 1.9 |
Fix Released
|
High
|
Unassigned | ||
Bug Description
Currently (1.9.0, likely also 1.10) MAAS allows users to create spaces with names containing whitespace (" ").
This can lead to bad UX and confusion, e.g. all of the following examples work with the CLI:
$ maas profile spaces create name=" " (4 spaces only)
$ maas profile spaces create name="_ _ _" (underscores and spaces)
It also causes issues for Juju, as space characters are not allowed in constraints.
Related branches
lp:~lamont/maas/bug-1543707
- Blake Rouse (community): Approve
-
Diff: 284 lines (+174/-15)6 files modifieddocs/changelog.rst (+4/-0)
src/maasserver/migrations/builtin/maasserver/0051_space_fabric_unique.py (+80/-0)
src/maasserver/models/fabric.py (+23/-8)
src/maasserver/models/space.py (+25/-7)
src/maasserver/models/tests/test_fabric.py (+21/-0)
src/maasserver/models/tests/test_space.py (+21/-0)
lp:~lamont/maas/bug-1543707-1.9
- Blake Rouse (community): Approve
-
Diff: 320 lines (+158/-20)7 files modifieddocs/changelog.rst (+4/-0)
src/maasserver/models/fabric.py (+24/-6)
src/maasserver/models/space.py (+27/-6)
src/maasserver/models/tests/test_fabric.py (+27/-0)
src/maasserver/models/tests/test_space.py (+27/-0)
src/maasserver/testing/factory.py (+0/-2)
src/maasserver/websockets/tests/test_listener.py (+49/-6)
lp:~lamont/maas/bug-1543707b
- Blake Rouse (community): Approve
-
Diff: 46 lines (+13/-1)3 files modifiedsrc/maasserver/models/fabric.py (+1/-1)
src/maasserver/models/tests/test_fabric.py (+6/-0)
src/maasserver/models/tests/test_space.py (+6/-0)
| Changed in maas: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| milestone: | none → 2.0.0 |
| tags: | added: networking |
| Changed in maas: | |
| status: | Triaged → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
