Sahra-extra swift-client doesn't send correct domain in PasswordAuthenticationRequestV3

Bug #1540274 reported by Marc-Alexander Jäger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
High
Michael Ionkin

Bug Description

When using the sahara-extra swift-client in Version 3, the domain attribute isn't sent correctly:

in sahara-extra/hadoop-swiftfs/src/main/java/org/apache/hadoop/fs/swift/http/SwiftRestClient.java the domain name should be given to the PasswordCredentialsV3:

'new PasswordCredentialsV3(username, password, null));'

should be

'new PasswordCredentialsV3(username, password, domain_name));'

and in the sahara-extra/hadoop-swiftfs/src/main/java/org/apache/hadoop/fs/swift/auth/PasswordAuthenticationRequestV3.java
the"ProjectWrapper" has to be adopted accordingly:

'public ProjectWrapper(String projectName) {
       this.domain = new HashMap();
       this.domain.put("id", "default");'

should be

'public ProjectWrapper(String projectName, Map<String, String> odomain) {
       this.domain = odomain;'

Best regards
Marc

Changed in sahara:
assignee: nobody → Michael Ionkin (msionkin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara-extra (master)

Fix proposed to branch: master
Review: https://review.openstack.org/291323

Changed in sahara:
status: New → In Progress
Changed in sahara:
importance: Undecided → High
milestone: none → mitaka-rc1
Revision history for this message
Marc-Alexander Jäger (marc-alexander-jaeger) wrote :

Hi Michael, Vitaly,

cool, thanks for all your work. Will the "ProjectWrapper" class also be adopted?

Best regarsd
Marc

Revision history for this message
Michael Ionkin (msionkin) wrote :

Hi Marc,

yes, it will, but after some research.

Michael

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara-extra (master)

Reviewed: https://review.openstack.org/291323
Committed: https://git.openstack.org/cgit/openstack/sahara-extra/commit/?id=a1e4d4ebbe324a12551474195cd6bfb21fc321ad
Submitter: Jenkins
Branch: master

commit a1e4d4ebbe324a12551474195cd6bfb21fc321ad
Author: Michael Ionkin <email address hidden>
Date: Thu Mar 10 20:32:35 2016 +0300

    Fix sending domain name in swift-client

    This patch fixes the domain_name parameter which is sent incorrectly
    when using Identity API V3 for swift authentication

    Change-Id: Ide155d425216a08c1c4d23af7f7bb5496ef4edd3
    Closes-Bug: #1540274

Changed in sahara:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/sahara-extra 4.0.0.0rc1

This issue was fixed in the openstack/sahara-extra 4.0.0.0rc1 release candidate.

Luigi Toscano (ltoscano)
tags: added: sahara-extra
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.