oops when changing git-based MP status before ajax has loaded
Bug #1538355 reported by
Thomi Richards
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Maximiliano Bertacchini | ||
Bug Description
To reproduce:
Load a git-based merge proposal.
Click the "pencil" icon for the merge proposal status at the top of the page right after the page loads, before the AJAX stuff has loaded.
I can consistent cause a launchpad oops.
Example oops: OOPS-7ee59c2a4a6e73690bd459349fb8bc6b
Related branches
lp:~maxiberta/launchpad/fix-git-merge-editstatus
- Celso Providelo (community): Approve
- Launchpad code reviewers: Pending requested
-
Diff: 110 lines (+22/-15)5 files modifiedlib/lp/code/browser/branchmergeproposal.py (+9/-5)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+12/-0)
lib/lp/code/model/tests/test_gitrepository.py (+0/-4)
lib/lp/code/templates/branchmergeproposal-editstatus.pt (+1/-1)
lib/lp/codehosting/scanner/tests/test_bzrsync.py (+0/-5)
Revision history for this message
| Thomi Richards (thomir-deactivatedaccount) wrote | #1 |
| tags: | added: code-review git oops ui |
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → Critical |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Maximiliano Bertacchini (maxiberta) |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → Incomplete |
| status: | Incomplete → New |
| status: | New → Fix Released |
| Changed in launchpad: | |
| status: | Fix Released → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
In case it matters, and you can't tell from the error report, this was triggered from: https:/